diff options
author | Stas Vilchik <stas.vilchik@sonarsource.com> | 2018-12-10 14:06:35 +0100 |
---|---|---|
committer | SonarTech <sonartech@sonarsource.com> | 2019-01-08 20:21:06 +0100 |
commit | f085494e7c0a846c4e293cd4cc07ccc87bbf9b82 (patch) | |
tree | 6287eb08a039e6a6376af43f0d9a83c4e8f1d5f6 /server/sonar-web/src/main/js/apps/quality-gates/components/ConditionModal.tsx | |
parent | ceedfa6d9ad9239289e1e6d170b9400b7ec6b36a (diff) | |
download | sonarqube-f085494e7c0a846c4e293cd4cc07ccc87bbf9b82.tar.gz sonarqube-f085494e7c0a846c4e293cd4cc07ccc87bbf9b82.zip |
SONAR-11570 drop ability to set period from UI
Diffstat (limited to 'server/sonar-web/src/main/js/apps/quality-gates/components/ConditionModal.tsx')
-rw-r--r-- | server/sonar-web/src/main/js/apps/quality-gates/components/ConditionModal.tsx | 31 |
1 files changed, 2 insertions, 29 deletions
diff --git a/server/sonar-web/src/main/js/apps/quality-gates/components/ConditionModal.tsx b/server/sonar-web/src/main/js/apps/quality-gates/components/ConditionModal.tsx index 686450f80d8..e480bd53c91 100644 --- a/server/sonar-web/src/main/js/apps/quality-gates/components/ConditionModal.tsx +++ b/server/sonar-web/src/main/js/apps/quality-gates/components/ConditionModal.tsx @@ -21,10 +21,8 @@ import * as React from 'react'; import AddConditionSelect from './AddConditionSelect'; import ConditionOperator from './ConditionOperator'; import ThresholdInput from './ThresholdInput'; -import Period from './Period'; import { translate, getLocalizedMetricName } from '../../../helpers/l10n'; import { createCondition, updateCondition } from '../../../api/quality-gates'; -import { isDiffMetric } from '../../../helpers/measures'; import ConfirmModal from '../../../components/controls/ConfirmModal'; import { Alert } from '../../../components/ui/Alert'; @@ -44,7 +42,6 @@ interface State { errorMessage?: string; metric?: T.Metric; op?: string; - period: boolean; } export default class ConditionModal extends React.PureComponent<Props, State> { @@ -54,7 +51,6 @@ export default class ConditionModal extends React.PureComponent<Props, State> { super(props); this.state = { error: props.condition ? props.condition.error : '', - period: props.condition ? props.condition.period === 1 : false, metric: props.metric ? props.metric : undefined, op: props.condition ? props.condition.op : undefined }; @@ -69,21 +65,11 @@ export default class ConditionModal extends React.PureComponent<Props, State> { } getUpdatedCondition = (metric: T.Metric) => { - const data: T.Omit<T.Condition, 'id'> = { + return { metric: metric.key, op: metric.type === 'RATING' ? 'GT' : this.state.op, error: this.state.error }; - - const { period } = this.state; - if (period && metric.type !== 'RATING') { - data.period = period ? 1 : 0; - } - - if (isDiffMetric(metric.key)) { - data.period = 1; - } - return data; }; handleFormSubmit = () => { @@ -105,10 +91,6 @@ export default class ConditionModal extends React.PureComponent<Props, State> { this.setState({ metric }); }; - handlePeriodChange = (period: boolean) => { - this.setState({ period }); - }; - handleOperatorChange = (op: string) => { this.setState({ op }); }; @@ -119,7 +101,7 @@ export default class ConditionModal extends React.PureComponent<Props, State> { render() { const { header, metrics, onClose } = this.props; - const { period, op, error, metric } = this.state; + const { op, error, metric } = this.state; return ( <ConfirmModal confirmButtonText={header} @@ -140,15 +122,6 @@ export default class ConditionModal extends React.PureComponent<Props, State> { {metric && ( <> <div className="modal-field"> - <label>{translate('quality_gates.conditions.new_code')}</label> - <Period - canEdit={true} - metric={metric} - onPeriodChange={this.handlePeriodChange} - period={period} - /> - </div> - <div className="modal-field"> <label>{translate('quality_gates.conditions.operator')}</label> <ConditionOperator canEdit={true} |