diff options
author | Wouter Admiraal <wouter.admiraal@sonarsource.com> | 2019-08-09 10:23:50 +0200 |
---|---|---|
committer | SonarTech <sonartech@sonarsource.com> | 2019-10-28 20:21:09 +0100 |
commit | 24963a443c4459d03baab2b583e3690250d056aa (patch) | |
tree | 57a09116dd92d3990d15ecdae502a17a52b97e7d /server/sonar-web/src/main/js/apps/system | |
parent | 5394a58739dd14d397ae5594cb92b408b29ccc58 (diff) | |
download | sonarqube-24963a443c4459d03baab2b583e3690250d056aa.tar.gz sonarqube-24963a443c4459d03baab2b583e3690250d056aa.zip |
Improve Edition handling
Diffstat (limited to 'server/sonar-web/src/main/js/apps/system')
-rw-r--r-- | server/sonar-web/src/main/js/apps/system/__tests__/utils-test.ts | 9 | ||||
-rw-r--r-- | server/sonar-web/src/main/js/apps/system/utils.ts | 11 |
2 files changed, 11 insertions, 9 deletions
diff --git a/server/sonar-web/src/main/js/apps/system/__tests__/utils-test.ts b/server/sonar-web/src/main/js/apps/system/__tests__/utils-test.ts index b90fab875f1..f760288d215 100644 --- a/server/sonar-web/src/main/js/apps/system/__tests__/utils-test.ts +++ b/server/sonar-web/src/main/js/apps/system/__tests__/utils-test.ts @@ -19,6 +19,7 @@ */ /* eslint-disable sonarjs/no-duplicate-string */ import { mockClusterSysInfo, mockStandaloneSysInfo } from '../../../helpers/testMocks'; +import { SystemUpgrade } from '../../../types/system'; import * as u from '../utils'; describe('parseQuery', () => { @@ -80,7 +81,7 @@ describe('sortUpgrades', () => { { version: '5.10' }, { version: '5.1' }, { version: '5.4' } - ] as T.SystemUpgrade[]) + ] as SystemUpgrade[]) ).toEqual([{ version: '5.10' }, { version: '5.4.2' }, { version: '5.4' }, { version: '5.1' }]); expect( u.sortUpgrades([ @@ -88,7 +89,7 @@ describe('sortUpgrades', () => { { version: '5.1.2' }, { version: '6.0' }, { version: '6.9' } - ] as T.SystemUpgrade[]) + ] as SystemUpgrade[]) ).toEqual([{ version: '6.9' }, { version: '6.0' }, { version: '5.10' }, { version: '5.1.2' }]); }); }); @@ -101,7 +102,7 @@ describe('groupUpgrades', () => { { version: '5.4.2' }, { version: '5.4' }, { version: '5.1' } - ] as T.SystemUpgrade[]) + ] as SystemUpgrade[]) ).toEqual([ [{ version: '5.10' }, { version: '5.4.2' }, { version: '5.4' }, { version: '5.1' }] ]); @@ -112,7 +113,7 @@ describe('groupUpgrades', () => { { version: '6.0' }, { version: '5.10' }, { version: '5.4.2' } - ] as T.SystemUpgrade[]) + ] as SystemUpgrade[]) ).toEqual([ [{ version: '6.9' }, { version: '6.7' }, { version: '6.0' }], [{ version: '5.10' }, { version: '5.4.2' }] diff --git a/server/sonar-web/src/main/js/apps/system/utils.ts b/server/sonar-web/src/main/js/apps/system/utils.ts index 9b75c19d451..2df36614aae 100644 --- a/server/sonar-web/src/main/js/apps/system/utils.ts +++ b/server/sonar-web/src/main/js/apps/system/utils.ts @@ -25,6 +25,7 @@ import { parseAsString, serializeStringArray } from 'sonar-ui-common/helpers/query'; +import { SystemUpgrade } from '../../types/system'; export interface Query { expandedCards: string[]; @@ -230,15 +231,15 @@ export const serializeQuery = memoize( }) ); -export function sortUpgrades(upgrades: T.SystemUpgrade[]): T.SystemUpgrade[] { +export function sortUpgrades(upgrades: SystemUpgrade[]): SystemUpgrade[] { return sortBy(upgrades, [ - (upgrade: T.SystemUpgrade) => -Number(upgrade.version.split('.')[0]), - (upgrade: T.SystemUpgrade) => -Number(upgrade.version.split('.')[1] || 0), - (upgrade: T.SystemUpgrade) => -Number(upgrade.version.split('.')[2] || 0) + (upgrade: SystemUpgrade) => -Number(upgrade.version.split('.')[0]), + (upgrade: SystemUpgrade) => -Number(upgrade.version.split('.')[1] || 0), + (upgrade: SystemUpgrade) => -Number(upgrade.version.split('.')[2] || 0) ]); } -export function groupUpgrades(upgrades: T.SystemUpgrade[]): T.SystemUpgrade[][] { +export function groupUpgrades(upgrades: SystemUpgrade[]): SystemUpgrade[][] { const groupedVersions = groupBy(upgrades, upgrade => upgrade.version.split('.')[0]); const sortedMajor = sortBy(Object.keys(groupedVersions), key => -Number(key)); return sortedMajor.map(key => groupedVersions[key]); |