diff options
| author | Andrey Luiz <andrey.luiz@sonarsource.com> | 2023-06-21 14:17:48 +0200 |
|---|---|---|
| committer | sonartech <sonartech@sonarsource.com> | 2023-06-21 20:03:06 +0000 |
| commit | 48748d04ba6a59cbbcfa84ca07bc1a7e99829110 (patch) | |
| tree | 48504e084be2e50fa26aaaf5938deb209a7faca8 /server/sonar-web | |
| parent | 288eceadc2c213031d5d456b8e1634f81625ff1a (diff) | |
| download | sonarqube-48748d04ba6a59cbbcfa84ca07bc1a7e99829110.tar.gz sonarqube-48748d04ba6a59cbbcfa84ca07bc1a7e99829110.zip | |
New Code definition UX validation fixes (#8622)
Diffstat (limited to 'server/sonar-web')
3 files changed, 9 insertions, 10 deletions
diff --git a/server/sonar-web/src/main/js/apps/create/project/CreateProjectPage.tsx b/server/sonar-web/src/main/js/apps/create/project/CreateProjectPage.tsx index 29f69c240c4..7b2abaa73dd 100644 --- a/server/sonar-web/src/main/js/apps/create/project/CreateProjectPage.tsx +++ b/server/sonar-web/src/main/js/apps/create/project/CreateProjectPage.tsx @@ -329,7 +329,7 @@ export class CreateProjectPage extends React.PureComponent<CreateProjectPageProp onNcdChanged={this.handleNcdChanged} /> - <div className="sw-flex sw-flex-row sw-gap-2 sw-mt-4"> + <div className="sw-flex sw-flex-row sw-gap-4 sw-mt-4"> <ButtonLink onClick={this.handleGoBack}>{translate('back')}</ButtonLink> <SubmitButton onClick={this.handleProjectCreation} diff --git a/server/sonar-web/src/main/js/apps/projectBaseline/styles.css b/server/sonar-web/src/main/js/apps/projectBaseline/styles.css index 9967cf27b7f..5e09ae45cbc 100644 --- a/server/sonar-web/src/main/js/apps/projectBaseline/styles.css +++ b/server/sonar-web/src/main/js/apps/projectBaseline/styles.css @@ -28,10 +28,6 @@ padding-top: 2px; } -.project-baseline-selector .general-setting { - margin-left: 7px; -} - .branch-baseline-selector > hr { margin: 0 calc(-4 * var(--gridSize)) calc(4 * var(--gridSize)); } diff --git a/server/sonar-web/src/main/js/components/new-code-definition/GlobalNewCodeDefinitionDescription.tsx b/server/sonar-web/src/main/js/components/new-code-definition/GlobalNewCodeDefinitionDescription.tsx index 2751b703257..cf41e0236f6 100644 --- a/server/sonar-web/src/main/js/components/new-code-definition/GlobalNewCodeDefinitionDescription.tsx +++ b/server/sonar-web/src/main/js/components/new-code-definition/GlobalNewCodeDefinitionDescription.tsx @@ -53,11 +53,14 @@ export default function GlobalNewCodeDefinitionDescription({ return ( <> - <div className="general-setting display-flex-start"> - <span className="sw-font-bold flex-0">{setting}: </span> - <span> - {description} {useCase} - </span> + <div className="sw-flex sw-flex-col sw-gap-2 sw-max-w-[800px]"> + <span className="sw-font-bold flex-0">{setting}</span> + {isGlobalNcdCompliant && ( + <> + <span>{description}</span> + <span>{useCase}</span> + </> + )} </div> {!isGlobalNcdCompliant && ( <Alert variant="warning" className="sw-mt-4 sw-max-w-[800px]"> |