Added monitoring and telemetry to SonarLint push feature. (#5315)

* SONAR-15921 add number of connected sonarlint clients to telemetry

2 files changed, 5 insertions, 7 deletions

diff --git a/server/sonar-webserver-pushapi/src/main/java/org/sonar/server/pushapi/sonarlint/SonarLintClientsRegistry.java b/server/sonar-webserver-pushapi/src/main/java/org/sonar/server/pushapi/sonarlint/SonarLintClientsRegistry.java
index 44d9fa4917d..b3319ddc579 100644
--- a/server/sonar-webserver-pushapi/src/main/java/org/sonar/server/pushapi/sonarlint/SonarLintClientsRegistry.java
+++ b/server/sonar-webserver-pushapi/src/main/java/org/sonar/server/pushapi/sonarlint/SonarLintClientsRegistry.java
@@ -19,7 +19,6 @@
  */
 package org.sonar.server.pushapi.sonarlint;
 
-import com.google.common.annotations.VisibleForTesting;
 import java.util.List;
 import java.util.concurrent.CopyOnWriteArrayList;
 import javax.servlet.AsyncEvent;
@@ -47,9 +46,8 @@ public class SonarLintClientsRegistry {
     LOG.debug("Removing SonarLint client");
   }
 
-  @VisibleForTesting
-  List<SonarLintClient> getAllClients() {
-    return clients;
+  public long countConnectedClients() {
+    return clients.size();
   }
 
   class SonarLintClientEventsListener implements AsyncListener {
diff --git a/server/sonar-webserver-pushapi/src/test/java/org/sonar/server/pushapi/sonarlint/SonarLintClientsRegistryTest.java b/server/sonar-webserver-pushapi/src/test/java/org/sonar/server/pushapi/sonarlint/SonarLintClientsRegistryTest.java
index f6f0ccd68f7..a70886166ea 100644
--- a/server/sonar-webserver-pushapi/src/test/java/org/sonar/server/pushapi/sonarlint/SonarLintClientsRegistryTest.java
+++ b/server/sonar-webserver-pushapi/src/test/java/org/sonar/server/pushapi/sonarlint/SonarLintClientsRegistryTest.java
@@ -48,11 +48,11 @@ public class SonarLintClientsRegistryTest {
 
     underTest.registerClient(sonarLintClient);
 
-    assertThat(underTest.getAllClients()).hasSize(1);
+    assertThat(underTest.countConnectedClients()).isEqualTo(1);
 
     underTest.unregisterClient(sonarLintClient);
 
-    assertThat(underTest.getAllClients()).isEmpty();
+    assertThat(underTest.countConnectedClients()).isZero();
   }
 
   @Test
@@ -63,7 +63,7 @@ public class SonarLintClientsRegistryTest {
       underTest.registerClient(sonarLintClient);
     }
 
-    assertThat(underTest.getAllClients()).hasSize(10);
+    assertThat(underTest.countConnectedClients()).isEqualTo(10);
   }
 
 }