diff options
| author | Eric Hartmann <hartmann.eric@gmail.com> | 2018-04-14 20:13:34 +0200 |
|---|---|---|
| committer | SonarTech <sonartech@sonarsource.com> | 2018-04-17 20:20:48 +0200 |
| commit | 3a4cd557bc1448a83e1f8bcd0c2fe3de1a698ca7 (patch) | |
| tree | f4ee1bc6c76eb2948fb63112f2c3c54bf5627a04 /server | |
| parent | 7f88e7c22d4b61d36cbb4a62990f5fe144e80c2d (diff) | |
| download | sonarqube-3a4cd557bc1448a83e1f8bcd0c2fe3de1a698ca7.tar.gz sonarqube-3a4cd557bc1448a83e1f8bcd0c2fe3de1a698ca7.zip | |
Fix quality flaws
Diffstat (limited to 'server')
3 files changed, 1 insertions, 3 deletions
diff --git a/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v72/PopulateHashMethodOnUsersTest.java b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v72/PopulateHashMethodOnUsersTest.java index 254e9da4f07..3ce76a5f286 100644 --- a/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v72/PopulateHashMethodOnUsersTest.java +++ b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v72/PopulateHashMethodOnUsersTest.java @@ -35,7 +35,6 @@ import static org.assertj.core.api.Assertions.assertThat; public class PopulateHashMethodOnUsersTest { - private static final long PAST = 5_000_000_000L; private static final long NOW = 10_000_000_000L; @Rule diff --git a/server/sonar-server/src/main/java/org/sonar/server/authentication/LocalAuthentication.java b/server/sonar-server/src/main/java/org/sonar/server/authentication/LocalAuthentication.java index c7efae31e9f..73fef18b235 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/authentication/LocalAuthentication.java +++ b/server/sonar-server/src/main/java/org/sonar/server/authentication/LocalAuthentication.java @@ -172,7 +172,7 @@ public class LocalAuthentication { .setSalt(salt); } - private String hash(String salt, String password) { + private static String hash(String salt, String password) { return DigestUtils.sha1Hex("--" + salt + "--" + password + "--"); } } diff --git a/server/sonar-server/src/main/java/org/sonar/server/user/UserUpdater.java b/server/sonar-server/src/main/java/org/sonar/server/user/UserUpdater.java index f1ec17669f4..cdfc0b80716 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/user/UserUpdater.java +++ b/server/sonar-server/src/main/java/org/sonar/server/user/UserUpdater.java @@ -21,7 +21,6 @@ package org.sonar.server.user; import com.google.common.base.Joiner; import com.google.common.base.Strings; -import java.security.SecureRandom; import java.util.ArrayList; import java.util.Collections; import java.util.HashSet; |