diff options
author | Wouter Admiraal <wouter.admiraal@sonarsource.com> | 2023-05-02 11:35:43 +0200 |
---|---|---|
committer | sonartech <sonartech@sonarsource.com> | 2023-05-02 20:02:55 +0000 |
commit | e33c08330e12b059bed035802ded75373c2adf7e (patch) | |
tree | 1ec41924748a04325084705f27b7030e6b32b4a3 /server | |
parent | eb1a7b7ac94516f2e33313c7d9b3d18de589af79 (diff) | |
download | sonarqube-e33c08330e12b059bed035802ded75373c2adf7e.tar.gz sonarqube-e33c08330e12b059bed035802ded75373c2adf7e.zip |
SONAR-19149 Fix rule link for external issues
Diffstat (limited to 'server')
-rw-r--r-- | server/sonar-web/src/main/js/apps/issues/components/IssueHeader.tsx | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/server/sonar-web/src/main/js/apps/issues/components/IssueHeader.tsx b/server/sonar-web/src/main/js/apps/issues/components/IssueHeader.tsx index 2f6efa9eb55..c3f4ed614a7 100644 --- a/server/sonar-web/src/main/js/apps/issues/components/IssueHeader.tsx +++ b/server/sonar-web/src/main/js/apps/issues/components/IssueHeader.tsx @@ -33,6 +33,7 @@ import { translate } from '../../../helpers/l10n'; import { getKeyboardShortcutEnabled } from '../../../helpers/preferences'; import { getComponentIssuesUrl, getRuleUrl } from '../../../helpers/urls'; import { BranchLike } from '../../../types/branch-like'; +import { IssueType } from '../../../types/issues'; import { RuleStatus } from '../../../types/rules'; import { Issue, RuleDetails } from '../../../types/types'; @@ -120,7 +121,7 @@ export default class IssueHeader extends React.PureComponent<Props, State> { render() { const { issue, - ruleDetails: { key, name }, + ruleDetails: { key, name, isExternal }, branchLike, } = this.props; const { issuePopupName } = this.state; @@ -128,7 +129,7 @@ export default class IssueHeader extends React.PureComponent<Props, State> { ...getBranchLikeQuery(branchLike), issues: issue.key, open: issue.key, - types: issue.type === 'SECURITY_HOTSPOT' ? issue.type : undefined, + types: issue.type === IssueType.SecurityHotspot ? issue.type : undefined, }); const ruleStatus = issue.ruleStatus as RuleStatus | undefined; const { quickFixAvailable } = issue; @@ -164,9 +165,13 @@ export default class IssueHeader extends React.PureComponent<Props, State> { <div className="display-flex-center display-flex-space-between spacer-top big-spacer-bottom"> <div> <span className="note padded-right">{name}</span> - <Link className="small" to={getRuleUrl(key)} target="_blank"> - {key} - </Link> + {isExternal ? ( + <span className="note small">({key})</span> + ) : ( + <Link className="small" to={getRuleUrl(key)} target="_blank"> + {key} + </Link> + )} </div> <div className="issue-meta-list"> <div className="issue-meta"> |