Fix quality flaws

4 files changed, 30 insertions, 7 deletions

diff --git a/sonar-batch/src/main/java/org/sonar/batch/design/TangleIndexDecorator.java b/sonar-batch/src/main/java/org/sonar/batch/design/BaseTangleIndexDecorator.java
index c4c1cc3a241..c550c312bad 100644
--- a/sonar-batch/src/main/java/org/sonar/batch/design/TangleIndexDecorator.java
+++ b/sonar-batch/src/main/java/org/sonar/batch/design/BaseTangleIndexDecorator.java
@@ -32,13 +32,13 @@ import org.sonar.api.resources.Resource;
 import java.util.Arrays;
 import java.util.List;
 
-public abstract class TangleIndexDecorator implements Decorator {
+public class BaseTangleIndexDecorator implements Decorator {
 
-  private Metric tanglesMetric;
-  private Metric edgesWeightMetric;
-  private Metric tangleIndexMetric;
+  private final Metric tanglesMetric;
+  private final Metric edgesWeightMetric;
+  private final Metric tangleIndexMetric;
 
-  protected TangleIndexDecorator(Metric tanglesMetric, Metric edgesWeightMetric, Metric tangleIndexMetric) {
+  protected BaseTangleIndexDecorator(Metric tanglesMetric, Metric edgesWeightMetric, Metric tangleIndexMetric) {
     this.tanglesMetric = tanglesMetric;
     this.edgesWeightMetric = edgesWeightMetric;
     this.tangleIndexMetric = tangleIndexMetric;
diff --git a/sonar-batch/src/main/java/org/sonar/batch/design/DirectoryTangleIndexDecorator.java b/sonar-batch/src/main/java/org/sonar/batch/design/DirectoryTangleIndexDecorator.java
index f242722d25c..8d8b5c580c4 100644
--- a/sonar-batch/src/main/java/org/sonar/batch/design/DirectoryTangleIndexDecorator.java
+++ b/sonar-batch/src/main/java/org/sonar/batch/design/DirectoryTangleIndexDecorator.java
@@ -21,7 +21,7 @@ package org.sonar.batch.design;
 
 import org.sonar.api.measures.CoreMetrics;
 
-public class DirectoryTangleIndexDecorator extends TangleIndexDecorator {
+public class DirectoryTangleIndexDecorator extends BaseTangleIndexDecorator {
 
   public DirectoryTangleIndexDecorator() {
     super(CoreMetrics.DIRECTORY_TANGLES, CoreMetrics.DIRECTORY_EDGES_WEIGHT, CoreMetrics.DIRECTORY_TANGLE_INDEX);
diff --git a/sonar-batch/src/main/java/org/sonar/batch/design/FileTangleIndexDecorator.java b/sonar-batch/src/main/java/org/sonar/batch/design/FileTangleIndexDecorator.java
index 079e3774ebd..b4d46f85e11 100644
--- a/sonar-batch/src/main/java/org/sonar/batch/design/FileTangleIndexDecorator.java
+++ b/sonar-batch/src/main/java/org/sonar/batch/design/FileTangleIndexDecorator.java
@@ -21,7 +21,7 @@ package org.sonar.batch.design;
 
 import org.sonar.api.measures.CoreMetrics;
 
-public class FileTangleIndexDecorator extends TangleIndexDecorator {
+public class FileTangleIndexDecorator extends BaseTangleIndexDecorator {
 
   public FileTangleIndexDecorator() {
     super(CoreMetrics.FILE_TANGLES, CoreMetrics.FILE_EDGES_WEIGHT, CoreMetrics.FILE_TANGLE_INDEX);
diff --git a/sonar-batch/src/main/java/org/sonar/batch/scm/package-info.java b/sonar-batch/src/main/java/org/sonar/batch/scm/package-info.java
new file mode 100644
index 00000000000..efefb8aa9ff
--- /dev/null
+++ b/sonar-batch/src/main/java/org/sonar/batch/scm/package-info.java
@@ -0,0 +1,23 @@
+/*
+ * SonarQube, open source software quality management tool.
+ * Copyright (C) 2008-2014 SonarSource
+ * mailto:contact AT sonarsource DOT com
+ *
+ * SonarQube is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * SonarQube is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+@ParametersAreNonnullByDefault
+package org.sonar.batch.scm;
+
+import javax.annotation.ParametersAreNonnullByDefault;