diff options
author | Julien HENRY <julien.henry@sonarsource.com> | 2014-02-17 22:29:33 +0100 |
---|---|---|
committer | Julien HENRY <julien.henry@sonarsource.com> | 2014-02-17 22:29:33 +0100 |
commit | dc002a9d9b6d1f228463e7e9c7727fa283af1149 (patch) | |
tree | 239569c08a580d00c598cf79b976ac2b714c1455 /sonar-batch/src | |
parent | 97ca7b19cc480b03ee9ff7d1874796814106d805 (diff) | |
download | sonarqube-dc002a9d9b6d1f228463e7e9c7727fa283af1149.tar.gz sonarqube-dc002a9d9b6d1f228463e7e9c7727fa283af1149.zip |
SONAR-926 Don't fail when no language on the module (for example aggragator module)
Diffstat (limited to 'sonar-batch/src')
-rw-r--r-- | sonar-batch/src/main/java/org/sonar/batch/phases/ProfileLogger.java | 2 | ||||
-rw-r--r-- | sonar-batch/src/test/java/org/sonar/batch/phases/ProfileLoggerTest.java | 12 |
2 files changed, 13 insertions, 1 deletions
diff --git a/sonar-batch/src/main/java/org/sonar/batch/phases/ProfileLogger.java b/sonar-batch/src/main/java/org/sonar/batch/phases/ProfileLogger.java index 5ec98bc7245..ec939d8df28 100644 --- a/sonar-batch/src/main/java/org/sonar/batch/phases/ProfileLogger.java +++ b/sonar-batch/src/main/java/org/sonar/batch/phases/ProfileLogger.java @@ -60,7 +60,7 @@ public class ProfileLogger implements BatchComponent { defaultNameUsed = true; } } - if (!defaultNameUsed) { + if (!defaultNameUsed && !languages.languages().isEmpty()) { throw new SonarException("sonar.profile was set to '" + defaultName + "' but didn't match any profile for any language. Please check your configuration."); } } diff --git a/sonar-batch/src/test/java/org/sonar/batch/phases/ProfileLoggerTest.java b/sonar-batch/src/test/java/org/sonar/batch/phases/ProfileLoggerTest.java index eb2d4689c44..22ec32b6e22 100644 --- a/sonar-batch/src/test/java/org/sonar/batch/phases/ProfileLoggerTest.java +++ b/sonar-batch/src/test/java/org/sonar/batch/phases/ProfileLoggerTest.java @@ -33,6 +33,7 @@ import org.sonar.api.utils.SonarException; import org.sonar.batch.rule.ModuleQProfiles; import org.sonar.batch.rule.ModuleQProfiles.QProfile; +import java.util.Collections; import java.util.List; import static org.mockito.Mockito.mock; @@ -104,6 +105,17 @@ public class ProfileLoggerTest { } @Test + public void should_not_fail_if_no_language_on_project() { + settings.setProperty("sonar.profile", "Unknow"); + when(languages.languages()).thenReturn(Collections.<Language>emptyList()); + + ProfileLogger profileLogger = new ProfileLogger(settings, languages, profiles); + + profileLogger.execute(); + + } + + @Test public void should_not_fail_if_default_profile_used_at_least_once() { settings.setProperty("sonar.profile", "My Java profile"); |