summaryrefslogtreecommitdiffstats
path: root/sonar-core
diff options
context:
space:
mode:
authorJulien Lancelot <julien.lancelot@gmail.com>2013-09-20 07:55:48 +0200
committerJulien Lancelot <julien.lancelot@gmail.com>2013-09-20 07:55:48 +0200
commit0969171e8fffb08af06a32a1226d3eff02d336db (patch)
treecdd861443259fb8b941fc380aa40f8ff54d08238 /sonar-core
parent0e241f527c97b2aa34bf5838f5bb7d476aa1c09b (diff)
downloadsonarqube-0969171e8fffb08af06a32a1226d3eff02d336db.tar.gz
sonarqube-0969171e8fffb08af06a32a1226d3eff02d336db.zip
Fix quality flaws
Diffstat (limited to 'sonar-core')
-rw-r--r--sonar-core/src/main/java/org/sonar/core/permission/PermissionFacade.java4
-rw-r--r--sonar-core/src/main/java/org/sonar/core/user/GroupRoleDto.java3
2 files changed, 4 insertions, 3 deletions
diff --git a/sonar-core/src/main/java/org/sonar/core/permission/PermissionFacade.java b/sonar-core/src/main/java/org/sonar/core/permission/PermissionFacade.java
index 054970f9c42..44306841b8c 100644
--- a/sonar-core/src/main/java/org/sonar/core/permission/PermissionFacade.java
+++ b/sonar-core/src/main/java/org/sonar/core/permission/PermissionFacade.java
@@ -100,7 +100,7 @@ public class PermissionFacade implements TaskComponent, ServerComponent {
insertGroupPermission(resourceId, groupId, permission, null);
}
- public void insertGroupPermission(@Nullable Long resourceId, @Nullable String groupName, String permission, @Nullable SqlSession session) {
+ public void insertGroupPermission(@Nullable Long resourceId, String groupName, String permission, @Nullable SqlSession session) {
if (DefaultGroups.isAnyone(groupName)) {
insertGroupPermission(resourceId, (Long) null, permission, session);
} else {
@@ -127,7 +127,7 @@ public class PermissionFacade implements TaskComponent, ServerComponent {
deleteGroupPermission(resourceId, groupId, permission, null);
}
- public void deleteGroupPermission(@Nullable Long resourceId, @Nullable String groupName, String permission, @Nullable SqlSession session) {
+ public void deleteGroupPermission(@Nullable Long resourceId, String groupName, String permission, @Nullable SqlSession session) {
if (DefaultGroups.isAnyone(groupName)) {
deleteGroupPermission(resourceId, (Long) null, permission, session);
} else {
diff --git a/sonar-core/src/main/java/org/sonar/core/user/GroupRoleDto.java b/sonar-core/src/main/java/org/sonar/core/user/GroupRoleDto.java
index 669acafaeeb..9a683f6d8c3 100644
--- a/sonar-core/src/main/java/org/sonar/core/user/GroupRoleDto.java
+++ b/sonar-core/src/main/java/org/sonar/core/user/GroupRoleDto.java
@@ -51,11 +51,12 @@ public class GroupRoleDto {
return this;
}
+ @Nullable
public Long getResourceId() {
return resourceId;
}
- public GroupRoleDto setResourceId(Long resourceId) {
+ public GroupRoleDto setResourceId(@Nullable Long resourceId) {
this.resourceId = resourceId;
return this;
}