SONAR-7031 fix Logger.warn(String, Throwable) not logging exception

3 files changed, 14 insertions, 1 deletions

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/utils/log/BaseLogger.java b/sonar-plugin-api/src/main/java/org/sonar/api/utils/log/BaseLogger.java
index 3c19cc5c673..3bb30155d9b 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/utils/log/BaseLogger.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/utils/log/BaseLogger.java
@@ -103,7 +103,7 @@ abstract class BaseLogger implements Logger {
   @Override
   public void warn(String msg, Throwable throwable) {
     LogInterceptors.get().log(LoggerLevel.WARN, msg, throwable);
-    doWarn(msg);
+    doWarn(msg, throwable);
   }
 
   @Override
@@ -180,6 +180,8 @@ abstract class BaseLogger implements Logger {
 
   abstract void doWarn(String msg);
 
+  abstract void doWarn(String msg, Throwable thrown);
+
   abstract void doWarn(String msg, @Nullable Object arg);
 
   abstract void doWarn(String msg, @Nullable Object arg1, @Nullable Object arg2);
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/utils/log/ConsoleLogger.java b/sonar-plugin-api/src/main/java/org/sonar/api/utils/log/ConsoleLogger.java
index d58401ed2fc..672e26f3ac9 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/utils/log/ConsoleLogger.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/utils/log/ConsoleLogger.java
@@ -135,6 +135,12 @@ class ConsoleLogger extends BaseLogger {
   }
 
   @Override
+  void doWarn(String msg, Throwable thrown) {
+    doWarn(msg);
+    thrown.printStackTrace();
+  }
+
+  @Override
   protected void doWarn(String pattern, @Nullable Object arg) {
     warn(format(pattern, arg));
   }
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/utils/log/LogbackLogger.java b/sonar-plugin-api/src/main/java/org/sonar/api/utils/log/LogbackLogger.java
index 8675a94c5e1..1f2516de343 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/utils/log/LogbackLogger.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/utils/log/LogbackLogger.java
@@ -111,6 +111,11 @@ class LogbackLogger extends BaseLogger {
   }
 
   @Override
+  void doWarn(String msg, Throwable thrown) {
+    logback.warn(msg, thrown);
+  }
+
+  @Override
   protected void doWarn(String msg, @Nullable Object arg) {
     logback.warn(msg, arg);
   }