Improve test coverage

1 files changed, 59 insertions, 3 deletions

diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/web/FilterTest.java b/sonar-plugin-api/src/test/java/org/sonar/api/web/FilterTest.java
index e29f4d23393..602e5c99b54 100644
--- a/sonar-plugin-api/src/test/java/org/sonar/api/web/FilterTest.java
+++ b/sonar-plugin-api/src/test/java/org/sonar/api/web/FilterTest.java
@@ -19,17 +19,51 @@
  */
 package org.sonar.api.web;
 
-import org.junit.rules.ExpectedException;
-
 import org.junit.Rule;
-
 import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
+import static org.fest.assertions.Assertions.assertThat;
 
 public class FilterTest {
   @Rule
   public ExpectedException exception = ExpectedException.none();
 
   @Test
+  public void should_create_filter() {
+    Filter filter = Filter.create()
+        .setDisplayAs("list")
+        .setFavouritesOnly(true)
+        .setPageSize(100);
+
+    assertThat(filter.getDisplayAs()).isEqualTo("list");
+    assertThat(filter.isFavouritesOnly()).isTrue();
+    assertThat(filter.getPageSize()).isEqualTo(100);
+  }
+
+  @Test
+  public void should_add_criteria() {
+    Criterion criterion1 = Criterion.createForQualifier("A");
+    Criterion criterion2 = Criterion.createForQualifier("A");
+    Filter filter = Filter.create()
+        .add(criterion1)
+        .add(criterion2);
+
+    assertThat(filter.getCriteria()).containsExactly(criterion1, criterion2);
+  }
+
+  @Test
+  public void should_add_columns() {
+    FilterColumn column1 = FilterColumn.create("", "", "ASC", false);
+    FilterColumn column2 = FilterColumn.create("", "", "DESC", false);
+    Filter filter = Filter.create()
+        .add(column1)
+        .add(column2);
+
+    assertThat(filter.getColumns()).containsExactly(column1, column2);
+  }
+
+  @Test
   public void should_accept_valid_periods() {
     Filter.create().setDisplayAs("list");
     Filter.create().setDisplayAs("treemap");
@@ -42,4 +76,26 @@ public class FilterTest {
 
     Filter.create().setDisplayAs("<invalid>");
   }
+
+  @Test
+  public void should_accept_valid_pageSize() {
+    Filter.create().setPageSize(20);
+    Filter.create().setPageSize(200);
+  }
+
+  @Test
+  public void should_fail_on_pageSize_too_small() {
+    exception.expect(IllegalArgumentException.class);
+    exception.expectMessage("page size should be between 20 and 200");
+
+    Filter.create().setPageSize(19);
+  }
+
+  @Test
+  public void should_fail_on_pageSize_too_high() {
+    exception.expect(IllegalArgumentException.class);
+    exception.expectMessage("page size should be between 20 and 200");
+
+    Filter.create().setPageSize(201);
+  }
 }