SONAR-5056 When update rule, if sub characteristic or remediation function is different from default values, update both overridden values

2 files changed, 14 insertions, 1 deletions

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/server/debt/internal/DefaultDebtRemediationFunction.java b/sonar-plugin-api/src/main/java/org/sonar/api/server/debt/internal/DefaultDebtRemediationFunction.java
index f0cbd4e0638..cc8d58b2002 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/server/debt/internal/DefaultDebtRemediationFunction.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/server/debt/internal/DefaultDebtRemediationFunction.java
@@ -37,7 +37,10 @@ public class DefaultDebtRemediationFunction implements DebtRemediationFunction {
   private final String coefficient;
   private final String offset;
 
-  public DefaultDebtRemediationFunction(Type type, @Nullable String coefficient, @Nullable String offset) {
+  public DefaultDebtRemediationFunction(@Nullable Type type, @Nullable String coefficient, @Nullable String offset) {
+    if (type == null) {
+      throw new IllegalArgumentException("Remediation function type cannot be null");
+    }
     this.type = type;
     this.coefficient = sanitizeValue("coefficient", coefficient);
     this.offset = sanitizeValue("offset", offset);
diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/server/debt/DefaultDebtRemediationFunctionTest.java b/sonar-plugin-api/src/test/java/org/sonar/api/server/debt/DefaultDebtRemediationFunctionTest.java
index 8bdefe18651..b165c6b1556 100644
--- a/sonar-plugin-api/src/test/java/org/sonar/api/server/debt/DefaultDebtRemediationFunctionTest.java
+++ b/sonar-plugin-api/src/test/java/org/sonar/api/server/debt/DefaultDebtRemediationFunctionTest.java
@@ -61,6 +61,16 @@ public class DefaultDebtRemediationFunctionTest {
   }
 
   @Test
+  public void fail_to_when_no_type() {
+    try {
+      new DefaultDebtRemediationFunction(null, "5min", "10h");
+      fail();
+    } catch (IllegalArgumentException e) {
+      assertThat(e).hasMessage("Remediation function type cannot be null");
+    }
+  }
+
+  @Test
   public void fail_to_create_linear_when_no_coefficient() {
     try {
       new DefaultDebtRemediationFunction(DebtRemediationFunction.Type.LINEAR, null, "10h");