SONAR-21195 Enhance scanner engine to download only required plugins

1 files changed, 29 insertions, 255 deletions

diff --git a/sonar-scanner-engine/src/main/java/org/sonar/scanner/scan/SpringProjectScanContainer.java b/sonar-scanner-engine/src/main/java/org/sonar/scanner/scan/SpringProjectScanContainer.java
index cbd5f3faeaa..28a55fdaf98 100644
--- a/sonar-scanner-engine/src/main/java/org/sonar/scanner/scan/SpringProjectScanContainer.java
+++ b/sonar-scanner-engine/src/main/java/org/sonar/scanner/scan/SpringProjectScanContainer.java
@@ -19,124 +19,41 @@
  */
 package org.sonar.scanner.scan;
 
-import javax.annotation.Nullable;
+import java.util.Collection;
+import java.util.Set;
 import javax.annotation.Priority;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
+import org.sonar.api.Plugin;
 import org.sonar.api.batch.fs.internal.DefaultInputModule;
-import org.sonar.api.batch.fs.internal.FileMetadata;
-import org.sonar.api.batch.fs.internal.SensorStrategy;
-import org.sonar.api.batch.rule.CheckFactory;
-import org.sonar.api.batch.sensor.issue.internal.DefaultNoSonarFilter;
+import org.sonar.api.measures.Metrics;
+import org.sonar.api.resources.Languages;
 import org.sonar.api.resources.ResourceTypes;
-import org.sonar.api.scan.filesystem.PathResolver;
-import org.sonar.api.utils.MessageException;
 import org.sonar.core.config.ScannerProperties;
-import org.sonar.core.extension.CoreExtensionsInstaller;
 import org.sonar.core.language.LanguagesProvider;
 import org.sonar.core.metric.ScannerMetrics;
+import org.sonar.core.platform.PluginInfo;
 import org.sonar.core.platform.SpringComponentContainer;
-import org.sonar.scanner.DefaultFileLinesContextFactory;
-import org.sonar.scanner.ProjectInfo;
-import org.sonar.scanner.analysis.AnalysisTempFolderProvider;
 import org.sonar.scanner.bootstrap.ExtensionInstaller;
 import org.sonar.scanner.bootstrap.ExtensionMatcher;
 import org.sonar.scanner.bootstrap.GlobalAnalysisMode;
 import org.sonar.scanner.bootstrap.PostJobExtensionDictionary;
-import org.sonar.scanner.cache.AnalysisCacheEnabled;
-import org.sonar.scanner.cache.AnalysisCacheMemoryStorage;
-import org.sonar.scanner.cache.AnalysisCacheProvider;
-import org.sonar.scanner.cache.DefaultAnalysisCacheLoader;
-import org.sonar.scanner.ci.CiConfigurationProvider;
-import org.sonar.scanner.ci.vendors.AppVeyor;
-import org.sonar.scanner.ci.vendors.AwsCodeBuild;
-import org.sonar.scanner.ci.vendors.AzureDevops;
-import org.sonar.scanner.ci.vendors.Bamboo;
-import org.sonar.scanner.ci.vendors.BitbucketPipelines;
-import org.sonar.scanner.ci.vendors.Bitrise;
-import org.sonar.scanner.ci.vendors.Buildkite;
-import org.sonar.scanner.ci.vendors.CircleCi;
-import org.sonar.scanner.ci.vendors.CirrusCi;
-import org.sonar.scanner.ci.vendors.CodeMagic;
-import org.sonar.scanner.ci.vendors.DroneCi;
-import org.sonar.scanner.ci.vendors.GithubActions;
-import org.sonar.scanner.ci.vendors.GitlabCi;
-import org.sonar.scanner.ci.vendors.Jenkins;
-import org.sonar.scanner.ci.vendors.SemaphoreCi;
-import org.sonar.scanner.ci.vendors.TravisCi;
+import org.sonar.scanner.bootstrap.ScannerPluginRepository;
 import org.sonar.scanner.cpd.CpdExecutor;
-import org.sonar.scanner.cpd.CpdSettings;
-import org.sonar.scanner.cpd.index.SonarCpdBlockIndex;
 import org.sonar.scanner.fs.InputModuleHierarchy;
-import org.sonar.scanner.issue.IssueFilters;
-import org.sonar.scanner.issue.IssuePublisher;
-import org.sonar.scanner.issue.ignore.EnforceIssuesFilter;
-import org.sonar.scanner.issue.ignore.IgnoreIssuesFilter;
-import org.sonar.scanner.issue.ignore.pattern.IssueExclusionPatternInitializer;
-import org.sonar.scanner.issue.ignore.pattern.IssueInclusionPatternInitializer;
-import org.sonar.scanner.issue.ignore.scanner.IssueExclusionsLoader;
 import org.sonar.scanner.mediumtest.AnalysisObservers;
 import org.sonar.scanner.postjob.DefaultPostJobContext;
 import org.sonar.scanner.postjob.PostJobOptimizer;
 import org.sonar.scanner.postjob.PostJobsExecutor;
 import org.sonar.scanner.qualitygate.QualityGateCheck;
-import org.sonar.scanner.report.ActiveRulesPublisher;
-import org.sonar.scanner.report.AnalysisCachePublisher;
-import org.sonar.scanner.report.AnalysisContextReportPublisher;
-import org.sonar.scanner.report.AnalysisWarningsPublisher;
-import org.sonar.scanner.report.CeTaskReportDataHolder;
-import org.sonar.scanner.report.ChangedLinesPublisher;
-import org.sonar.scanner.report.ComponentsPublisher;
-import org.sonar.scanner.report.ContextPropertiesPublisher;
-import org.sonar.scanner.report.JavaArchitectureInformationProvider;
-import org.sonar.scanner.report.MetadataPublisher;
 import org.sonar.scanner.report.ReportPublisher;
-import org.sonar.scanner.report.ScannerFileStructureProvider;
-import org.sonar.scanner.report.SourcePublisher;
-import org.sonar.scanner.report.TestExecutionPublisher;
-import org.sonar.scanner.repository.ContextPropertiesCache;
-import org.sonar.scanner.repository.DefaultProjectRepositoriesLoader;
-import org.sonar.scanner.repository.DefaultQualityProfileLoader;
-import org.sonar.scanner.repository.ProjectRepositoriesProvider;
-import org.sonar.scanner.repository.QualityProfilesProvider;
-import org.sonar.scanner.repository.ReferenceBranchSupplier;
-import org.sonar.scanner.repository.language.DefaultLanguagesRepository;
-import org.sonar.scanner.repository.settings.DefaultProjectSettingsLoader;
-import org.sonar.scanner.rule.ActiveRulesProvider;
-import org.sonar.scanner.rule.DefaultActiveRulesLoader;
 import org.sonar.scanner.rule.QProfileVerifier;
-import org.sonar.scanner.scan.branch.BranchConfiguration;
-import org.sonar.scanner.scan.branch.BranchConfigurationProvider;
-import org.sonar.scanner.scan.branch.BranchType;
-import org.sonar.scanner.scan.branch.ProjectBranchesProvider;
-import org.sonar.scanner.scan.filesystem.DefaultProjectFileSystem;
-import org.sonar.scanner.scan.filesystem.FileIndexer;
 import org.sonar.scanner.scan.filesystem.InputComponentStore;
-import org.sonar.scanner.scan.filesystem.LanguageDetection;
-import org.sonar.scanner.scan.filesystem.MetadataGenerator;
-import org.sonar.scanner.scan.filesystem.ProjectCoverageAndDuplicationExclusions;
-import org.sonar.scanner.scan.filesystem.ProjectExclusionFilters;
-import org.sonar.scanner.scan.filesystem.ProjectFileIndexer;
-import org.sonar.scanner.scan.filesystem.ScannerComponentIdGenerator;
-import org.sonar.scanner.scan.filesystem.StatusDetection;
-import org.sonar.scanner.scan.measure.DefaultMetricFinder;
-import org.sonar.scanner.scm.ScmChangedFilesProvider;
-import org.sonar.scanner.scm.ScmConfiguration;
 import org.sonar.scanner.scm.ScmPublisher;
-import org.sonar.scanner.scm.ScmRevisionImpl;
-import org.sonar.scanner.sensor.DefaultSensorStorage;
-import org.sonar.scanner.sensor.ExecutingSensorContext;
-import org.sonar.scanner.sensor.ProjectSensorContext;
 import org.sonar.scanner.sensor.ProjectSensorExtensionDictionary;
-import org.sonar.scanner.sensor.ProjectSensorOptimizer;
 import org.sonar.scanner.sensor.ProjectSensorsExecutor;
-import org.sonar.scanner.sensor.UnchangedFilesHandler;
-import org.sonar.scm.git.GitScmSupport;
-import org.sonar.scm.svn.SvnScmSupport;
 
 import static org.sonar.api.batch.InstantiationStrategy.PER_BATCH;
-import static org.sonar.api.utils.Preconditions.checkNotNull;
-import static org.sonar.core.extension.CoreExtensionsInstaller.noExtensionFilter;
 import static org.sonar.scanner.bootstrap.ExtensionUtils.isDeprecatedScannerSide;
 import static org.sonar.scanner.bootstrap.ExtensionUtils.isInstantiationStrategy;
 import static org.sonar.scanner.bootstrap.ExtensionUtils.isScannerSide;
@@ -145,182 +62,56 @@ import static org.sonar.scanner.bootstrap.ExtensionUtils.isScannerSide;
 public class SpringProjectScanContainer extends SpringComponentContainer {
   private static final Logger LOG = LoggerFactory.getLogger(SpringProjectScanContainer.class);
 
-  public SpringProjectScanContainer(SpringComponentContainer globalContainer) {
-    super(globalContainer);
+  public SpringProjectScanContainer(SpringComponentContainer parentContainer) {
+    super(parentContainer);
   }
 
   @Override
   protected void doBeforeStart() {
-    addScannerExtensions();
+    Set<String> languages = getParentComponentByType(InputComponentStore.class).languages();
+    installPluginsForLanguages(languages);
     addScannerComponents();
   }
 
+  private void installPluginsForLanguages(Set<String> languageKeys) {
+    ScannerPluginRepository pluginRepository = getParentComponentByType(ScannerPluginRepository.class);
+    Collection<PluginInfo> languagePlugins = pluginRepository.installPluginsForLanguages(languageKeys);
+    for (PluginInfo pluginInfo : languagePlugins) {
+      Plugin instance = pluginRepository.getPluginInstance(pluginInfo.getKey());
+      addExtension(pluginInfo, instance);
+    }
+    getParentComponentByType(ExtensionInstaller.class)
+      .installExtensionsForPlugins(this, getScannerProjectExtensionsFilter(), languagePlugins);
+  }
+
   private void addScannerComponents() {
     add(
-      ScanProperties.class,
-      ProjectReactorBuilder.class,
-      WorkDirectoriesInitializer.class,
-      new MutableProjectReactorProvider(),
-      ProjectBuildersExecutor.class,
-      ProjectLock.class,
-      ResourceTypes.class,
-      ProjectReactorValidator.class,
-      ProjectInfo.class,
-      new BranchConfigurationProvider(),
-      new ProjectBranchesProvider(),
-      ProjectRepositoriesProvider.class,
-      new ProjectServerSettingsProvider(),
-      AnalysisCacheEnabled.class,
-      DeprecatedPropertiesWarningGenerator.class,
-
-      // temp
-      new AnalysisTempFolderProvider(),
-
-      // file system
-      ModuleIndexer.class,
-      InputComponentStore.class,
-      PathResolver.class,
-      new InputProjectProvider(),
-      new InputModuleHierarchyProvider(),
-      ScannerComponentIdGenerator.class,
-      new ScmChangedFilesProvider(),
-      StatusDetection.class,
-      LanguageDetection.class,
-      MetadataGenerator.class,
-      FileMetadata.class,
-      FileIndexer.class,
-      ProjectFileIndexer.class,
-      ProjectExclusionFilters.class,
-
-      // rules
-      new ActiveRulesProvider(),
-      new QualityProfilesProvider(),
-      CheckFactory.class,
-      QProfileVerifier.class,
 
-      // issues
-      DefaultNoSonarFilter.class,
-      IssueFilters.class,
-      IssuePublisher.class,
-
-      // metrics
-      DefaultMetricFinder.class,
+      ResourceTypes.class,
 
       // lang
       LanguagesProvider.class,
-      DefaultLanguagesRepository.class,
 
-      // issue exclusions
-      IssueInclusionPatternInitializer.class,
-      IssueExclusionPatternInitializer.class,
-      IssueExclusionsLoader.class,
-      EnforceIssuesFilter.class,
-      IgnoreIssuesFilter.class,
-
-      // context
-      ContextPropertiesCache.class,
-      ContextPropertiesPublisher.class,
+      // rules
+      QProfileVerifier.class,
 
-      SensorStrategy.class,
 
-      MutableProjectSettings.class,
       ScannerProperties.class,
-      SonarGlobalPropertiesFilter.class,
-      ProjectConfigurationProvider.class,
-
-      ProjectCoverageAndDuplicationExclusions.class,
-
-      // Plugin cache
-      AnalysisCacheProvider.class,
-      AnalysisCacheMemoryStorage.class,
-      DefaultAnalysisCacheLoader.class,
-
-      // Report
-      ReferenceBranchSupplier.class,
-      ScannerMetrics.class,
-      JavaArchitectureInformationProvider.class,
-      ReportPublisher.class,
-      ScannerFileStructureProvider.class,
-      AnalysisContextReportPublisher.class,
-      MetadataPublisher.class,
-      ActiveRulesPublisher.class,
-      ComponentsPublisher.class,
-      AnalysisCachePublisher.class,
-      TestExecutionPublisher.class,
-      SourcePublisher.class,
-      ChangedLinesPublisher.class,
-      AnalysisWarningsPublisher.class,
-
-      CeTaskReportDataHolder.class,
 
       // QualityGate check
       QualityGateCheck.class,
 
-      // Cpd
-      CpdExecutor.class,
-      CpdSettings.class,
-      SonarCpdBlockIndex.class,
-
       // PostJobs
       PostJobsExecutor.class,
       PostJobOptimizer.class,
       DefaultPostJobContext.class,
       PostJobExtensionDictionary.class,
 
-      // SCM
-      ScmConfiguration.class,
-      ScmPublisher.class,
-      ScmRevisionImpl.class,
-
       // Sensors
-      DefaultSensorStorage.class,
-      DefaultFileLinesContextFactory.class,
-      ProjectSensorContext.class,
-      ProjectSensorOptimizer.class,
-      ProjectSensorsExecutor.class,
-      ExecutingSensorContext.class,
       ProjectSensorExtensionDictionary.class,
-      UnchangedFilesHandler.class,
-
-      // Filesystem
-      DefaultProjectFileSystem.class,
-
-      // CI
-      new CiConfigurationProvider(),
-      AppVeyor.class,
-      AwsCodeBuild.class,
-      AzureDevops.class,
-      Bamboo.class,
-      BitbucketPipelines.class,
-      Bitrise.class,
-      Buildkite.class,
-      CircleCi.class,
-      CirrusCi.class,
-      DroneCi.class,
-      GithubActions.class,
-      CodeMagic.class,
-      GitlabCi.class,
-      Jenkins.class,
-      SemaphoreCi.class,
-      TravisCi.class,
+      ProjectSensorsExecutor.class,
 
       AnalysisObservers.class);
-
-    add(GitScmSupport.getObjects());
-    add(SvnScmSupport.getObjects());
-
-    add(DefaultProjectSettingsLoader.class,
-      DefaultActiveRulesLoader.class,
-      DefaultQualityProfileLoader.class,
-      DefaultProjectRepositoriesLoader.class);
-  }
-
-  private void addScannerExtensions() {
-    checkNotNull(getParent());
-    getParent().getComponentByType(CoreExtensionsInstaller.class)
-      .install(this, noExtensionFilter(), extension -> getScannerProjectExtensionsFilter().accept(extension));
-    getParent().getComponentByType(ExtensionInstaller.class)
-      .install(this, getScannerProjectExtensionsFilter());
   }
 
   static ExtensionMatcher getScannerProjectExtensionsFilter() {
@@ -334,29 +125,16 @@ public class SpringProjectScanContainer extends SpringComponentContainer {
 
   @Override
   protected void doAfterStart() {
+    getParentComponentByType(ScannerMetrics.class).addPluginMetrics(getComponentsByType(Metrics.class));
     getComponentByType(ProjectLock.class).tryLock();
     GlobalAnalysisMode analysisMode = getComponentByType(GlobalAnalysisMode.class);
     InputModuleHierarchy tree = getComponentByType(InputModuleHierarchy.class);
     ScanProperties properties = getComponentByType(ScanProperties.class);
-    properties.validate();
-
-    properties.get("sonar.branch").ifPresent(deprecatedBranch -> {
-      throw MessageException.of("The 'sonar.branch' parameter is no longer supported. You should stop using it. " +
-        "Branch analysis is available in Developer Edition and above. See https://www.sonarsource.com/plans-and-pricing/developer/ for more information.");
-    });
 
-    BranchConfiguration branchConfig = getComponentByType(BranchConfiguration.class);
-    if (branchConfig.branchType() == BranchType.PULL_REQUEST) {
-      LOG.info("Pull request {} for merge into {} from {}", branchConfig.pullRequestKey(), pullRequestBaseToDisplayName(branchConfig.targetBranchName()),
-        branchConfig.branchName());
-    } else if (branchConfig.branchName() != null) {
-      LOG.info("Branch name: {}", branchConfig.branchName());
+    if (getComponentByType(Languages.class).all().length == 0) {
+      throw new IllegalStateException("No language plugins are installed.");
     }
 
-    getComponentByType(DeprecatedPropertiesWarningGenerator.class).execute();
-
-    getComponentByType(ProjectFileIndexer.class).index();
-
     // Log detected languages and their profiles after FS is indexed and languages detected
     getComponentByType(QProfileVerifier.class).execute();
 
@@ -382,10 +160,6 @@ public class SpringProjectScanContainer extends SpringComponentContainer {
     }
   }
 
-  private static String pullRequestBaseToDisplayName(@Nullable String pullRequestBase) {
-    return pullRequestBase != null ? pullRequestBase : "default branch";
-  }
-
   private void scanRecursively(InputModuleHierarchy tree, DefaultInputModule module) {
     for (DefaultInputModule child : tree.children(module)) {
       scanRecursively(tree, child);