1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
|
/*
* SonarQube
* Copyright (C) 2009-2025 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
package org.sonar.auth.gitlab;
import org.junit.Before;
import org.junit.Test;
import org.sonar.api.config.PropertyDefinitions;
import org.sonar.api.config.internal.MapSettings;
import org.sonar.api.utils.System2;
import static org.assertj.core.api.Assertions.assertThat;
import static org.sonar.auth.gitlab.GitLabSettings.GITLAB_AUTH_ALLOWED_GROUPS;
import static org.sonar.auth.gitlab.GitLabSettings.GITLAB_AUTH_ALLOW_USERS_TO_SIGNUP;
import static org.sonar.auth.gitlab.GitLabSettings.GITLAB_AUTH_APPLICATION_ID;
import static org.sonar.auth.gitlab.GitLabSettings.GITLAB_AUTH_ENABLED;
import static org.sonar.auth.gitlab.GitLabSettings.GITLAB_AUTH_PROVISIONING_ENABLED;
import static org.sonar.auth.gitlab.GitLabSettings.GITLAB_AUTH_PROVISIONING_TOKEN;
import static org.sonar.auth.gitlab.GitLabSettings.GITLAB_AUTH_SECRET;
import static org.sonar.auth.gitlab.GitLabSettings.GITLAB_AUTH_SYNC_USER_GROUPS;
import static org.sonar.auth.gitlab.GitLabSettings.GITLAB_AUTH_URL;
import static org.sonar.auth.gitlab.GitLabSettings.GITLAB_USER_CONSENT_FOR_PERMISSION_PROVISIONING_REQUIRED;
import static org.sonar.db.ce.CeTaskTypes.GITLAB_PROJECT_PERMISSIONS_PROVISIONING;
public class GitLabSettingsTest {
private MapSettings settings;
private GitLabSettings config;
@Before
public void prepare() {
settings = new MapSettings(new PropertyDefinitions(System2.INSTANCE, GitLabSettings.definitions()));
config = new GitLabSettings(settings.asConfig());
}
@Test
public void test_settings() {
assertThat(config.url()).isEqualTo("https://gitlab.com");
assertThat(config.apiUrl()).isEqualTo("https://gitlab.com/api/v4");
settings.setProperty(GITLAB_AUTH_URL, "https://onpremise.gitlab.com/");
assertThat(config.url()).isEqualTo("https://onpremise.gitlab.com");
assertThat(config.apiUrl()).isEqualTo("https://onpremise.gitlab.com/api/v4");
settings.setProperty(GITLAB_AUTH_URL, "https://onpremise.gitlab.com");
assertThat(config.url()).isEqualTo("https://onpremise.gitlab.com");
assertThat(config.apiUrl()).isEqualTo("https://onpremise.gitlab.com/api/v4");
assertThat(config.isEnabled()).isFalse();
settings.setProperty(GITLAB_AUTH_ENABLED, "true");
assertThat(config.isEnabled()).isFalse();
settings.setProperty(GITLAB_AUTH_APPLICATION_ID, "1234");
assertThat(config.isEnabled()).isFalse();
settings.setProperty(GITLAB_AUTH_SECRET, "5678");
assertThat(config.isEnabled()).isTrue();
assertThat(config.applicationId()).isEqualTo("1234");
assertThat(config.secret()).isEqualTo("5678");
assertThat(config.allowUsersToSignUp()).isTrue();
settings.setProperty(GITLAB_AUTH_ALLOW_USERS_TO_SIGNUP, "false");
assertThat(config.allowUsersToSignUp()).isFalse();
assertThat(config.syncUserGroups()).isFalse();
settings.setProperty(GITLAB_AUTH_SYNC_USER_GROUPS, true);
assertThat(config.syncUserGroups()).isTrue();
settings.setProperty(GITLAB_AUTH_PROVISIONING_TOKEN, "token");
assertThat(config.provisioningToken()).isEqualTo("token");
settings.setProperty(GITLAB_AUTH_ALLOWED_GROUPS, new String[] {"Group1", "Group2"});
assertThat(config.allowedGroups()).containsExactlyInAnyOrder("Group1", "Group2");
assertThat(config.isProvisioningEnabled()).isFalse();
settings.setProperty(GITLAB_AUTH_PROVISIONING_ENABLED, true);
assertThat(config.isProvisioningEnabled()).isTrue();
}
@Test
public void isProvisioningEnabled_whenNotSet_returnsFalse() {
enableGitlabAuthentication();
assertThat(config.isProvisioningEnabled()).isFalse();
}
@Test
public void isProvisioningEnabled_ifProvisioningDisabled_returnsFalse() {
enableGitlabAuthentication();
settings.setProperty(GITLAB_AUTH_PROVISIONING_ENABLED, false);
assertThat(config.isProvisioningEnabled()).isFalse();
}
@Test
public void isProvisioningEnabled_ifProvisioningEnabledButGithubAuthDisabled_returnsFalse() {
settings.setProperty(GITLAB_AUTH_PROVISIONING_ENABLED, true);
assertThat(config.isProvisioningEnabled()).isFalse();
}
@Test
public void isProvisioningEnabled_ifProvisioningEnabledAndGithubAuthEnabled_returnsTrue() {
enableGitlabAuthentication();
settings.setProperty(GITLAB_AUTH_PROVISIONING_ENABLED, true);
assertThat(config.isProvisioningEnabled()).isTrue();
}
@Test
public void isProjectVisibilitySynchronizationActivated_alwaysReturnsTrue() {
assertThat(config.isProjectVisibilitySynchronizationActivated()).isTrue();
}
@Test
public void isUserConsentRequiredForPermissionProvisioning_returnsFalseByDefault() {
assertThat(config.isUserConsentRequiredAfterUpgrade()).isFalse();
}
@Test
public void isUserConsentRequiredForPermissionProvisioning_returnsTrueWhenPropertyPresent() {
settings.setProperty(GITLAB_USER_CONSENT_FOR_PERMISSION_PROVISIONING_REQUIRED, "");
assertThat(config.isUserConsentRequiredAfterUpgrade()).isTrue();
}
@Test
public void getProjectsPermissionsProvisioningTaskName_returnsCorrectTaskName() {
assertThat(config.getProjectsPermissionsProvisioningTaskName()).isEqualTo(GITLAB_PROJECT_PERMISSIONS_PROVISIONING);
}
private void enableGitlabAuthentication() {
settings.setProperty(GITLAB_AUTH_ENABLED, true);
settings.setProperty(GITLAB_AUTH_APPLICATION_ID, "on");
settings.setProperty(GITLAB_AUTH_SECRET, "on");
}
}
|
