1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
|
/*
* SonarQube
* Copyright (C) 2009-2025 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
package org.sonar.db.property;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableSet;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Optional;
import java.util.Random;
import java.util.Set;
import java.util.stream.Collectors;
import java.util.stream.IntStream;
import java.util.stream.Stream;
import javax.annotation.CheckForNull;
import javax.annotation.Nullable;
import org.assertj.core.api.AbstractAssert;
import org.assertj.core.api.ThrowableAssert.ThrowingCallable;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;
import org.mockito.ArgumentCaptor;
import org.mockito.Mockito;
import org.sonar.api.utils.System2;
import org.sonar.db.DbSession;
import org.sonar.db.DbTester;
import org.sonar.db.audit.AuditPersister;
import org.sonar.db.audit.model.PropertyNewValue;
import static java.lang.Boolean.FALSE;
import static java.lang.Boolean.TRUE;
import static org.apache.commons.lang3.RandomStringUtils.secure;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.assertj.core.api.Assertions.entry;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyLong;
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.clearInvocations;
import static org.mockito.Mockito.doThrow;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoInteractions;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.when;
import static org.sonar.db.property.InternalPropertiesDao.LOCK_NAME_MAX_LENGTH;
class InternalPropertiesDaoIT {
private static final String EMPTY_STRING = "";
private static final String A_KEY = "a_key";
private static final String ANOTHER_KEY = "another_key";
private static final long DATE_1 = 1_500_000_000_000L;
private static final long DATE_2 = 1_600_000_000_000L;
private static final String VALUE_SMALL = "some small value";
private static final String OTHER_VALUE_SMALL = "other small value";
private static final String VALUE_SIZE_4000 = String.format("%1$4000.4000s", "*");
private static final String VALUE_SIZE_4001 = VALUE_SIZE_4000 + "P";
private static final String OTHER_VALUE_SIZE_4001 = VALUE_SIZE_4000 + "D";
private final System2 system2 = mock(System2.class);
private final String DEFAULT_PROJECT_TEMPLATE = "defaultTemplate.prj";
@RegisterExtension
private final DbTester dbTester = DbTester.create(system2);
private final DbSession dbSession = dbTester.getSession();
private final AuditPersister auditPersister = mock(AuditPersister.class);
private final InternalPropertiesDao underTest = new InternalPropertiesDao(system2, auditPersister);
private final ArgumentCaptor<PropertyNewValue> newValueCaptor = ArgumentCaptor.forClass(PropertyNewValue.class);
@BeforeEach
void setUp() {
when(auditPersister.isTrackedProperty(DEFAULT_PROJECT_TEMPLATE)).thenReturn(true);
}
@Test
void save_throws_IAE_if_key_is_null() {
expectKeyNullOrEmptyIAE(() -> underTest.save(dbSession, null, VALUE_SMALL));
}
@Test
void save_throws_IAE_if_key_is_empty() {
expectKeyNullOrEmptyIAE(() -> underTest.save(dbSession, EMPTY_STRING, VALUE_SMALL));
}
@Test
void save_throws_IAE_if_value_is_null() {
expectValueNullOrEmptyIAE(() -> underTest.save(dbSession, A_KEY, null));
}
@Test
void save_throws_IAE_if_value_is_empty() {
expectValueNullOrEmptyIAE(() -> underTest.save(dbSession, A_KEY, EMPTY_STRING));
}
@Test
void save_persists_value_in_varchar_if_less_than_4000() {
when(system2.now()).thenReturn(DATE_2);
underTest.save(dbSession, A_KEY, VALUE_SMALL);
assertThatInternalProperty(A_KEY)
.hasTextValue(VALUE_SMALL)
.hasCreatedAt(DATE_2);
}
@Test
void delete_removes_value() {
underTest.save(dbSession, A_KEY, VALUE_SMALL);
dbSession.commit();
assertThat(dbTester.countRowsOfTable("internal_properties")).isOne();
clearInvocations(auditPersister);
underTest.delete(dbSession, A_KEY);
dbSession.commit();
assertThat(dbTester.countRowsOfTable("internal_properties")).isZero();
verify(auditPersister).isTrackedProperty(A_KEY);
verifyNoMoreInteractions(auditPersister);
}
@Test
void delete_audits_if_value_was_deleted_and_it_is_tracked_key() {
underTest.save(dbSession, DEFAULT_PROJECT_TEMPLATE, VALUE_SMALL);
clearInvocations(auditPersister);
underTest.delete(dbSession, DEFAULT_PROJECT_TEMPLATE);
verify(auditPersister).deleteProperty(any(), newValueCaptor.capture(), eq(false));
assertAuditValue(DEFAULT_PROJECT_TEMPLATE, null);
}
@Test
void delete_audits_does_not_audit_if_nothing_was_deleted() {
underTest.delete(dbSession, DEFAULT_PROJECT_TEMPLATE);
verifyNoInteractions(auditPersister);
}
@Test
void save_audits_if_key_is_tracked() {
underTest.save(dbSession, DEFAULT_PROJECT_TEMPLATE, VALUE_SMALL);
verify(auditPersister).addProperty(any(), newValueCaptor.capture(), eq(false));
assertAuditValue(DEFAULT_PROJECT_TEMPLATE, VALUE_SMALL);
}
@Test
void save_audits_update_if_key_is_tracked_and_updated() {
underTest.save(dbSession, DEFAULT_PROJECT_TEMPLATE, "first value");
Mockito.clearInvocations(auditPersister);
underTest.save(dbSession, DEFAULT_PROJECT_TEMPLATE, VALUE_SMALL);
verify(auditPersister).updateProperty(any(), newValueCaptor.capture(), eq(false));
assertAuditValue(DEFAULT_PROJECT_TEMPLATE, VALUE_SMALL);
}
@Test
void save_persists_value_in_varchar_if_4000() {
when(system2.now()).thenReturn(DATE_1);
underTest.save(dbSession, A_KEY, VALUE_SIZE_4000);
assertThatInternalProperty(A_KEY)
.hasTextValue(VALUE_SIZE_4000)
.hasCreatedAt(DATE_1);
}
@Test
void save_persists_value_in_varchar_if_more_than_4000() {
when(system2.now()).thenReturn(DATE_2);
underTest.save(dbSession, A_KEY, VALUE_SIZE_4001);
assertThatInternalProperty(A_KEY)
.hasClobValue(VALUE_SIZE_4001)
.hasCreatedAt(DATE_2);
}
@Test
void save_persists_new_value_in_varchar_if_4000_when_old_one_was_in_varchar() {
when(system2.now()).thenReturn(DATE_1, DATE_2);
underTest.save(dbSession, A_KEY, VALUE_SMALL);
assertThatInternalProperty(A_KEY)
.hasTextValue(VALUE_SMALL)
.hasCreatedAt(DATE_1);
underTest.save(dbSession, A_KEY, VALUE_SIZE_4000);
assertThatInternalProperty(A_KEY)
.hasTextValue(VALUE_SIZE_4000)
.hasCreatedAt(DATE_2);
}
@Test
void save_persists_new_value_in_clob_if_more_than_4000_when_old_one_was_in_varchar() {
when(system2.now()).thenReturn(DATE_1, DATE_2);
underTest.save(dbSession, A_KEY, VALUE_SMALL);
assertThatInternalProperty(A_KEY)
.hasTextValue(VALUE_SMALL)
.hasCreatedAt(DATE_1);
underTest.save(dbSession, A_KEY, VALUE_SIZE_4001);
assertThatInternalProperty(A_KEY)
.hasClobValue(VALUE_SIZE_4001)
.hasCreatedAt(DATE_2);
}
@Test
void save_persists_new_value_in_varchar_if_less_than_4000_when_old_one_was_in_clob() {
when(system2.now()).thenReturn(DATE_1, DATE_2);
underTest.save(dbSession, A_KEY, VALUE_SIZE_4001);
assertThatInternalProperty(A_KEY)
.hasClobValue(VALUE_SIZE_4001)
.hasCreatedAt(DATE_1);
underTest.save(dbSession, A_KEY, VALUE_SMALL);
assertThatInternalProperty(A_KEY)
.hasTextValue(VALUE_SMALL)
.hasCreatedAt(DATE_2);
}
@Test
void save_persists_new_value_in_clob_if_more_than_4000_when_old_one_was_in_clob() {
when(system2.now()).thenReturn(DATE_1, DATE_2);
String oldValue = VALUE_SIZE_4001 + "blabla";
underTest.save(dbSession, A_KEY, oldValue);
assertThatInternalProperty(A_KEY)
.hasClobValue(oldValue)
.hasCreatedAt(DATE_1);
underTest.save(dbSession, A_KEY, VALUE_SIZE_4001);
assertThatInternalProperty(A_KEY)
.hasClobValue(VALUE_SIZE_4001)
.hasCreatedAt(DATE_2);
}
@Test
void saveAsEmpty_throws_IAE_if_key_is_null() {
expectKeyNullOrEmptyIAE(() -> underTest.saveAsEmpty(dbSession, null));
}
@Test
void saveAsEmpty_throws_IAE_if_key_is_empty() {
expectKeyNullOrEmptyIAE(() -> underTest.saveAsEmpty(dbSession, EMPTY_STRING));
}
@Test
void saveAsEmpty_persist_property_without_textvalue_nor_clob_value() {
when(system2.now()).thenReturn(DATE_2);
underTest.saveAsEmpty(dbSession, A_KEY);
assertThatInternalProperty(A_KEY)
.isEmpty()
.hasCreatedAt(DATE_2);
}
@Test
void saveAsEmpty_audits_if_key_is_tracked() {
underTest.saveAsEmpty(dbSession, DEFAULT_PROJECT_TEMPLATE);
verify(auditPersister).addProperty(any(), newValueCaptor.capture(), eq(false));
assertAuditValue(DEFAULT_PROJECT_TEMPLATE, "");
}
@Test
void saveAsEmpty_audits_update_if_key_is_tracked_and_updated() {
underTest.save(dbSession, DEFAULT_PROJECT_TEMPLATE, "first value");
Mockito.clearInvocations(auditPersister);
underTest.saveAsEmpty(dbSession, DEFAULT_PROJECT_TEMPLATE);
verify(auditPersister).updateProperty(any(), newValueCaptor.capture(), eq(false));
assertAuditValue(DEFAULT_PROJECT_TEMPLATE, "");
}
@Test
void saveAsEmpty_persist_property_without_textvalue_nor_clob_value_when_old_value_was_in_varchar() {
when(system2.now()).thenReturn(DATE_1, DATE_2);
underTest.save(dbSession, A_KEY, VALUE_SMALL);
assertThatInternalProperty(A_KEY)
.hasTextValue(VALUE_SMALL)
.hasCreatedAt(DATE_1);
underTest.saveAsEmpty(dbSession, A_KEY);
assertThatInternalProperty(A_KEY)
.isEmpty()
.hasCreatedAt(DATE_2);
}
@Test
void saveAsEmpty_persist_property_without_textvalue_nor_clob_value_when_old_value_was_in_clob() {
when(system2.now()).thenReturn(DATE_2, DATE_1);
underTest.save(dbSession, A_KEY, VALUE_SIZE_4001);
assertThatInternalProperty(A_KEY)
.hasClobValue(VALUE_SIZE_4001)
.hasCreatedAt(DATE_2);
underTest.saveAsEmpty(dbSession, A_KEY);
assertThatInternalProperty(A_KEY)
.isEmpty()
.hasCreatedAt(DATE_1);
}
@Test
void selectByKey_throws_IAE_when_key_is_null() {
expectKeyNullOrEmptyIAE(() -> underTest.selectByKey(dbSession, null));
}
@Test
void selectByKey_throws_IAE_when_key_is_empty() {
expectKeyNullOrEmptyIAE(() -> underTest.selectByKey(dbSession, EMPTY_STRING));
}
@Test
void selectByKey_returns_empty_optional_when_property_does_not_exist_in_DB() {
assertThat(underTest.selectByKey(dbSession, A_KEY)).isEmpty();
}
@Test
void selectByKey_returns_empty_string_when_property_is_empty_in_DB() {
underTest.saveAsEmpty(dbSession, A_KEY);
assertThat(underTest.selectByKey(dbSession, A_KEY)).contains(EMPTY_STRING);
}
@Test
void selectByKey_returns_value_when_property_has_value_stored_in_varchar() {
underTest.save(dbSession, A_KEY, VALUE_SMALL);
assertThat(underTest.selectByKey(dbSession, A_KEY)).contains(VALUE_SMALL);
}
@Test
void selectByKey_returns_value_when_property_has_value_stored_in_clob() {
underTest.save(dbSession, A_KEY, VALUE_SIZE_4001);
assertThat(underTest.selectByKey(dbSession, A_KEY)).contains(VALUE_SIZE_4001);
}
@Test
void selectByKeys_returns_empty_map_if_keys_is_null() {
assertThat(underTest.selectByKeys(dbSession, null)).isEmpty();
}
@Test
void selectByKeys_returns_empty_map_if_keys_is_empty() {
assertThat(underTest.selectByKeys(dbSession, Collections.emptySet())).isEmpty();
}
@Test
void selectByKeys_throws_IAE_when_keys_contains_null() {
Set<String> keysIncludingANull = Stream.of(
IntStream.range(0, 10).mapToObj(i -> "b_" + i),
Stream.of((String) null),
IntStream.range(0, 10).mapToObj(i -> "a_" + i))
.flatMap(s -> s)
.collect(Collectors.toSet());
expectKeyNullOrEmptyIAE(() -> underTest.selectByKeys(dbSession, keysIncludingANull));
}
@Test
void selectByKeys_throws_IAE_when_keys_contains_empty_string() {
Random random = new Random();
Set<String> keysIncludingAnEmptyString = Stream.of(
IntStream.range(0, random.nextInt(10)).mapToObj(i -> "b_" + i),
Stream.of(""),
IntStream.range(0, random.nextInt(10)).mapToObj(i -> "a_" + i))
.flatMap(s -> s)
.collect(Collectors.toSet());
expectKeyNullOrEmptyIAE(() -> underTest.selectByKeys(dbSession, keysIncludingAnEmptyString));
}
@Test
void selectByKeys_returns_empty_optional_when_property_does_not_exist_in_DB() {
assertThat(underTest.selectByKeys(dbSession, ImmutableSet.of(A_KEY, ANOTHER_KEY)))
.containsOnly(
entry(A_KEY, Optional.empty()),
entry(ANOTHER_KEY, Optional.empty()));
}
@Test
void selectByKeys_returns_empty_string_when_property_is_empty_in_DB() {
underTest.saveAsEmpty(dbSession, A_KEY);
underTest.saveAsEmpty(dbSession, ANOTHER_KEY);
assertThat(underTest.selectByKeys(dbSession, ImmutableSet.of(A_KEY, ANOTHER_KEY)))
.containsOnly(
entry(A_KEY, Optional.of("")),
entry(ANOTHER_KEY, Optional.of("")));
}
@Test
void selectByKeys_returns_value_when_property_has_value_stored_in_varchar() {
underTest.save(dbSession, A_KEY, VALUE_SMALL);
underTest.save(dbSession, ANOTHER_KEY, OTHER_VALUE_SMALL);
assertThat(underTest.selectByKeys(dbSession, ImmutableSet.of(A_KEY, ANOTHER_KEY)))
.containsOnly(
entry(A_KEY, Optional.of(VALUE_SMALL)),
entry(ANOTHER_KEY, Optional.of(OTHER_VALUE_SMALL)));
}
@Test
void selectByKeys_returns_values_when_properties_has_value_stored_in_clob() {
underTest.save(dbSession, A_KEY, VALUE_SIZE_4001);
underTest.save(dbSession, ANOTHER_KEY, OTHER_VALUE_SIZE_4001);
assertThat(underTest.selectByKeys(dbSession, ImmutableSet.of(A_KEY, ANOTHER_KEY)))
.containsOnly(
entry(A_KEY, Optional.of(VALUE_SIZE_4001)),
entry(ANOTHER_KEY, Optional.of(OTHER_VALUE_SIZE_4001)));
}
@Test
void selectByKeys_queries_only_clob_properties_with_clob_SQL_query() {
underTest.saveAsEmpty(dbSession, A_KEY);
underTest.save(dbSession, "key2", VALUE_SMALL);
underTest.save(dbSession, "key3", VALUE_SIZE_4001);
Set<String> keys = ImmutableSet.of(A_KEY, "key2", "key3", "non_existent_key");
List<InternalPropertyDto> allInternalPropertyDtos =
dbSession.getMapper(InternalPropertiesMapper.class).selectAsText(ImmutableList.copyOf(keys));
List<InternalPropertyDto> clobPropertyDtos = dbSession.getMapper(InternalPropertiesMapper.class).selectAsClob(ImmutableList.of("key3"));
InternalPropertiesMapper mapperMock = mock(InternalPropertiesMapper.class);
DbSession dbSessionMock = mock(DbSession.class);
when(dbSessionMock.getMapper(InternalPropertiesMapper.class)).thenReturn(mapperMock);
when(mapperMock.selectAsText(ImmutableList.copyOf(keys)))
.thenReturn(allInternalPropertyDtos);
when(mapperMock.selectAsClob(ImmutableList.of("key3")))
.thenReturn(clobPropertyDtos);
underTest.selectByKeys(dbSessionMock, keys);
verify(mapperMock).selectAsText(ImmutableList.copyOf(keys));
verify(mapperMock).selectAsClob(ImmutableList.of("key3"));
verifyNoMoreInteractions(mapperMock);
}
@Test
void tryLock_succeeds_if_lock_did_not_exist() {
long now = new Random().nextInt();
when(system2.now()).thenReturn(now);
assertThat(underTest.tryLock(dbSession, A_KEY, 60)).isTrue();
assertThat(underTest.selectByKey(dbSession, propertyKeyOf(A_KEY))).contains(String.valueOf(now));
}
@Test
void tryLock_succeeds_if_lock_acquired_before_lease_duration() {
int lockDurationSeconds = 60;
long before = new Random().nextInt();
when(system2.now()).thenReturn(before);
assertThat(underTest.tryLock(dbSession, A_KEY, lockDurationSeconds)).isTrue();
long now = before + lockDurationSeconds * 1000;
when(system2.now()).thenReturn(now);
assertThat(underTest.tryLock(dbSession, A_KEY, lockDurationSeconds)).isTrue();
assertThat(underTest.selectByKey(dbSession, propertyKeyOf(A_KEY))).contains(String.valueOf(now));
}
@Test
void tryLock_fails_if_lock_acquired_within_lease_duration() {
long now = new Random().nextInt();
when(system2.now()).thenReturn(now);
assertThat(underTest.tryLock(dbSession, A_KEY, 60)).isTrue();
assertThat(underTest.tryLock(dbSession, A_KEY, 60)).isFalse();
assertThat(underTest.selectByKey(dbSession, propertyKeyOf(A_KEY))).contains(String.valueOf(now));
}
@Test
void tryLock_fails_if_it_would_insert_concurrently() {
String name = secure().nextAlphabetic(5);
String propertyKey = propertyKeyOf(name);
long now = new Random().nextInt();
when(system2.now()).thenReturn(now);
assertThat(underTest.tryLock(dbSession, name, 60)).isTrue();
InternalPropertiesMapper mapperMock = mock(InternalPropertiesMapper.class);
DbSession dbSessionMock = mock(DbSession.class);
when(dbSessionMock.getMapper(InternalPropertiesMapper.class)).thenReturn(mapperMock);
when(mapperMock.selectAsText(ImmutableList.of(propertyKey)))
.thenReturn(ImmutableList.of());
doThrow(RuntimeException.class).when(mapperMock).insertAsText(eq(propertyKey), anyString(), anyLong());
assertThat(underTest.tryLock(dbSessionMock, name, 60)).isFalse();
assertThat(underTest.selectByKey(dbSession, propertyKey)).contains(String.valueOf(now));
}
@Test
void tryLock_fails_if_concurrent_caller_succeeded_first() {
int lockDurationSeconds = 60;
String name = secure().nextAlphabetic(5);
String propertyKey = propertyKeyOf(name);
long now = new Random().nextInt(4_889_989);
long oldTimestamp = now - lockDurationSeconds * 1000;
when(system2.now()).thenReturn(oldTimestamp);
assertThat(underTest.tryLock(dbSession, name, lockDurationSeconds)).isTrue();
when(system2.now()).thenReturn(now);
InternalPropertiesMapper mapperMock = mock(InternalPropertiesMapper.class);
DbSession dbSessionMock = mock(DbSession.class);
when(dbSessionMock.getMapper(InternalPropertiesMapper.class)).thenReturn(mapperMock);
InternalPropertyDto dto = new InternalPropertyDto();
dto.setKey(propertyKey);
dto.setValue(String.valueOf(oldTimestamp - 1));
when(mapperMock.selectAsText(ImmutableList.of(propertyKey)))
.thenReturn(ImmutableList.of(dto));
assertThat(underTest.tryLock(dbSessionMock, name, lockDurationSeconds)).isFalse();
assertThat(underTest.selectByKey(dbSession, propertyKey)).contains(String.valueOf(oldTimestamp));
}
@Test
void tryLock_throws_IAE_if_lock_name_is_empty() {
assertThatThrownBy(() -> underTest.tryLock(dbSession, "", 60))
.isInstanceOf(IllegalArgumentException.class)
.hasMessage("lock name can't be empty");
}
@Test
void tryLock_throws_IAE_if_lock_name_length_is_too_long() {
String tooLongName = secure().nextAlphabetic(LOCK_NAME_MAX_LENGTH + 1);
assertThatThrownBy(() -> underTest.tryLock(dbSession, tooLongName, 60))
.isInstanceOf(IllegalArgumentException.class)
.hasMessage("lock name is too long");
}
private void assertAuditValue(String key, @Nullable String value) {
verify(auditPersister).isTrackedProperty(key);
PropertyNewValue newValue = newValueCaptor.getValue();
assertThat(newValue)
.extracting(PropertyNewValue::getPropertyKey, PropertyNewValue::getPropertyValue, PropertyNewValue::getUserUuid,
PropertyNewValue::getUserLogin)
.containsExactly(key, value, null, null);
}
private static String propertyKeyOf(String lockName) {
return "lock." + lockName;
}
private void expectKeyNullOrEmptyIAE(ThrowingCallable callback) {
assertThatThrownBy(callback)
.isInstanceOf(IllegalArgumentException.class)
.hasMessage("key can't be null nor empty");
}
private void expectValueNullOrEmptyIAE(ThrowingCallable callback) {
assertThatThrownBy(callback)
.isInstanceOf(IllegalArgumentException.class)
.hasMessage("value can't be null nor empty");
}
private InternalPropertyAssert assertThatInternalProperty(String key) {
return new InternalPropertyAssert(dbTester, dbSession, key);
}
private static class InternalPropertyAssert extends AbstractAssert<InternalPropertyAssert, InternalProperty> {
private InternalPropertyAssert(DbTester dbTester, DbSession dbSession, String internalPropertyKey) {
super(asInternalProperty(dbTester, dbSession, internalPropertyKey), InternalPropertyAssert.class);
}
private static InternalProperty asInternalProperty(DbTester dbTester, DbSession dbSession, String internalPropertyKey) {
Map<String, Object> row = dbTester.selectFirst(
dbSession,
"select" +
" is_empty as \"isEmpty\", text_value as \"textValue\", clob_value as \"clobValue\", created_at as \"createdAt\"" +
" from internal_properties" +
" where kee='" + internalPropertyKey + "'");
return new InternalProperty(
isEmpty(row),
(String) row.get("textValue"),
(String) row.get("clobValue"),
(Long) row.get("createdAt"));
}
private static Boolean isEmpty(Map<String, Object> row) {
Object flag = row.get("isEmpty");
if (flag instanceof Boolean) {
return (Boolean) flag;
}
if (flag instanceof Long) {
Long longBoolean = (Long) flag;
return longBoolean.equals(1L);
}
throw new IllegalArgumentException("Unsupported object type returned for column \"isEmpty\": " + flag.getClass());
}
InternalPropertyAssert isEmpty() {
isNotNull();
if (!Objects.equals(actual.empty(), TRUE)) {
failWithMessage("Expected Internal property to have column IS_EMPTY to be <%s> but was <%s>", true, actual.empty());
}
if (actual.textValue() != null) {
failWithMessage("Expected Internal property to have column TEXT_VALUE to be null but was <%s>", actual.textValue());
}
if (actual.clobValue() != null) {
failWithMessage("Expected Internal property to have column CLOB_VALUE to be null but was <%s>", actual.clobValue());
}
return this;
}
InternalPropertyAssert hasTextValue(String expected) {
isNotNull();
if (!Objects.equals(actual.textValue(), expected)) {
failWithMessage("Expected Internal property to have column TEXT_VALUE to be <%s> but was <%s>", true, actual.textValue());
}
if (actual.clobValue() != null) {
failWithMessage("Expected Internal property to have column CLOB_VALUE to be null but was <%s>", actual.clobValue());
}
if (!Objects.equals(actual.empty(), FALSE)) {
failWithMessage("Expected Internal property to have column IS_EMPTY to be <%s> but was <%s>", false, actual.empty());
}
return this;
}
InternalPropertyAssert hasClobValue(String expected) {
isNotNull();
if (!Objects.equals(actual.clobValue(), expected)) {
failWithMessage("Expected Internal property to have column CLOB_VALUE to be <%s> but was <%s>", true, actual.clobValue());
}
if (actual.textValue() != null) {
failWithMessage("Expected Internal property to have column TEXT_VALUE to be null but was <%s>", actual.textValue());
}
if (!Objects.equals(actual.empty(), FALSE)) {
failWithMessage("Expected Internal property to have column IS_EMPTY to be <%s> but was <%s>", false, actual.empty());
}
return this;
}
InternalPropertyAssert hasCreatedAt(long expected) {
isNotNull();
if (!Objects.equals(actual.createdAt(), expected)) {
failWithMessage("Expected Internal property to have column CREATED_AT to be <%s> but was <%s>", expected, actual.createdAt());
}
return this;
}
}
private record InternalProperty(Boolean empty, String textValue, String clobValue, Long createdAt) {
private InternalProperty(@Nullable Boolean empty, @Nullable String textValue, @Nullable String clobValue, @Nullable Long createdAt) {
this.empty = empty;
this.textValue = textValue;
this.clobValue = clobValue;
this.createdAt = createdAt;
}
@Override
@CheckForNull
public Boolean empty() {
return empty;
}
@Override
@CheckForNull
public String textValue() {
return textValue;
}
@Override
@CheckForNull
public String clobValue() {
return clobValue;
}
@Override
@CheckForNull
public Long createdAt() {
return createdAt;
}
}
}
|