1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
|
/*
* SonarQube
* Copyright (C) 2009-2025 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
package org.sonar.db.qualitygate;
import java.util.Collection;
import java.util.Comparator;
import java.util.Random;
import java.util.stream.IntStream;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;
import org.sonar.api.utils.System2;
import org.sonar.core.util.Uuids;
import org.sonar.db.DbSession;
import org.sonar.db.DbTester;
import org.sonar.db.metric.MetricDto;
import static org.apache.commons.lang3.RandomStringUtils.secure;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.AssertionsForClassTypes.tuple;
class QualityGateConditionDaoIT {
@RegisterExtension
private final DbTester dbTester = DbTester.create(System2.INSTANCE);
private final DbSession dbSession = dbTester.getSession();
private final QualityGateConditionDao underTest = dbTester.getDbClient().gateConditionDao();
@Test
void testInsert() {
QualityGateConditionDto newCondition = insertQGCondition("1", "2", "GT", "20");
assertThat(newCondition.getUuid()).isNotNull();
QualityGateConditionDto actual = underTest.selectByUuid(newCondition.getUuid(), dbSession);
assertEquals(actual, newCondition);
}
@Test
void testSelectForQualityGate() {
String qg1Uuid = "1";
String qg2Uuid = "2";
int qg1Conditions = 2 + new Random().nextInt(5);
int qg2Conditions = 10 + new Random().nextInt(5);
IntStream.range(0, qg1Conditions).forEach(i -> insertQGCondition(qg1Uuid));
IntStream.range(0, qg2Conditions).forEach(i -> insertQGCondition(qg2Uuid));
Collection<QualityGateConditionDto> conditions = underTest.selectForQualityGate(dbSession, qg1Uuid);
assertThat(conditions).hasSize(qg1Conditions);
assertThat(conditions)
.extracting("uuid")
.containsExactly(conditions.stream()
.sorted(Comparator.comparing(QualityGateConditionDto::getCreatedAt))
.map(QualityGateConditionDto::getUuid).toArray());
conditions = underTest.selectForQualityGate(dbSession, qg2Uuid);
assertThat(conditions).hasSize(qg2Conditions);
assertThat(conditions)
.extracting("uuid")
.containsExactly(conditions.stream()
.sorted(Comparator.comparing(QualityGateConditionDto::getCreatedAt))
.map(QualityGateConditionDto::getUuid)
.toArray());
assertThat(underTest.selectForQualityGate(dbSession, "5")).isEmpty();
}
@Test
void selectAll() {
MetricDto metric = dbTester.measures().insertMetric(t -> t.setEnabled(true));
QualityGateConditionDto condition1 = insertQGCondition("uuid1", metric.getUuid());
QualityGateConditionDto condition2 = insertQGCondition("uuid2", metric.getUuid());
QualityGateConditionDto condition3 = insertQGCondition("uuid3", metric.getUuid());
assertThat(underTest.selectAll(dbSession))
.extracting(QualityGateConditionDto::getUuid, QualityGateConditionDto::getMetricUuid)
.containsOnly(tuple(condition1.getUuid(), condition1.getMetricUuid()),
tuple(condition2.getUuid(), condition2.getMetricUuid()),
tuple(condition3.getUuid(), condition3.getMetricUuid()));
}
@Test
void testSelectByUuid() {
QualityGateConditionDto condition = insertQGCondition("1", "2", "GT", "20");
assertEquals(underTest.selectByUuid(condition.getUuid(), dbSession), condition);
assertThat(underTest.selectByUuid("uuid1", dbSession)).isNull();
}
@Test
void testDelete() {
QualityGateConditionDto condition1 = insertQGCondition("2");
QualityGateConditionDto condition2 = insertQGCondition("3");
underTest.delete(condition1, dbSession);
dbSession.commit();
assertThat(underTest.selectByUuid(condition1.getUuid(), dbSession)).isNull();
assertThat(underTest.selectByUuid(condition2.getUuid(), dbSession)).isNotNull();
}
@Test
void testDeleteForQualityGate() {
QualityGateConditionDto condition1 = insertQGCondition("qualityGateUuid");
QualityGateConditionDto condition2 = insertQGCondition("qualityGateUuid");
underTest.deleteForQualityGate("qualityGateUuid", dbSession);
dbSession.commit();
assertThat(underTest.selectForQualityGate(dbSession, "qualityGateUuid")).isEmpty();
assertThat(underTest.selectByUuid(condition1.getUuid(), dbSession)).isNull();
assertThat(underTest.selectByUuid(condition2.getUuid(), dbSession)).isNull();
}
@Test
void testUpdate() {
QualityGateConditionDto condition1 = insertQGCondition("2");
QualityGateConditionDto condition2 = insertQGCondition("3");
QualityGateConditionDto newCondition1 = new QualityGateConditionDto()
.setUuid(condition1.getUuid())
.setQualityGateUuid(condition1.getQualityGateUuid())
.setMetricUuid("7")
.setOperator(">")
.setErrorThreshold("80");
underTest.update(newCondition1, dbSession);
dbSession.commit();
assertEquals(underTest.selectByUuid(condition1.getUuid(), dbSession), newCondition1);
assertEquals(underTest.selectByUuid(condition2.getUuid(), dbSession), condition2);
}
@Test
void shouldCleanConditions() {
MetricDto enabledMetric = dbTester.measures().insertMetric(t -> t.setEnabled(true));
MetricDto disabledMetric = dbTester.measures().insertMetric(t -> t.setEnabled(false));
QualityGateConditionDto condition1 = insertQGCondition("1", enabledMetric.getUuid());
QualityGateConditionDto condition2 = insertQGCondition("1", disabledMetric.getUuid());
QualityGateConditionDto condition3 = insertQGCondition("1", "299");
underTest.deleteConditionsWithInvalidMetrics(dbTester.getSession());
dbTester.commit();
assertThat(underTest.selectByUuid(condition1.getUuid(), dbSession)).isNotNull();
assertThat(underTest.selectByUuid(condition2.getUuid(), dbSession)).isNull();
assertThat(underTest.selectByUuid(condition3.getUuid(), dbSession)).isNull();
}
@Test
void countByQualityGateUuid_shouldReturnCorrectCount() {
insertQGCondition("1", "1");
insertQGCondition("1", "3");
insertQGCondition("1", "299");
dbTester.commit();
assertThat(underTest.countByQualityGateUuid(dbSession,"1")).isEqualTo(3);
assertThat(underTest.countByQualityGateUuid(dbSession,"unknown")).isZero();
}
private QualityGateConditionDto insertQGCondition(String qualityGateUuid) {
return insertQGCondition(qualityGateUuid, secure().nextAlphabetic(2));
}
private QualityGateConditionDto insertQGCondition(String qualityGateUuid, String metricUuid) {
return insertQGCondition(qualityGateUuid, metricUuid, secure().nextAlphabetic(2), secure().nextAlphabetic(3));
}
private QualityGateConditionDto insertQGCondition(String qualityGateUuid, String metricUuid, String operator, String threshold) {
QualityGateConditionDto res = new QualityGateConditionDto()
.setUuid(Uuids.create())
.setQualityGateUuid(qualityGateUuid)
.setMetricUuid(metricUuid)
.setOperator(operator)
.setErrorThreshold(threshold);
underTest.insert(res, dbTester.getSession());
dbTester.commit();
return res;
}
private void assertEquals(QualityGateConditionDto actual, QualityGateConditionDto expected) {
assertThat(actual.getQualityGateUuid()).isEqualTo(expected.getQualityGateUuid());
assertThat(actual.getMetricUuid()).isEqualTo(expected.getMetricUuid());
assertThat(actual.getOperator()).isEqualTo(expected.getOperator());
assertThat(actual.getErrorThreshold()).isEqualTo(expected.getErrorThreshold());
}
}
|
