1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
|
/*
* SonarQube
* Copyright (C) 2009-2025 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
package org.sonar.db.user;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;
import org.mockito.ArgumentCaptor;
import org.sonar.api.utils.System2;
import org.sonar.db.DbClient;
import org.sonar.db.DbTester;
import org.sonar.db.audit.AuditPersister;
import org.sonar.db.audit.model.UserGroupNewValue;
import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
class UserGroupDaoWithPersisterIT {
private final AuditPersister auditPersister = mock(AuditPersister.class);
@RegisterExtension
private final DbTester db = DbTester.create(System2.INSTANCE, auditPersister);
private final ArgumentCaptor<UserGroupNewValue> newValueCaptor = ArgumentCaptor.forClass(UserGroupNewValue.class);
private final DbClient dbClient = db.getDbClient();
private final UserGroupDao underTest = dbClient.userGroupDao();
@Test
void insertUserGroupIsPersisted() {
UserDto user = db.users().insertUser();
verify(auditPersister).addUser(eq(db.getSession()), any());
GroupDto group = db.users().insertGroup();
UserGroupDto userGroupDto = new UserGroupDto().setUserUuid(user.getUuid()).setGroupUuid(group.getUuid());
underTest.insert(db.getSession(), userGroupDto, group.getName(), user.getLogin());
db.getSession().commit();
verify(auditPersister).addUserToGroup(eq(db.getSession()), newValueCaptor.capture());
assertThat(db.getDbClient().groupMembershipDao().selectGroupUuidsByUserUuid(db.getSession(), user.getUuid())).containsOnly(group.getUuid());
assertThat(newValueCaptor.getValue())
.extracting(UserGroupNewValue::getGroupUuid, UserGroupNewValue::getName, UserGroupNewValue::getUserUuid,
UserGroupNewValue::getUserLogin)
.containsExactly(group.getUuid(), group.getName(), user.getUuid(), user.getLogin());
}
@Test
void deleteUserGroupByGroupIsPersisted() {
UserDto user1 = db.users().insertUser();
UserDto user2 = db.users().insertUser();
GroupDto group1 = db.users().insertGroup();
GroupDto group2 = db.users().insertGroup();
db.users().insertMember(group1, user1);
db.users().insertMember(group1, user2);
db.users().insertMember(group2, user1);
db.users().insertMember(group2, user2);
underTest.deleteByGroupUuid(db.getSession(), group1.getUuid(), group1.getName());
db.getSession().commit();
assertThat(db.getDbClient().groupMembershipDao().selectGroupUuidsByUserUuid(db.getSession(), user1.getUuid())).containsOnly(group2.getUuid());
assertThat(db.getDbClient().groupMembershipDao().selectGroupUuidsByUserUuid(db.getSession(), user2.getUuid())).containsOnly(group2.getUuid());
verify(auditPersister).deleteUserFromGroup(eq(db.getSession()), newValueCaptor.capture());
assertThat(newValueCaptor.getValue())
.extracting(UserGroupNewValue::getGroupUuid, UserGroupNewValue::getName)
.containsExactly(group1.getUuid(), group1.getName());
}
@Test
void deleteUserGroupByGroupWithoutAffectedRowsIsNotPersisted() {
GroupDto group1 = db.users().insertGroup();
underTest.deleteByGroupUuid(db.getSession(), group1.getUuid(), group1.getName());
db.getSession().commit();
verify(auditPersister).addUserGroup(any(), any());
verifyNoMoreInteractions(auditPersister);
}
@Test
void deleteUserGroupByUserIsPersisted() {
UserDto user1 = db.users().insertUser();
UserDto user2 = db.users().insertUser();
GroupDto group1 = db.users().insertGroup();
GroupDto group2 = db.users().insertGroup();
db.users().insertMember(group1, user1);
db.users().insertMember(group1, user2);
db.users().insertMember(group2, user1);
db.users().insertMember(group2, user2);
underTest.deleteByUserUuid(db.getSession(), user1);
db.getSession().commit();
assertThat(db.getDbClient().groupMembershipDao().selectGroupUuidsByUserUuid(db.getSession(), user1.getUuid())).isEmpty();
assertThat(db.getDbClient().groupMembershipDao().selectGroupUuidsByUserUuid(db.getSession(), user2.getUuid())).containsOnly(group1.getUuid(), group2.getUuid());
verify(auditPersister).deleteUserFromGroup(eq(db.getSession()), newValueCaptor.capture());
assertThat(newValueCaptor.getValue())
.extracting(UserGroupNewValue::getUserUuid, UserGroupNewValue::getUserLogin)
.containsExactly(user1.getUuid(), user1.getLogin());
}
@Test
void deleteUserGroupByUserWithoutAffectedRowsIsNotPersisted() {
UserDto user1 = db.users().insertUser();
underTest.deleteByUserUuid(db.getSession(), user1);
db.getSession().commit();
verify(auditPersister).addUser(any(), any());
verifyNoMoreInteractions(auditPersister);
}
@Test
void delete_by_user_and_group() {
UserDto user1 = db.users().insertUser();
UserDto user2 = db.users().insertUser();
GroupDto group1 = db.users().insertGroup();
db.users().insertMember(group1, user1);
db.users().insertMember(group1, user2);
underTest.delete(db.getSession(), group1, user1);
db.getSession().commit();
assertThat(db.getDbClient().groupMembershipDao().selectGroupUuidsByUserUuid(db.getSession(), user1.getUuid())).isEmpty();
assertThat(db.getDbClient().groupMembershipDao().selectGroupUuidsByUserUuid(db.getSession(), user2.getUuid())).containsOnly(group1.getUuid());
verify(auditPersister).deleteUserFromGroup(eq(db.getSession()), newValueCaptor.capture());
assertThat(newValueCaptor.getValue())
.extracting(UserGroupNewValue::getGroupUuid, UserGroupNewValue::getName, UserGroupNewValue::getUserUuid,
UserGroupNewValue::getUserLogin)
.containsExactly(group1.getUuid(), group1.getName(), user1.getUuid(), user1.getLogin());
}
@Test
void deleteByUserAndGroupWithoutAffectedRowsIsNotPersisted() {
UserDto user1 = db.users().insertUser();
GroupDto group1 = db.users().insertGroup();
underTest.delete(db.getSession(), group1, user1);
db.getSession().commit();
verify(auditPersister).addUser(any(), any());
verify(auditPersister).addUserGroup(any(), any());
verifyNoMoreInteractions(auditPersister);
}
}
|
