aboutsummaryrefslogtreecommitdiffstats
path: root/sonar-batch/src/test/java/org/sonar/batch/index/MeasurePersisterTest.java
blob: 90d597908c5cdf098193abd051ce54064542a581 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
/*
 * Sonar, open source software quality management tool.
 * Copyright (C) 2009 SonarSource SA
 * mailto:contact AT sonarsource DOT com
 *
 * Sonar is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 3 of the License, or (at your option) any later version.
 *
 * Sonar is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with Sonar; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02
 */
package org.sonar.batch.index;

import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;
import org.sonar.api.database.model.MeasureModel;
import org.sonar.api.database.model.Snapshot;
import org.sonar.api.measures.CoreMetrics;
import org.sonar.api.measures.Measure;
import org.sonar.api.measures.Metric;
import org.sonar.api.measures.PersistenceMode;
import org.sonar.api.resources.JavaFile;
import org.sonar.api.resources.JavaPackage;
import org.sonar.api.resources.Project;
import org.sonar.core.components.DefaultRuleFinder;
import org.sonar.jpa.test.AbstractDbUnitTestCase;

import java.util.List;

import static org.hamcrest.CoreMatchers.is;
import static org.junit.Assert.assertThat;
import static org.mockito.Matchers.anyObject;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

public class MeasurePersisterTest extends AbstractDbUnitTestCase {

  public static final int PROJECT_SNAPSHOT_ID = 3001;
  public static final int PACKAGE_SNAPSHOT_ID = 3002;
  public static final int FILE_SNAPSHOT_ID = 3003;
  public static final int COVERAGE_METRIC_ID = 2;

  private ResourcePersister resourcePersister;
  private MeasurePersister measurePersister;
  private Project project = new Project("foo");
  private JavaPackage aPackage = new JavaPackage("org.foo");
  private JavaFile aFile = new JavaFile("org.foo.Bar");
  private Snapshot projectSnapshot, packageSnapshot, fileSnapshot;
  private Metric ncloc, coverage;

  @Before
  public void mockResourcePersister() {
    setupData("shared");
    resourcePersister = mock(ResourcePersister.class);
    projectSnapshot = getSession().getSingleResult(Snapshot.class, "id", PROJECT_SNAPSHOT_ID);
    packageSnapshot = getSession().getSingleResult(Snapshot.class, "id", PACKAGE_SNAPSHOT_ID);
    fileSnapshot = getSession().getSingleResult(Snapshot.class, "id", FILE_SNAPSHOT_ID);
    ncloc = getSession().getSingleResult(Metric.class, "key", "ncloc");
    coverage = getSession().getSingleResult(Metric.class, "key", "coverage");
    when(resourcePersister.saveResource((Project) anyObject(), eq(project))).thenReturn(projectSnapshot);
    when(resourcePersister.saveResource((Project) anyObject(), eq(aPackage))).thenReturn(packageSnapshot);
    when(resourcePersister.saveResource((Project) anyObject(), eq(aFile))).thenReturn(fileSnapshot);
    when(resourcePersister.getSnapshot(project)).thenReturn(projectSnapshot);
    when(resourcePersister.getSnapshot(aPackage)).thenReturn(packageSnapshot);
    when(resourcePersister.getSnapshot(aFile)).thenReturn(fileSnapshot);
    measurePersister = new MeasurePersister(getSession(), resourcePersister, new DefaultRuleFinder(getSessionFactory()));
  }

  @Test
  public void shouldInsertMeasure() {
    Measure measure = new Measure(ncloc).setValue(1234.0);

    measurePersister.saveMeasure(project, measure);

    checkTables("shouldInsertMeasure", "project_measures");
  }

  @Test
  public void shouldUpdateMeasure() {
    Measure measure = new Measure(coverage).setValue(12.5);
    measure.setId(1L);

    measurePersister.saveMeasure(project, measure);

    checkTables("shouldUpdateMeasure", "project_measures");
  }

  @Test
  public void shouldAddDelayedMeasureSeveralTimes() {
    measurePersister.setDelayedMode(true);
    Measure measure = new Measure(ncloc).setValue(200.0);
    measurePersister.saveMeasure(project, measure);

    measure.setValue(300.0);
    measurePersister.saveMeasure(project, measure);

    measurePersister.dump();

    List<MeasureModel> coverageMeasures = getSession().getResults(MeasureModel.class, "snapshotId", PROJECT_SNAPSHOT_ID, "metricId", 1);
    assertThat(coverageMeasures.size(), is(1));
    assertThat(coverageMeasures.get(0).getValue(), is(300.0));
  }

  @Test
  @Ignore("to do")
  public void shouldInsertDataMeasure() {

  }

  @Test
  public void shouldDelaySaving() {
    measurePersister.setDelayedMode(true);

    measurePersister.saveMeasure(project, new Measure(ncloc).setValue(1234.0));
    measurePersister.saveMeasure(project, aPackage, new Measure(ncloc).setValue(50.0));

    assertThat(getSession().getResults(MeasureModel.class, "metricId", 1).size(), is(0));

    measurePersister.dump();
    checkTables("shouldDelaySaving", "project_measures");
  }

  @Test
  public void shouldNotDelaySavingWithDatabaseOnlyMeasure() {
    measurePersister.setDelayedMode(true);

    measurePersister.saveMeasure(project, new Measure(ncloc).setValue(1234.0).setPersistenceMode(PersistenceMode.DATABASE)); // database only
    measurePersister.saveMeasure(project, aPackage, new Measure(ncloc).setValue(50.0)); // database + memory

    // no dump => the db-only measure is saved

    checkTables("shouldNotDelaySavingWithDatabaseOnlyMeasure", "project_measures");
  }

  @Test
  public void shouldNotSaveBestValues() {
    JavaFile file = new JavaFile("org.foo.MyClass");

    Measure measure = new Measure(coverage).setValue(0.0);
    assertThat(MeasurePersister.shouldPersistMeasure(file, measure), is(true));

    measure = new Measure(coverage).setValue(75.8);
    assertThat(MeasurePersister.shouldPersistMeasure(file, measure), is(true));

    measure = new Measure(coverage).setValue(100.0);
    assertThat(MeasurePersister.shouldPersistMeasure(file, measure), is(false));
  }

  @Test
  public void shouldNotSaveBestValueMeasuresInDelayedMode() {
    measurePersister.setDelayedMode(true);

    measurePersister.saveMeasure(project, aFile, new Measure(coverage).setValue(100.0));

    assertThat(getSession().getResults(MeasureModel.class, "metricId", COVERAGE_METRIC_ID, "snapshotId", FILE_SNAPSHOT_ID).size(), is(0));

    measurePersister.dump();

    // not saved because it's a best value measure
    assertThat(getSession().getResults(MeasureModel.class, "metricId", COVERAGE_METRIC_ID, "snapshotId", FILE_SNAPSHOT_ID).size(), is(0));
  }


  @Test
  public void shouldNotSaveMemoryOnlyMeasures() {
    Measure measure = new Measure("ncloc").setPersistenceMode(PersistenceMode.MEMORY);
    assertThat(MeasurePersister.shouldPersistMeasure(aPackage, measure), is(false));
  }

  @Test
  public void shouldAlwaysPersistNonFileMeasures() {
    assertThat(MeasurePersister.shouldPersistMeasure(project, new Measure(CoreMetrics.LINES, 200.0)), is(true));
    assertThat(MeasurePersister.shouldPersistMeasure(aPackage, new Measure(CoreMetrics.LINES, 200.0)), is(true));
  }

  @Test
  public void shouldNotPersistSomeFileMeasuresWithBestValue() {
    JavaFile file = new JavaFile("org.foo.Bar");

    // must persist:
    assertThat(MeasurePersister.shouldPersistMeasure(file, new Measure(CoreMetrics.LINES, 200.0)), is(true));
    assertThat(MeasurePersister.shouldPersistMeasure(file, new Measure(CoreMetrics.DUPLICATED_LINES_DENSITY, 3.0)), is(true));


    // must not persist:
    Measure duplicatedLines = new Measure(CoreMetrics.DUPLICATED_LINES_DENSITY, 0.0);
    assertThat(MeasurePersister.shouldPersistMeasure(file, duplicatedLines), is(false));

    duplicatedLines.setVariation1(0.0);
    assertThat(MeasurePersister.shouldPersistMeasure(file, duplicatedLines), is(false));

    duplicatedLines.setVariation1(-3.0);
    assertThat(MeasurePersister.shouldPersistMeasure(file, duplicatedLines), is(true));
  }

  @Test
  public void nullValueAndNullVariationsShouldBeConsideredAsBestValue() {
    Measure measure = new Measure(CoreMetrics.NEW_VIOLATIONS_KEY);
    assertThat(MeasurePersister.isBestValueMeasure(measure, CoreMetrics.NEW_VIOLATIONS), is(true));
  }
}