1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
|
/*
* SonarQube, open source software quality management tool.
* Copyright (C) 2008-2014 SonarSource
* mailto:contact AT sonarsource DOT com
*
* SonarQube is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* SonarQube is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
package org.sonar.batch.index;
import org.apache.commons.lang.StringUtils;
import org.junit.Before;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.mockito.ArgumentCaptor;
import org.sonar.api.database.model.MeasureModel;
import org.sonar.api.database.model.Snapshot;
import org.sonar.api.measures.CoreMetrics;
import org.sonar.api.measures.Measure;
import org.sonar.api.measures.Metric;
import org.sonar.api.measures.PersistenceMode;
import org.sonar.api.measures.RuleMeasure;
import org.sonar.api.resources.Directory;
import org.sonar.api.resources.File;
import org.sonar.api.resources.Project;
import org.sonar.api.rules.Rule;
import org.sonar.api.rules.RuleFinder;
import org.sonar.api.rules.RulePriority;
import org.sonar.api.utils.SonarException;
import org.sonar.core.persistence.AbstractDaoTestCase;
import static org.fest.assertions.Assertions.assertThat;
import static org.mockito.Matchers.any;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
public class MeasurePersisterTest extends AbstractDaoTestCase {
@org.junit.Rule
public ExpectedException thrown = ExpectedException.none();
private static final String SHORT = "SHORT";
private static final String LONG = StringUtils.repeat("0123456789", 10);
private static final String TOO_LONG = StringUtils.repeat("0123456789", 401);
public static final int PROJECT_SNAPSHOT_ID = 3001;
public static final int PACKAGE_SNAPSHOT_ID = 3002;
public static final int FILE_SNAPSHOT_ID = 3003;
public static final int COVERAGE_METRIC_ID = 2;
MeasurePersister measurePersister;
RuleFinder ruleFinder = mock(RuleFinder.class);
ResourcePersister resourcePersister = mock(ResourcePersister.class);
MemoryOptimizer memoryOptimizer = mock(MemoryOptimizer.class);
Project project = new Project("foo");
Directory aDirectory = new Directory("org/foo");
File aFile = new File("org/foo/Bar.java");
Snapshot projectSnapshot = snapshot(PROJECT_SNAPSHOT_ID);
Snapshot packageSnapshot = snapshot(PACKAGE_SNAPSHOT_ID);
@Before
public void mockResourcePersister() {
when(resourcePersister.getSnapshotOrFail(project)).thenReturn(projectSnapshot);
when(resourcePersister.getSnapshotOrFail(aDirectory)).thenReturn(packageSnapshot);
when(resourcePersister.getSnapshot(project)).thenReturn(projectSnapshot);
when(resourcePersister.getSnapshot(aDirectory)).thenReturn(packageSnapshot);
measurePersister = new MeasurePersister(getMyBatis(), resourcePersister, ruleFinder, memoryOptimizer);
}
@Test
public void should_insert_measure() {
setupData("empty");
Measure measure = new Measure(ncloc()).setValue(1234.0);
measurePersister.saveMeasure(project, measure);
checkTables("shouldInsertMeasure", "project_measures");
verify(memoryOptimizer).evictDataMeasure(eq(measure), any(MeasureModel.class));
assertThat(measure.getId()).isNotNull();
}
@Test
public void should_display_contextual_info_when_error_during_insert_measure() {
setupData("empty");
Measure measure = new Measure(ncloc()).setValue(1234.0).setAlertText(TOO_LONG);
thrown.expect(SonarException.class);
thrown.expectMessage("Unable to save measure for metric [ncloc] on component [foo]");
measurePersister.saveMeasure(project, measure);
}
@Test
public void should_reload_measure() {
Measure measure = new Measure(ncloc());
measurePersister.reloadMeasure(measure);
verify(memoryOptimizer).reloadMeasure(measure);
}
@Test
public void should_insert_rule_measure() {
setupData("empty");
Rule rule = Rule.create("pmd", "key");
when(ruleFinder.findByKey("pmd", "key")).thenReturn(rule);
Measure measure = new RuleMeasure(ncloc(), rule, RulePriority.MAJOR, 1).setValue(1234.0);
measurePersister.saveMeasure(project, measure);
checkTables("shouldInsertRuleMeasure", "project_measures");
assertThat(measure.getId()).isNotNull();
}
@Test
public void should_insert_measure_with_text_data() {
setupData("empty");
Measure withLargeData = new Measure(ncloc()).setData(LONG);
measurePersister.saveMeasure(project, withLargeData);
checkTables("shouldInsertMeasureWithLargeData", "project_measures", "measure_data");
ArgumentCaptor<MeasureModel> validMeasureModel = ArgumentCaptor.forClass(MeasureModel.class);
verify(memoryOptimizer).evictDataMeasure(eq(withLargeData), validMeasureModel.capture());
assertThat(validMeasureModel.getValue().getMeasureData().getId()).isNotNull();
assertThat(withLargeData.getId()).isNotNull();
}
@Test
public void should_not_save_best_values() {
setupData("empty");
measurePersister.saveMeasure(aFile, new Measure(coverage()).setValue(100.0));
assertEmptyTables("project_measures", "measure_data");
}
@Test
public void should_not_save_memory_only_measures() {
setupData("empty");
measurePersister.saveMeasure(aFile, new Measure("ncloc").setPersistenceMode(PersistenceMode.MEMORY));
assertEmptyTables("project_measures", "measure_data");
}
@Test
public void should_always_save_non_file_measures() {
setupData("empty");
measurePersister.saveMeasure(project, new Measure(ncloc()).setValue(200.0));
measurePersister.saveMeasure(aDirectory, new Measure(ncloc()).setValue(300.0));
checkTables("shouldAlwaysPersistNonFileMeasures", "project_measures");
}
@Test
public void should_update_measure() {
setupData("data");
measurePersister.saveMeasure(project, new Measure(coverage()).setValue(12.5).setId(1L));
measurePersister.saveMeasure(project, new Measure(coverage()).setData(SHORT).setId(2L));
measurePersister.saveMeasure(aDirectory, new Measure(coverage()).setData(LONG).setId(3L));
checkTables("shouldUpdateMeasure", "project_measures", "measure_data");
}
@Test
public void should_add_delayed_measure_several_times() {
setupData("empty");
Measure measure = new Measure(ncloc());
measurePersister.setDelayedMode(true);
measurePersister.saveMeasure(project, measure.setValue(200.0));
measurePersister.saveMeasure(project, measure.setValue(300.0));
measurePersister.dump();
checkTables("shouldAddDelayedMeasureSeveralTimes", "project_measures");
}
@Test
public void should_delay_saving() {
setupData("empty");
measurePersister.setDelayedMode(true);
measurePersister.saveMeasure(project, new Measure(ncloc()).setValue(1234.0).setData(SHORT));
measurePersister.saveMeasure(aDirectory, new Measure(ncloc()).setValue(50.0).setData(LONG));
assertEmptyTables("project_measures");
measurePersister.dump();
checkTables("shouldDelaySaving", "project_measures", "measure_data");
}
@Test
public void should_display_contextual_info_when_error_during_delay_saving() {
setupData("empty");
measurePersister.setDelayedMode(true);
measurePersister.saveMeasure(project, new Measure(ncloc()).setValue(1234.0).setData(SHORT).setAlertText(TOO_LONG));
thrown.expect(SonarException.class);
thrown.expectMessage("Unable to save measure for metric [ncloc] on component [foo]");
measurePersister.dump();
}
@Test
public void should_not_delay_saving_with_database_only_measure() {
setupData("empty");
measurePersister.setDelayedMode(true);
measurePersister.saveMeasure(project, new Measure(ncloc()).setValue(1234.0).setPersistenceMode(PersistenceMode.DATABASE));
measurePersister.saveMeasure(aDirectory, new Measure(ncloc()).setValue(50.0));
checkTables("shouldInsertMeasure", "project_measures");
}
@Test
public void should_not_save_best_value_measures_in_delayed_mode() {
setupData("empty");
measurePersister.setDelayedMode(true);
measurePersister.saveMeasure(aFile, new Measure(coverage()).setValue(100.0));
assertEmptyTables("project_measures", "measure_data");
measurePersister.dump();
assertEmptyTables("project_measures", "measure_data");
}
@Test
public void should_not_save_some_file_measures_with_best_value() {
assertThat(MeasurePersister.shouldPersistMeasure(aFile, new Measure(CoreMetrics.LINES, 200.0))).isTrue();
assertThat(MeasurePersister.shouldPersistMeasure(aFile, new Measure(CoreMetrics.DUPLICATED_LINES_DENSITY, 3.0))).isTrue();
Measure duplicatedLines = new Measure(CoreMetrics.DUPLICATED_LINES_DENSITY, 0.0);
assertThat(MeasurePersister.shouldPersistMeasure(aFile, duplicatedLines)).isFalse();
duplicatedLines.setVariation1(0.0);
assertThat(MeasurePersister.shouldPersistMeasure(aFile, duplicatedLines)).isFalse();
duplicatedLines.setVariation1(-3.0);
assertThat(MeasurePersister.shouldPersistMeasure(aFile, duplicatedLines)).isTrue();
}
@Test
public void should_not_save_measures_without_data() {
assertThat(MeasurePersister.shouldPersistMeasure(aFile, new Measure(CoreMetrics.LINES))).isFalse();
Measure duplicatedLines = new Measure(CoreMetrics.DUPLICATED_LINES_DENSITY);
assertThat(MeasurePersister.shouldPersistMeasure(aFile, duplicatedLines)).isFalse();
}
private static Snapshot snapshot(int id) {
Snapshot snapshot = mock(Snapshot.class);
when(snapshot.getId()).thenReturn(id);
return snapshot;
}
private static Metric ncloc() {
Metric ncloc = mock(Metric.class);
when(ncloc.getId()).thenReturn(1);
when(ncloc.getKey()).thenReturn("ncloc");
return ncloc;
}
private static Metric coverage() {
Metric coverage = mock(Metric.class);
when(coverage.getId()).thenReturn(COVERAGE_METRIC_ID);
when(coverage.getKey()).thenReturn("coverage");
when(coverage.isOptimizedBestValue()).thenReturn(true);
when(coverage.getBestValue()).thenReturn(100.0);
return coverage;
}
}
|