1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
|
/*
* SonarQube
* Copyright (C) 2009-2025 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
package org.sonar.scanner.scan.filesystem;
import com.tngtech.java.junit.dataprovider.DataProvider;
import com.tngtech.java.junit.dataprovider.DataProviderRunner;
import com.tngtech.java.junit.dataprovider.UseDataProvider;
import java.io.File;
import java.lang.reflect.Field;
import java.nio.file.Paths;
import java.util.HashMap;
import java.util.Map;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
import org.junit.runner.RunWith;
import org.sonar.api.config.internal.MapSettings;
import org.sonar.api.resources.Language;
import org.sonar.api.resources.Languages;
import org.sonar.api.utils.MessageException;
import org.sonar.scanner.mediumtest.FakeLanguagesLoader;
import org.sonar.scanner.repository.language.DefaultLanguagesRepository;
import static java.io.File.separator;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.endsWith;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
@RunWith(DataProviderRunner.class)
public class LanguageDetectionTest {
@Rule
public TemporaryFolder temp = new TemporaryFolder();
private MapSettings settings;
@Before
public void setUp() {
settings = new MapSettings();
}
@Test
@UseDataProvider("extensionsForSanitization")
public void sanitizeExtension_shouldRemoveObsoleteCharacters(String extension) {
assertThat(LanguageDetection.sanitizeExtension(extension)).isEqualTo("cbl");
}
@DataProvider
public static Object[][] extensionsForSanitization() {
return new Object[][] {
{".cbl"},
{".CBL"},
{"CBL"},
{"cbl"},
};
}
@Test
public void detectLanguageKey_shouldDetectByFileExtension() {
DefaultLanguagesRepository languages = new DefaultLanguagesRepository(new FakeLanguagesLoader(new Languages(new MockLanguage("java", "java", "jav"), new MockLanguage("cobol", "cbl", "cob"))));
languages.start();
LanguageDetection detection = new LanguageDetection(settings.asConfig(), languages);
assertThat(detectLanguageKey(detection, "Foo.java")).isEqualTo("java");
assertThat(detectLanguageKey(detection, "src/Foo.java")).isEqualTo("java");
assertThat(detectLanguageKey(detection, "Foo.JAVA")).isEqualTo("java");
assertThat(detectLanguageKey(detection, "Foo.jav")).isEqualTo("java");
assertThat(detectLanguageKey(detection, "Foo.Jav")).isEqualTo("java");
assertThat(detectLanguageKey(detection, "abc.cbl")).isEqualTo("cobol");
assertThat(detectLanguageKey(detection, "abc.CBL")).isEqualTo("cobol");
assertThat(detectLanguageKey(detection, "abc.php")).isNull();
assertThat(detectLanguageKey(detection, "abc")).isNull();
}
@Test
@UseDataProvider("filenamePatterns")
public void detectLanguageKey_shouldDetectByFileNamePattern(String fileName, String expectedLanguageKey) {
DefaultLanguagesRepository languages = new DefaultLanguagesRepository(new FakeLanguagesLoader(new Languages(
new MockLanguage("docker", new String[0], new String[] {"*.dockerfile", "*.Dockerfile", "Dockerfile", "Dockerfile.*"}),
new MockLanguage("terraform", new String[] {"tf"}, new String[] {".tf"}),
new MockLanguage("java", new String[0], new String[] {"**/*Test.java"}))));
languages.start();
LanguageDetection detection = new LanguageDetection(settings.asConfig(), languages);
assertThat(detectLanguageKey(detection, fileName)).isEqualTo(expectedLanguageKey);
}
@DataProvider
public static Object[][] filenamePatterns() {
return new Object[][] {
{"Dockerfile", "docker"},
{"src/Dockerfile", "docker"},
{"my.Dockerfile", "docker"},
{"my.dockerfile", "docker"},
{"Dockerfile.old", "docker"},
{"Dockerfile.OLD", "docker"},
{"DOCKERFILE", null},
{"infra.tf", "terraform"},
{"FooTest.java", "java"},
{"FooTest.JAVA", "java"},
{"FooTEST.java", null}
};
}
@Test
public void detectLanguageKey_shouldNotFailIfNoLanguage() {
LanguageDetection detection = spy(new LanguageDetection(settings.asConfig(), new DefaultLanguagesRepository(new FakeLanguagesLoader(new Languages()))));
assertThat(detectLanguageKey(detection, "Foo.java")).isNull();
}
@Test
public void detectLanguageKey_shouldAllowPluginsToDeclareFileExtensionTwiceForCaseSensitivity() {
DefaultLanguagesRepository languages = new DefaultLanguagesRepository(new FakeLanguagesLoader(new Languages(new MockLanguage("abap", "abap", "ABAP"))));
languages.start();
LanguageDetection detection = new LanguageDetection(settings.asConfig(), languages);
assertThat(detectLanguageKey(detection, "abc.abap")).isEqualTo("abap");
}
@Test
public void detectLanguageKey_shouldFailIfConflictingLanguageSuffix() {
DefaultLanguagesRepository languages = new DefaultLanguagesRepository(new FakeLanguagesLoader(new Languages(new MockLanguage("xml", "xhtml"), new MockLanguage("web", "xhtml"))));
languages.start();
LanguageDetection detection = new LanguageDetection(settings.asConfig(), languages);
assertThatThrownBy(() -> detectLanguageKey(detection, "abc.xhtml"))
.isInstanceOf(MessageException.class)
.hasMessageContaining("Language of file 'abc.xhtml' can not be decided as the file matches patterns of both ")
.hasMessageContaining("sonar.lang.patterns.web : **/*.xhtml")
.hasMessageContaining("sonar.lang.patterns.xml : **/*.xhtml");
}
@Test
public void detectLanguageKey_shouldSolveConflictUsingFilePattern() {
DefaultLanguagesRepository languages = new DefaultLanguagesRepository(new FakeLanguagesLoader(new Languages(new MockLanguage("xml", "xhtml"), new MockLanguage("web", "xhtml"))));
languages.start();
settings.setProperty("sonar.lang.patterns.xml", "xml/**");
settings.setProperty("sonar.lang.patterns.web", "web/**");
LanguageDetection detection = new LanguageDetection(settings.asConfig(), languages);
assertThat(detectLanguageKey(detection, "xml/abc.xhtml")).isEqualTo("xml");
assertThat(detectLanguageKey(detection, "web/abc.xhtml")).isEqualTo("web");
}
@Test
public void detectLanguageKey_shouldFailIfConflictingFilePattern() {
DefaultLanguagesRepository languages = new DefaultLanguagesRepository(new FakeLanguagesLoader(new Languages(new MockLanguage("abap", "abap"), new MockLanguage("cobol", "cobol"))));
languages.start();
settings.setProperty("sonar.lang.patterns.abap", "*.abap,*.txt");
settings.setProperty("sonar.lang.patterns.cobol", "*.cobol,*.txt");
LanguageDetection detection = new LanguageDetection(settings.asConfig(), languages);
assertThat(detectLanguageKey(detection, "abc.abap")).isEqualTo("abap");
assertThat(detectLanguageKey(detection, "abc.cobol")).isEqualTo("cobol");
assertThatThrownBy(() -> detectLanguageKey(detection, "abc.txt"))
.hasMessageContaining("Language of file 'abc.txt' can not be decided as the file matches patterns of both ")
.hasMessageContaining("sonar.lang.patterns.abap : *.abap,*.txt")
.hasMessageContaining("sonar.lang.patterns.cobol : *.cobol,*.txt");
}
@Test
public void should_cache_detected_language_by_file_path() {
DefaultLanguagesRepository languages = new DefaultLanguagesRepository(new FakeLanguagesLoader(new Languages(
new MockLanguage("java", "java", "jav"), new MockLanguage("cobol", "cbl", "cob"))));
languages.start();
LanguageDetection detection = new LanguageDetection(settings.asConfig(), languages);
var languageCacheSpy = spyInternalLanguageCache(detection);
assertThat(detectLanguageKey(detection, "Foo.java")).isEqualTo("java");
assertThat(detectLanguageKey(detection, "Foo.java")).isEqualTo("java");
verify(languageCacheSpy, times(1)).put(endsWith(separator + "Foo.java"), any(org.sonar.scanner.repository.language.Language.class));
verify(languageCacheSpy, times(2)).get(endsWith(separator + "Foo.java"));
}
private static Map<String, org.sonar.scanner.repository.language.Language> spyInternalLanguageCache(LanguageDetection detection) {
Map<String, org.sonar.scanner.repository.language.Language> languageCacheSpy = spy(new HashMap<>());
Field field;
try {
field = LanguageDetection.class.getDeclaredField("languageCacheByPath");
field.setAccessible(true);
field.set(detection, languageCacheSpy);
} catch (NoSuchFieldException | IllegalAccessException e) {
throw new RuntimeException(e);
}
return languageCacheSpy;
}
private String detectLanguageKey(LanguageDetection detection, String path) {
org.sonar.scanner.repository.language.Language language = detection.language(new File(temp.getRoot(), path).toPath(), Paths.get(path));
return language != null ? language.key() : null;
}
static class MockLanguage implements Language {
private final String key;
private final String[] extensions;
private final String[] filenamePatterns;
MockLanguage(String key, String... extensions) {
this.key = key;
this.extensions = extensions;
this.filenamePatterns = new String[0];
}
MockLanguage(String key, String[] extensions, String[] filenamePatterns) {
this.key = key;
this.extensions = extensions;
this.filenamePatterns = filenamePatterns;
}
@Override
public String getKey() {
return key;
}
@Override
public String getName() {
return getKey();
}
@Override
public String[] getFileSuffixes() {
return extensions;
}
@Override
public String[] filenamePatterns() {
return filenamePatterns;
}
@Override
public boolean publishAllFiles() {
return true;
}
}
}
|