1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
|
/*
* SonarQube
* Copyright (C) 2009-2018 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
package org.sonarqube.tests.user;
import com.sonar.orchestrator.Orchestrator;
import java.util.concurrent.TimeUnit;
import org.junit.After;
import org.junit.Before;
import org.junit.ClassRule;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.DisableOnDebug;
import org.junit.rules.TestRule;
import org.junit.rules.Timeout;
import org.sonarqube.qa.util.Tester;
import org.sonarqube.tests.Byteman;
import org.sonarqube.ws.Users.CreateWsResponse.User;
import org.sonarqube.ws.client.users.SearchRequest;
import org.sonarqube.ws.client.users.UpdateRequest;
import util.ItUtils;
import static org.assertj.core.api.Assertions.assertThat;
import static org.sonarqube.tests.Byteman.Process.WEB;
import static util.ItUtils.expectHttpError;
import static util.ItUtils.newOrchestratorBuilder;
public class UserEsResilienceTest {
@ClassRule
public static final Orchestrator orchestrator;
private static final Byteman byteman;
static {
byteman = new Byteman(newOrchestratorBuilder(), WEB);
orchestrator = byteman
.getOrchestratorBuilder()
.setServerProperty("sonar.search.recovery.delayInMs", "1000")
.setServerProperty("sonar.search.recovery.minAgeInMs", "3000")
.addPlugin(ItUtils.xooPlugin())
.build();
}
@Before
public void before() throws Exception {
byteman.activateScript("resilience/user_indexer.btm");
}
@After
public void after() throws Exception {
byteman.deactivateAllRules();
}
@Rule
public TestRule timeout = new DisableOnDebug(Timeout.builder()
.withLookingForStuckThread(true)
.withTimeout(60L, TimeUnit.SECONDS)
.build());
@Rule
public Tester tester = new Tester(orchestrator);
@Test
public void creation_and_update_of_user_are_resilient_to_indexing_errors() throws Exception {
String login = "error";
// creation of user succeeds but index is not up-to-date (indexing
// failures are not propagated to web services)
User user = tester.users().generate(u -> u.setLogin(login));
// user exists in db, it can't be created again.
// However he's not indexed.
expectHttpError(400, "An active user with login '" + login + "' already exists",
() -> tester.users().generate(u -> u.setLogin(login)));
assertThat(isReturnedInSearch(user.getLogin())).isFalse();
while (!isReturnedInSearch(user.getLogin())) {
// user is indexed by the recovery daemon, which runs every 5 seconds
Thread.sleep(1_000L);
}
// update the name. Db operation succeeds but not ES indexing.
// Renaming is not propagated to index as long as recovery does not
// run.
String newName = "renamed";
tester.users().service().update(new UpdateRequest().setLogin(login).setName(newName));
assertThat(isReturnedInSearch(newName)).isFalse();
while (!isReturnedInSearch(newName)) {
// user is indexed by the recovery daemon, which runs every 5 seconds
Thread.sleep(1_000L);
}
}
@Test
public void creation_and_update_of_user_are_resilient_to_indexing_crash() throws Exception {
String login = "crash";
// creation of user succeeds in db but indexing crashes --> ws fails
expectHttpError(500, () -> tester.users().generate(u -> u.setLogin(login)));
// user exists in db, it can't be created again.
// However he's not indexed.
expectHttpError(400, "An active user with login '" + login + "' already exists",
() -> tester.users().generate(u -> u.setLogin(login)));
assertThat(isReturnedInSearch(login)).isFalse();
while (!isReturnedInSearch(login)) {
// user is indexed by the recovery daemon, which runs every 5 seconds
Thread.sleep(1_000L);
}
// update the name. Db operation succeeds but ES indexing crashes.
// Renaming is not propagated to index as long as recovery does not
// run.
String newName = "renamed";
expectHttpError(500, () -> tester.users().service().update(new UpdateRequest().setLogin(login).setName(newName)));
assertThat(isReturnedInSearch(newName)).isFalse();
while (!isReturnedInSearch(newName)) {
// user is indexed by the recovery daemon, which runs every 5 seconds
Thread.sleep(1_000L);
}
}
private boolean isReturnedInSearch(String name) {
return tester.users().service().search(new SearchRequest().setQ(name)).getUsersCount() == 1L;
}
}
|
