aboutsummaryrefslogtreecommitdiffstats
path: root/common/rfb/DecodeManager.cxx
diff options
context:
space:
mode:
authorPierre Ossman <ossman@cendio.se>2024-04-21 02:18:22 +0200
committerPierre Ossman <ossman@cendio.se>2024-06-24 14:22:35 +0200
commit12b3f4021641537b90727b23d42de5dff59006cd (patch)
treed494cda8c019a53989099a44b05aca2e0a4fff8a /common/rfb/DecodeManager.cxx
parent4a71ac5bb79e3cd53499255f231c490fc9a5627b (diff)
downloadtigervnc-12b3f4021641537b90727b23d42de5dff59006cd.tar.gz
tigervnc-12b3f4021641537b90727b23d42de5dff59006cd.zip
Avoid shadowing variables
It's a source of confusion and possibly bugs to reuse the same variable name for multiple things.
Diffstat (limited to 'common/rfb/DecodeManager.cxx')
-rw-r--r--common/rfb/DecodeManager.cxx11
1 files changed, 4 insertions, 7 deletions
diff --git a/common/rfb/DecodeManager.cxx b/common/rfb/DecodeManager.cxx
index 63ab987d..ef415886 100644
--- a/common/rfb/DecodeManager.cxx
+++ b/common/rfb/DecodeManager.cxx
@@ -40,8 +40,8 @@ using namespace rfb;
static LogWriter vlog("DecodeManager");
-DecodeManager::DecodeManager(CConnection *conn) :
- conn(conn), threadException(nullptr)
+DecodeManager::DecodeManager(CConnection *conn_) :
+ conn(conn_), threadException(nullptr)
{
size_t cpuCount;
@@ -268,12 +268,9 @@ void DecodeManager::throwThreadException()
throw e;
}
-DecodeManager::DecodeThread::DecodeThread(DecodeManager* manager)
+DecodeManager::DecodeThread::DecodeThread(DecodeManager* manager_)
+ : manager(manager_), stopRequested(false)
{
- this->manager = manager;
-
- stopRequested = false;
-
start();
}