| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
This is a generic thing, not specific to the FLTK viewer. It belongs in
the core code.
|
|
|
|
|
| |
You need to activate the feature by setting supportsCursorPosition, so
there is no point in forcing everyone to implement the handler.
|
|
|
|
|
|
| |
We already had a field in the ServerParams structure, but we never
actually stored anything in it. Let's fix that so the cursor behaves
like other state we get from the server.
|
|
|
|
| |
These have never been used for anything and just clutter up the API.
|
|
|
|
|
|
| |
It's a bit confusing that some handling is done in
CMsgHandler/SMsgHandler, and some handling is done in
CConnection/SConnection.
|
|
|
|
|
| |
Only override the actively used values, not the user values that are
stored and displayed in the options dialog.
|
|
|
|
|
| |
It's just string helper functions here, so let's get rid of the
catch-all name for this module.
|
|
|
|
|
|
|
|
| |
They weren't that well used, and were mostly just confusing special
functions anyway.
Allows us to move away from generic and ambigious headers such as
"util".
|
|
|
|
|
|
|
| |
Make it clearer what is protocol handling and what is just general
plumbing.
This is one step of several.
|
|
|
|
|
|
|
| |
Make it clearer what is protocol handling and what is just general
plumbing.
This is one step of several.
|
|
|
|
|
|
|
| |
Make it clearer what is protocol handling and what is just general
plumbing.
This is one step of several.
|
|
|
|
|
|
|
|
| |
Try to keep the code more compact for the simple things where the type
should be obvious from the context. Helps us avoid line wrapping.
Also remove explicit conversions to Region where the compiler is able to
figure it out by itself, again to reduce line length.
|
|
|
|
|
| |
Make compile times faster by reducing the number of headers included in
other headers.
|
|
|
|
|
|
|
| |
These are not needed since the cleanup in 6ea58ba.
At the same time, move the error logging for a failed SetDesktopSize to
the base CConnection class as it is a generic thing.
|
|\ |
|
| |
| |
| |
| |
| |
| | |
This is a general thing so move it in to the core library instead,
letting vncviewer focus on just translation of system events to VNC
ones.
|
| | |
|
|\ \ |
|
| |/
| |
| |
| | |
The reason for this is to keep a consistency through out the project.
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| | |
This commit implements the pseudo-encoding ExtendedMouseButtons which
makes it possible to use the back/forward mouse buttons.
This commit contains work originally done by
PixelSmith <manny33@frontbuffer.com>.
|
| |
| |
| |
| |
| | |
This makes things more consistent since we mix with the standard library
exceptions so often.
|
| |
| |
| |
| | |
Make it easier to identify communication issues.
|
| |
| |
| |
| |
| | |
Use the more specific already included exception classes for common
errors to keep things more understandable.
|
| |
| |
| |
| |
| | |
Make sure our exceptions are part of the standard exception class
hierarchy.
|
| |
| |
| |
| | |
Harmonize with the standard C++ exceptions.
|
|/
|
|
|
| |
In preparation for using the built in C++ exception classes, which do
not accept a format string.
|
|
|
|
|
|
|
|
| |
This prefix often just added noise, and could sometimes be added
multiple times. It's better that user interface catch the specific
exception type and give a more descriptive presentation to the user.
This is partially a revert of 1922550.
|
|
|
|
|
| |
It's a source of confusion and possibly bugs to reuse the same variable
name for multiple things.
|
|
|
|
|
| |
Let's avoid reimplementing something basic that's available in the
standard library. It also makes the code easier to read.
|
|
|
|
|
| |
It's more readable than 0, and a bit safer than NULL, so let's try to
follow modern norms.
|
|
|
|
|
|
|
|
|
| |
This is mainly a copy of XKeysymToString() from libX11. We've also added
a wrapper that still gives a string, even if there is no name for the
requested keysym.
This grows the binaries a bit, but not with any extreme amount so is
hopefully worth it to get better debug logging.
|
|
|
|
|
|
| |
We should handle this in the low-level protocol code as much as possible
to avoid mistakes. This way the rest of the code can assume that strings
are always UTF-8 with \n line endings.
|
|
|
|
|
| |
These will always be byte streams at heart, so let's try to keep them
with a proper type. Should make it clearer how they will be used.
|
|
|
|
|
| |
It is much more natural than custom methods for this very common
operation.
|
|
|
|
|
| |
Avoids a bit of complexity by delegating that handling to a string
object.
|
|
|
|
|
| |
Let's use a more common type instead of something homegrown. Should be
more familiar to new developers.
|
|
|
|
|
|
|
|
| |
It's more standard and familiar than our custom CharArray type, and it
still gives us automatic freeing of the buffer.
We could probably have used std::unique_ptr instead, but we are
currently targeting older compilers where C++11 isn't standard yet.
|
|
|
|
|
|
| |
We mostly use classical C strings, but the memory management around them
can get confusing and error prone. Let's use std::string for the cases
where we need to return a newly allocated string.
|
|
|
|
|
| |
Avoid having our own custom stuff and instead use the modern, standard
types, for familiarity.
|
|
|
|
|
| |
This allows us to separate accidentally unused, from explicitly unused
parameters, which allows us to turn on such checks in the compiler.
|
|
|
|
| |
The flags should always be empty anyway.
|
|
|
|
|
|
| |
We don't want any stray exceptions as we are cleaning up, so handle any
still pending decoder errors by just logging them. We are already
shutting down so there is no need to abort the connection here.
|
|
|
|
|
| |
Otherwise we can get crashes on NULL dereference. This should only
happen on reverse connections where we don't have a server address.
|
|
|
|
|
|
| |
The generally recommended way is to include it from source files, not
headers. We had a mix of both. Let's try to be consistent and follow the
recommended way.
|
|
|
|
|
|
|
|
| |
This change makes it possible for re-synchronizing the remote cursor on
the vncviewer when in fullscreen mode. This is done by locally moving
the cursor position to what the server thinks it should be.
Now SDL games should work!
|
|\ |
|
| | |
|
| |
| |
| |
| |
| | |
The peer expects a response, so we should also be able to respond that
there is no clipboard data currently available.
|
| |
| |
| |
| |
| |
| | |
The extended clipboard protocol has the ability for the peer to request
things to be sent automatically, without a request message. Make sure we
honor such settings.
|