| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
An empty shell field in the password file is valid, although not common.
Use /bin/sh in this case, as documented in the passwd(5) man page, since
the vncserver script requires a non-empty SHELL environment variable.
Fixes issue #1786.
Signed-off-by: Carlos Santos <casantos@redhat.com>
|
|
|
|
|
|
|
| |
Avoid duplicating this complexity in too many places.
At the same time make the interface more identical to regular mkdir(),
for familiarity.
|
|
|
|
|
| |
This is only needed because of an historical type change of the legacy
directory, so avoid doing it anywhere else.
|
|
|
|
|
|
|
|
|
| |
The syslog file descriptor will be closed when we are cleaning up in
preparation for running the vncserver script, so we need to explicitly
reopen things in case we need to log errors.
At the same time, try to be polite and explicitly close the log when
appropriate.
|
|
|
|
|
| |
E.g. pam_env.so might modify this variable, so we should see what we get
out of PAM when building a log file path.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Option is -D, which is what sshd uses for the same option.
Also add description of the new option to the vncsession
man page.
Tested on Void Linux using the new option, also tested on
Fedora without using the new option.
Resolves #1649
|
|
|
|
|
| |
These types caused an incorrect signed/unsigned behaviour, so let's make
sure we use the appropriate type.
|
|
|
|
| |
gcc can get upset if they aren't in this order.
|
|
|
|
|
| |
This allows us to separate accidentally unused, from explicitly unused
parameters, which allows us to turn on such checks in the compiler.
|
|
|
|
|
|
|
| |
We need to get to the point of starting the session script before we
consider things a success. So this can fail in many different ways, not
just the daemonization. Adjust the error message to something more
generic to reflect this.
|
| |
|
|
|
|
|
|
| |
Some operating systems such as FreeBSD don't define a HOST_NAME_MAX
macro. The portable approach to determine the real host name limit is
calling sysconf(_SC_HOST_NAME_MAX) so do that instead.
|
|
|
|
|
| |
stderr has been redirected to /dev/null so all logging needs to go to
syslog.
|
|
|
|
|
| |
This is what display managers do, so it is expected by many
environments.
|
|
|
|
|
|
| |
We terminated the child instead of the parent after fork().
Reported by Jan Grulich from Red Hat.
|
| |
|
|
|
|
|
| |
Not sure why this got in there, but it is incorrect as it results in
creating files with too liberal permissions.
|
|
|
|
|
| |
This makes our builds directly compatible with most distributions
without packagers/users having to specify extra flags.
|
|
This sets up a more correct session as there are key tasks that
need to be performed by PAM. E.g. systemd will allocate cgroups
and start base services.
In order to easily handle this as a system service the mapping of
displays is now done via a configuration file.
|