1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
|
/*
* Copyright (C) 2004 Red Hat Inc.
* Copyright (C) 2005 Martin Koegler
* Copyright (C) 2010 TigerVNC Team
* Copyright (C) 2010 m-privacy GmbH
* Copyright (C) 2012-2021 Pierre Ossman for Cendio AB
*
* This is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This software is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this software; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307,
* USA.
*/
#ifdef HAVE_CONFIG_H
#include <config.h>
#endif
#ifndef HAVE_GNUTLS
#error "This header should not be compiled without HAVE_GNUTLS defined"
#endif
#include <stdlib.h>
#ifndef WIN32
#include <unistd.h>
#endif
#include <rfb/CSecurityTLS.h>
#include <rfb/CConnection.h>
#include <rfb/LogWriter.h>
#include <rfb/Exception.h>
#include <rfb/UserMsgBox.h>
#include <rfb/util.h>
#include <rdr/TLSInStream.h>
#include <rdr/TLSOutStream.h>
#include <os/os.h>
#include <gnutls/x509.h>
/*
* GNUTLS doesn't correctly export gnutls_free symbol which is
* a function pointer. Linking with Visual Studio 2008 Express will
* fail when you call gnutls_free().
*/
#if WIN32
#undef gnutls_free
#define gnutls_free free
#endif
using namespace rfb;
static const char* configdirfn(const char* fn);
StringParameter CSecurityTLS::X509CA("X509CA", "X509 CA certificate",
configdirfn("x509_ca.pem"),
ConfViewer);
StringParameter CSecurityTLS::X509CRL("X509CRL", "X509 CRL file",
configdirfn("x509_crl.pem"),
ConfViewer);
static LogWriter vlog("TLS");
static const char* configdirfn(const char* fn)
{
static char full_path[PATH_MAX];
const char* configdir;
configdir = os::getvncconfigdir();
if (configdir == nullptr)
return "";
snprintf(full_path, sizeof(full_path), "%s/%s", configdir, fn);
return full_path;
}
CSecurityTLS::CSecurityTLS(CConnection* cc_, bool _anon)
: CSecurity(cc_), session(nullptr),
anon_cred(nullptr), cert_cred(nullptr),
anon(_anon), tlsis(nullptr), tlsos(nullptr),
rawis(nullptr), rawos(nullptr)
{
if (gnutls_global_init() != GNUTLS_E_SUCCESS)
throw AuthFailureException("gnutls_global_init failed");
}
void CSecurityTLS::shutdown()
{
if (session) {
int ret;
// FIXME: We can't currently wait for the response, so we only send
// our close and hope for the best
ret = gnutls_bye(session, GNUTLS_SHUT_WR);
if ((ret != GNUTLS_E_SUCCESS) && (ret != GNUTLS_E_INVALID_SESSION))
vlog.error("TLS shutdown failed: %s", gnutls_strerror(ret));
}
if (anon_cred) {
gnutls_anon_free_client_credentials(anon_cred);
anon_cred = nullptr;
}
if (cert_cred) {
gnutls_certificate_free_credentials(cert_cred);
cert_cred = nullptr;
}
if (rawis && rawos) {
cc->setStreams(rawis, rawos);
rawis = nullptr;
rawos = nullptr;
}
if (tlsis) {
delete tlsis;
tlsis = nullptr;
}
if (tlsos) {
delete tlsos;
tlsos = nullptr;
}
if (session) {
gnutls_deinit(session);
session = nullptr;
}
}
CSecurityTLS::~CSecurityTLS()
{
shutdown();
gnutls_global_deinit();
}
bool CSecurityTLS::processMsg()
{
rdr::InStream* is = cc->getInStream();
rdr::OutStream* os = cc->getOutStream();
client = cc;
if (!session) {
if (!is->hasData(1))
return false;
if (is->readU8() == 0)
throw AuthFailureException("Server failed to initialize TLS session");
if (gnutls_init(&session, GNUTLS_CLIENT) != GNUTLS_E_SUCCESS)
throw AuthFailureException("gnutls_init failed");
if (gnutls_set_default_priority(session) != GNUTLS_E_SUCCESS)
throw AuthFailureException("gnutls_set_default_priority failed");
setParam();
// Create these early as they set up the push/pull functions
// for GnuTLS
tlsis = new rdr::TLSInStream(is, session);
tlsos = new rdr::TLSOutStream(os, session);
rawis = is;
rawos = os;
}
int err;
err = gnutls_handshake(session);
if (err != GNUTLS_E_SUCCESS) {
if (!gnutls_error_is_fatal(err)) {
vlog.debug("Deferring completion of TLS handshake: %s", gnutls_strerror(err));
return false;
}
vlog.error("TLS Handshake failed: %s\n", gnutls_strerror (err));
shutdown();
throw AuthFailureException("TLS Handshake failed");
}
vlog.debug("TLS handshake completed with %s",
gnutls_session_get_desc(session));
checkSession();
cc->setStreams(tlsis, tlsos);
return true;
}
void CSecurityTLS::setParam()
{
static const char kx_anon_priority[] = ":+ANON-ECDH:+ANON-DH";
int ret;
// Custom priority string specified?
if (strcmp(Security::GnuTLSPriority, "") != 0) {
char *prio;
const char *err;
prio = (char*)malloc(strlen(Security::GnuTLSPriority) +
strlen(kx_anon_priority) + 1);
if (prio == nullptr)
throw AuthFailureException("Not enough memory for GnuTLS priority string");
strcpy(prio, Security::GnuTLSPriority);
if (anon)
strcat(prio, kx_anon_priority);
ret = gnutls_priority_set_direct(session, prio, &err);
free(prio);
if (ret != GNUTLS_E_SUCCESS) {
if (ret == GNUTLS_E_INVALID_REQUEST)
vlog.error("GnuTLS priority syntax error at: %s", err);
throw AuthFailureException("gnutls_set_priority_direct failed");
}
} else if (anon) {
const char *err;
#if GNUTLS_VERSION_NUMBER >= 0x030603
// gnutls_set_default_priority_appends() expects a normal priority string that
// doesn't start with ":".
ret = gnutls_set_default_priority_append(session, kx_anon_priority + 1, &err, 0);
if (ret != GNUTLS_E_SUCCESS) {
if (ret == GNUTLS_E_INVALID_REQUEST)
vlog.error("GnuTLS priority syntax error at: %s", err);
throw AuthFailureException("gnutls_set_default_priority_append failed");
}
#else
// We don't know what the system default priority is, so we guess
// it's what upstream GnuTLS has
static const char gnutls_default_priority[] = "NORMAL";
char *prio;
prio = (char*)malloc(strlen(gnutls_default_priority) +
strlen(kx_anon_priority) + 1);
if (prio == nullptr)
throw AuthFailureException("Not enough memory for GnuTLS priority string");
strcpy(prio, gnutls_default_priority);
strcat(prio, kx_anon_priority);
ret = gnutls_priority_set_direct(session, prio, &err);
free(prio);
if (ret != GNUTLS_E_SUCCESS) {
if (ret == GNUTLS_E_INVALID_REQUEST)
vlog.error("GnuTLS priority syntax error at: %s", err);
throw AuthFailureException("gnutls_set_priority_direct failed");
}
#endif
}
if (anon) {
if (gnutls_anon_allocate_client_credentials(&anon_cred) != GNUTLS_E_SUCCESS)
throw AuthFailureException("gnutls_anon_allocate_client_credentials failed");
if (gnutls_credentials_set(session, GNUTLS_CRD_ANON, anon_cred) != GNUTLS_E_SUCCESS)
throw AuthFailureException("gnutls_credentials_set failed");
vlog.debug("Anonymous session has been set");
} else {
if (gnutls_certificate_allocate_credentials(&cert_cred) != GNUTLS_E_SUCCESS)
throw AuthFailureException("gnutls_certificate_allocate_credentials failed");
if (gnutls_certificate_set_x509_system_trust(cert_cred) < 1)
vlog.error("Could not load system certificate trust store");
if (gnutls_certificate_set_x509_trust_file(cert_cred, X509CA, GNUTLS_X509_FMT_PEM) < 0)
vlog.error("Could not load user specified certificate authority");
if (gnutls_certificate_set_x509_crl_file(cert_cred, X509CRL, GNUTLS_X509_FMT_PEM) < 0)
vlog.error("Could not load user specified certificate revocation list");
if (gnutls_credentials_set(session, GNUTLS_CRD_CERTIFICATE, cert_cred) != GNUTLS_E_SUCCESS)
throw AuthFailureException("gnutls_credentials_set failed");
if (gnutls_server_name_set(session, GNUTLS_NAME_DNS,
client->getServerName(),
strlen(client->getServerName())) != GNUTLS_E_SUCCESS)
vlog.error("Failed to configure the server name for TLS handshake");
vlog.debug("X509 session has been set");
}
}
void CSecurityTLS::checkSession()
{
const unsigned allowed_errors = GNUTLS_CERT_INVALID |
GNUTLS_CERT_SIGNER_NOT_FOUND |
GNUTLS_CERT_SIGNER_NOT_CA |
GNUTLS_CERT_NOT_ACTIVATED |
GNUTLS_CERT_EXPIRED |
GNUTLS_CERT_INSECURE_ALGORITHM;
unsigned int status;
const gnutls_datum_t *cert_list;
unsigned int cert_list_size = 0;
int err;
bool hostname_match;
const char *hostsDir;
gnutls_datum_t info;
size_t len;
if (anon)
return;
if (gnutls_certificate_type_get(session) != GNUTLS_CRT_X509)
throw AuthFailureException("unsupported certificate type");
err = gnutls_certificate_verify_peers2(session, &status);
if (err != 0) {
vlog.error("server certificate verification failed: %s", gnutls_strerror(err));
throw AuthFailureException("server certificate verification failed");
}
if (status != 0) {
gnutls_datum_t status_str;
unsigned int fatal_status;
fatal_status = status & (~allowed_errors);
if (fatal_status != 0) {
std::string error;
if (gnutls_certificate_verification_status_print(fatal_status,
GNUTLS_CRT_X509,
&status_str,
0) < 0)
throw Exception("Failed to get certificate error description");
error = format("Invalid server certificate: %s", status_str.data);
gnutls_free(status_str.data);
throw AuthFailureException(error.c_str());
}
if (gnutls_certificate_verification_status_print(status,
GNUTLS_CRT_X509,
&status_str,
0) < 0)
throw Exception("Failed to get certificate error description");
vlog.info("Server certificate errors: %s", status_str.data);
gnutls_free(status_str.data);
}
/* Process overridable errors later */
cert_list = gnutls_certificate_get_peers(session, &cert_list_size);
if (!cert_list_size)
throw AuthFailureException("empty certificate chain");
/* Process only server's certificate, not issuer's certificate */
gnutls_x509_crt_t crt;
gnutls_x509_crt_init(&crt);
if (gnutls_x509_crt_import(crt, &cert_list[0], GNUTLS_X509_FMT_DER) < 0)
throw AuthFailureException("decoding of certificate failed");
if (gnutls_x509_crt_check_hostname(crt, client->getServerName()) == 0) {
vlog.info("Server certificate doesn't match given server name");
hostname_match = false;
} else {
hostname_match = true;
}
if ((status == 0) && hostname_match) {
/* Everything is fine (hostname + verification) */
gnutls_x509_crt_deinit(crt);
return;
}
/* Certificate has some user overridable problems, so TOFU time */
hostsDir = os::getvncstatedir();
if (hostsDir == nullptr) {
throw AuthFailureException("Could not obtain VNC state directory "
"path for known hosts storage");
}
std::string dbPath;
dbPath = (std::string)hostsDir + "/x509_known_hosts";
err = gnutls_verify_stored_pubkey(dbPath.c_str(), nullptr,
client->getServerName(), nullptr,
GNUTLS_CRT_X509, &cert_list[0], 0);
/* Previously known? */
if (err == GNUTLS_E_SUCCESS) {
vlog.info("Server certificate found in known hosts file");
gnutls_x509_crt_deinit(crt);
return;
}
if ((err != GNUTLS_E_NO_CERTIFICATE_FOUND) &&
(err != GNUTLS_E_CERTIFICATE_KEY_MISMATCH)) {
throw AuthFailureException("Could not load known hosts database");
}
if (gnutls_x509_crt_print(crt, GNUTLS_CRT_PRINT_ONELINE, &info))
throw AuthFailureException("Could not find certificate to display");
len = strlen((char*)info.data);
for (size_t i = 0; i < len - 1; i++) {
if (info.data[i] == ',' && info.data[i + 1] == ' ')
info.data[i] = '\n';
}
/* New host */
if (err == GNUTLS_E_NO_CERTIFICATE_FOUND) {
std::string text;
vlog.info("Server host not previously known");
vlog.info("%s", info.data);
if (status & (GNUTLS_CERT_INVALID |
GNUTLS_CERT_SIGNER_NOT_FOUND |
GNUTLS_CERT_SIGNER_NOT_CA)) {
text = format("This certificate has been signed by an unknown "
"authority:\n"
"\n"
"%s\n"
"\n"
"Someone could be trying to impersonate the site "
"and you should not continue.\n"
"\n"
"Do you want to make an exception for this "
"server?", info.data);
if (!msg->showMsgBox(UserMsgBox::M_YESNO,
"Unknown certificate issuer",
text.c_str()))
throw AuthFailureException("Unknown certificate issuer");
status &= ~(GNUTLS_CERT_INVALID |
GNUTLS_CERT_SIGNER_NOT_FOUND |
GNUTLS_CERT_SIGNER_NOT_CA);
}
if (status & GNUTLS_CERT_NOT_ACTIVATED) {
text = format("This certificate is not yet valid:\n"
"\n"
"%s\n"
"\n"
"Someone could be trying to impersonate the site "
"and you should not continue.\n"
"\n"
"Do you want to make an exception for this "
"server?", info.data);
if (!msg->showMsgBox(UserMsgBox::M_YESNO,
"Certificate is not yet valid",
text.c_str()))
throw AuthFailureException("Certificate is not yet valid");
status &= ~GNUTLS_CERT_NOT_ACTIVATED;
}
if (status & GNUTLS_CERT_EXPIRED) {
text = format("This certificate has expired:\n"
"\n"
"%s\n"
"\n"
"Someone could be trying to impersonate the site "
"and you should not continue.\n"
"\n"
"Do you want to make an exception for this "
"server?", info.data);
if (!msg->showMsgBox(UserMsgBox::M_YESNO,
"Expired certificate",
text.c_str()))
throw AuthFailureException("Expired certificate");
status &= ~GNUTLS_CERT_EXPIRED;
}
if (status & GNUTLS_CERT_INSECURE_ALGORITHM) {
text = format("This certificate uses an insecure algorithm:\n"
"\n"
"%s\n"
"\n"
"Someone could be trying to impersonate the site "
"and you should not continue.\n"
"\n"
"Do you want to make an exception for this "
"server?", info.data);
if (!msg->showMsgBox(UserMsgBox::M_YESNO,
"Insecure certificate algorithm",
text.c_str()))
throw AuthFailureException("Insecure certificate algorithm");
status &= ~GNUTLS_CERT_INSECURE_ALGORITHM;
}
if (status != 0) {
vlog.error("Unhandled certificate problems: 0x%x", status);
throw AuthFailureException("Unhandled certificate problems");
}
if (!hostname_match) {
text = format("The specified hostname \"%s\" does not match the "
"certificate provided by the server:\n"
"\n"
"%s\n"
"\n"
"Someone could be trying to impersonate the site "
"and you should not continue.\n"
"\n"
"Do you want to make an exception for this "
"server?", client->getServerName(), info.data);
if (!msg->showMsgBox(UserMsgBox::M_YESNO,
"Certificate hostname mismatch",
text.c_str()))
throw AuthFailureException("Certificate hostname mismatch");
}
} else if (err == GNUTLS_E_CERTIFICATE_KEY_MISMATCH) {
std::string text;
vlog.info("Server host key mismatch");
vlog.info("%s", info.data);
if (status & (GNUTLS_CERT_INVALID |
GNUTLS_CERT_SIGNER_NOT_FOUND |
GNUTLS_CERT_SIGNER_NOT_CA)) {
text = format("This host is previously known with a different "
"certificate, and the new certificate has been "
"signed by an unknown authority:\n"
"\n"
"%s\n"
"\n"
"Someone could be trying to impersonate the site "
"and you should not continue.\n"
"\n"
"Do you want to make an exception for this "
"server?", info.data);
if (!msg->showMsgBox(UserMsgBox::M_YESNO,
"Unexpected server certificate",
text.c_str()))
throw AuthFailureException("Unexpected server certificate");
status &= ~(GNUTLS_CERT_INVALID |
GNUTLS_CERT_SIGNER_NOT_FOUND |
GNUTLS_CERT_SIGNER_NOT_CA);
}
if (status & GNUTLS_CERT_NOT_ACTIVATED) {
text = format("This host is previously known with a different "
"certificate, and the new certificate is not yet "
"valid:\n"
"\n"
"%s\n"
"\n"
"Someone could be trying to impersonate the site "
"and you should not continue.\n"
"\n"
"Do you want to make an exception for this "
"server?", info.data);
if (!msg->showMsgBox(UserMsgBox::M_YESNO,
"Unexpected server certificate",
text.c_str()))
throw AuthFailureException("Unexpected server certificate");
status &= ~GNUTLS_CERT_NOT_ACTIVATED;
}
if (status & GNUTLS_CERT_EXPIRED) {
text = format("This host is previously known with a different "
"certificate, and the new certificate has "
"expired:\n"
"\n"
"%s\n"
"\n"
"Someone could be trying to impersonate the site "
"and you should not continue.\n"
"\n"
"Do you want to make an exception for this "
"server?", info.data);
if (!msg->showMsgBox(UserMsgBox::M_YESNO,
"Unexpected server certificate",
text.c_str()))
throw AuthFailureException("Unexpected server certificate");
status &= ~GNUTLS_CERT_EXPIRED;
}
if (status & GNUTLS_CERT_INSECURE_ALGORITHM) {
text = format("This host is previously known with a different "
"certificate, and the new certificate uses an "
"insecure algorithm:\n"
"\n"
"%s\n"
"\n"
"Someone could be trying to impersonate the site "
"and you should not continue.\n"
"\n"
"Do you want to make an exception for this "
"server?", info.data);
if (!msg->showMsgBox(UserMsgBox::M_YESNO,
"Unexpected server certificate",
text.c_str()))
throw AuthFailureException("Unexpected server certificate");
status &= ~GNUTLS_CERT_INSECURE_ALGORITHM;
}
if (status != 0) {
vlog.error("Unhandled certificate problems: 0x%x", status);
throw AuthFailureException("Unhandled certificate problems");
}
if (!hostname_match) {
text = format("This host is previously known with a different "
"certificate, and the specified hostname \"%s\" "
"does not match the new certificate provided by "
"the server:\n"
"\n"
"%s\n"
"\n"
"Someone could be trying to impersonate the site "
"and you should not continue.\n"
"\n"
"Do you want to make an exception for this "
"server?", client->getServerName(), info.data);
if (!msg->showMsgBox(UserMsgBox::M_YESNO,
"Unexpected server certificate",
text.c_str()))
throw AuthFailureException("Unexpected server certificate");
}
}
if (gnutls_store_pubkey(dbPath.c_str(), nullptr,
client->getServerName(), nullptr,
GNUTLS_CRT_X509, &cert_list[0], 0, 0))
vlog.error("Failed to store server certificate to known hosts database");
vlog.info("Exception added for server host");
gnutls_x509_crt_deinit(crt);
gnutls_free(info.data);
}
|