diff options
| author | Zhe Sun <31067185+ZheSun88@users.noreply.github.com> | 2021-10-15 13:10:25 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-10-15 13:10:25 +0300 |
| commit | 233dba1288da5c115a7065999d2ce81d70aee1f8 (patch) | |
| tree | 17dca86717c9514721b5610f5c9c126fcc4e6136 | |
| parent | 2e47138a78c4552e6e7028614fffce5ea4a12360 (diff) | |
| download | vaadin-framework-233dba1288da5c115a7065999d2ce81d70aee1f8.tar.gz vaadin-framework-233dba1288da5c115a7065999d2ce81d70aee1f8.zip | |
update the failed build checking (#12439)
| -rw-r--r-- | scripts/GenerateBuildTestAndStagingReport.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/scripts/GenerateBuildTestAndStagingReport.py b/scripts/GenerateBuildTestAndStagingReport.py index a108a36f72..06e22ca5b9 100644 --- a/scripts/GenerateBuildTestAndStagingReport.py +++ b/scripts/GenerateBuildTestAndStagingReport.py @@ -47,7 +47,9 @@ def getTestStatusHtml(): return createTableRow(traffic_light.format(color="black"), "Test status: unable to retrieve status of tests") else: test_failures_json = test_failures_request.json() - if test_failures_json["count"] == 0: + # nowadays the responds doesn't contain count keyword when the build is successful + # while count word can be found when build fails + if "count" not in test_failures_json: return createTableRow(traffic_light.format(color="green"), "Test status: all tests passing") else: return createTableRow(traffic_light.format(color="red"), "Test status: there are " + str(test_failures_json["count"]) + " failing tests, <a href={}>check the build report</a>".format(buildResultUrl)) |