Merged changes to 6.4 (FindBugs results, #5111, label and javadoc corrections)

svn changeset:13471/svn branch:6.4

25 files changed, 72 insertions, 65 deletions

diff --git a/src/com/vaadin/event/dd/DropTarget.java b/src/com/vaadin/event/dd/DropTarget.java
index fcb9670f6f..0d88bf2893 100644
--- a/src/com/vaadin/event/dd/DropTarget.java
+++ b/src/com/vaadin/event/dd/DropTarget.java
@@ -24,7 +24,7 @@ public interface DropTarget extends Component {
 
     /**
      * Called before the {@link DragAndDropEvent} is passed to
-     * {@link DropHandler}. Implementation may for exmaple translate the drop
+     * {@link DropHandler}. Implementation may for example translate the drop
      * target details provided by the client side (drop target) to meaningful
      * server side values. If null is returned the terminal implementation will
      * automatically create a {@link TargetDetails} with raw client side data.
diff --git a/src/com/vaadin/terminal/gwt/client/DateTimeService.java b/src/com/vaadin/terminal/gwt/client/DateTimeService.java
index 7bc8e8eba4..0693994a9e 100644
--- a/src/com/vaadin/terminal/gwt/client/DateTimeService.java
+++ b/src/com/vaadin/terminal/gwt/client/DateTimeService.java
@@ -195,27 +195,27 @@ public class DateTimeService {
         if (resolution == RESOLUTION_YEAR) {

             return (start <= target && end >= target);

         }

-        start += s.getMonth() * 100000000;

-        end += e.getMonth() * 100000000;

-        target += date.getMonth() * 100000000;

+        start += s.getMonth() * 100000000l;

+        end += e.getMonth() * 100000000l;

+        target += date.getMonth() * 100000000l;

         if (resolution == RESOLUTION_MONTH) {

             return (start <= target && end >= target);

         }

-        start += s.getDate() * 1000000;

-        end += e.getDate() * 1000000;

-        target += date.getDate() * 1000000;

+        start += s.getDate() * 1000000l;

+        end += e.getDate() * 1000000l;

+        target += date.getDate() * 1000000l;

         if (resolution == RESOLUTION_DAY) {

             return (start <= target && end >= target);

         }

-        start += s.getHours() * 10000;

-        end += e.getHours() * 10000;

-        target += date.getHours() * 10000;

+        start += s.getHours() * 10000l;

+        end += e.getHours() * 10000l;

+        target += date.getHours() * 10000l;

         if (resolution == RESOLUTION_HOUR) {

             return (start <= target && end >= target);

         }

-        start += s.getMinutes() * 100;

-        end += e.getMinutes() * 100;

-        target += date.getMinutes() * 100;

+        start += s.getMinutes() * 100l;

+        end += e.getMinutes() * 100l;

+        target += date.getMinutes() * 100l;

         if (resolution == RESOLUTION_MIN) {

             return (start <= target && end >= target);

         }

diff --git a/src/com/vaadin/terminal/gwt/client/RenderInformation.java b/src/com/vaadin/terminal/gwt/client/RenderInformation.java
index a91c0d7e24..6fb92c63e4 100644
--- a/src/com/vaadin/terminal/gwt/client/RenderInformation.java
+++ b/src/com/vaadin/terminal/gwt/client/RenderInformation.java
@@ -3,7 +3,7 @@
  */
 package com.vaadin.terminal.gwt.client;

 

-import com.google.gwt.user.client.Element;

+import com.google.gwt.user.client.Element;
 

 /**

  * Contains size information about a rendered container and its content area.

@@ -90,9 +90,17 @@ public class RenderInformation {
         private int width, height;

 

         @Override

-        public boolean equals(Object obj) {

+        public boolean equals(Object obj) {
+            if (!(obj instanceof Size)) {
+                return false;
+            }

             Size other = (Size) obj;

             return other.width == width && other.height == height;

+        }
+
+        @Override
+        public int hashCode() {
+            return (width << 8) | height;
         }

 

         public Size() {

diff --git a/src/com/vaadin/terminal/gwt/client/VDebugConsole.java b/src/com/vaadin/terminal/gwt/client/VDebugConsole.java
index dae9bdfa88..427cd097b1 100755
--- a/src/com/vaadin/terminal/gwt/client/VDebugConsole.java
+++ b/src/com/vaadin/terminal/gwt/client/VDebugConsole.java
@@ -365,7 +365,7 @@ public final class VDebugConsole extends VOverlay implements Console {
             str = msg.toString();
         }
         panel.add((new Label(str)));
-        consoleLog(msg.toString());
+        consoleLog(str);
     }
 
     /*
diff --git a/src/com/vaadin/terminal/gwt/client/ui/VMarginInfo.java b/src/com/vaadin/terminal/gwt/client/ui/VMarginInfo.java
index 961624dcd7..2fb047c007 100644
--- a/src/com/vaadin/terminal/gwt/client/ui/VMarginInfo.java
+++ b/src/com/vaadin/terminal/gwt/client/ui/VMarginInfo.java
@@ -73,4 +73,9 @@ public class VMarginInfo implements Serializable {
         return ((VMarginInfo) obj).bitMask == bitMask;
     }
 
+    @Override
+    public int hashCode() {
+        return bitMask;
+    }
+
 }
diff --git a/src/com/vaadin/terminal/gwt/client/ui/VPanel.java b/src/com/vaadin/terminal/gwt/client/ui/VPanel.java
index d41a739655..dfceb55416 100644
--- a/src/com/vaadin/terminal/gwt/client/ui/VPanel.java
+++ b/src/com/vaadin/terminal/gwt/client/ui/VPanel.java
@@ -394,7 +394,7 @@ public class VPanel extends SimplePanel implements Container {
     public void setHeight(String height) {
         this.height = height;
         super.setHeight(height);
-        if (height != null && height != "") {
+        if (height != null && !"".equals(height)) {
             final int targetHeight = getOffsetHeight();
             int containerHeight = targetHeight
                     - captionNode.getParentElement().getOffsetHeight()
diff --git a/src/com/vaadin/terminal/gwt/server/DragAndDropService.java b/src/com/vaadin/terminal/gwt/server/DragAndDropService.java
index 9f8e3ba17e..4bc8d386b4 100644
--- a/src/com/vaadin/terminal/gwt/server/DragAndDropService.java
+++ b/src/com/vaadin/terminal/gwt/server/DragAndDropService.java
@@ -47,10 +47,7 @@ public class DragAndDropService implements VariableOwner {
                     + " must implement DropTarget");
             return;
         }
-        if (owner == null) {
-            System.err.println("DropHandler owner is null");
-            return;
-        }
+        // owner cannot be null here
 
         DropTarget dropTarget = (DropTarget) owner;
         lastVisitId = (Integer) variables.get("visitId");
diff --git a/src/com/vaadin/ui/AbstractField.java b/src/com/vaadin/ui/AbstractField.java
index f7d1ddd79e..8d02602aab 100644
--- a/src/com/vaadin/ui/AbstractField.java
+++ b/src/com/vaadin/ui/AbstractField.java
@@ -1232,7 +1232,7 @@ public abstract class AbstractField extends AbstractComponent implements Field,
     }
 
     public void removeShortcutListener(ShortcutListener shortcut) {
-        if (actionManager == null) {
+        if (actionManager != null) {
             actionManager.removeAction(shortcut);
         }
     }
diff --git a/src/com/vaadin/ui/Form.java b/src/com/vaadin/ui/Form.java
index 0929c05b68..901d96db21 100644
--- a/src/com/vaadin/ui/Form.java
+++ b/src/com/vaadin/ui/Form.java
@@ -1325,7 +1325,7 @@ public class Form extends AbstractField implements Item.Editor, Buffered, Item,
 
     public <T extends Action & com.vaadin.event.Action.Listener> void removeAction(
             T action) {
-        if (ownActionManager == null) {
+        if (ownActionManager != null) {
             ownActionManager.removeAction(action);
         }
     }
diff --git a/src/com/vaadin/ui/GridLayout.java b/src/com/vaadin/ui/GridLayout.java
index 18a602280b..b7e92402cc 100644
--- a/src/com/vaadin/ui/GridLayout.java
+++ b/src/com/vaadin/ui/GridLayout.java
@@ -572,7 +572,7 @@ public class GridLayout extends AbstractLayout implements
 
                             // Removes the cellUsed key as it has become
                             // obsolete
-                            cellUsed.remove(new Integer(curx));
+                            cellUsed.remove(Integer.valueOf(curx));
                         }
                     } else {
 
diff --git a/src/com/vaadin/ui/MenuBar.java b/src/com/vaadin/ui/MenuBar.java
index 036aa1b718..f53c7469ee 100644
--- a/src/com/vaadin/ui/MenuBar.java
+++ b/src/com/vaadin/ui/MenuBar.java
@@ -55,9 +55,6 @@ public class MenuBar extends AbstractComponent {
         // Superclass writes any common attributes in the paint target.
         super.paintContent(target);
 
-        // Stack for list iterators
-        Stack<Iterator<MenuItem>> iteratorStack = new Stack<Iterator<MenuItem>>();
-
         target.startTag("options");
 
         if (submenuIcon != null) {
diff --git a/src/com/vaadin/ui/Panel.java b/src/com/vaadin/ui/Panel.java
index d4fb66deb6..ce3e8bb582 100644
--- a/src/com/vaadin/ui/Panel.java
+++ b/src/com/vaadin/ui/Panel.java
@@ -501,7 +501,7 @@ public class Panel extends AbstractComponentContainer implements Scrollable,
 
     public <T extends Action & com.vaadin.event.Action.Listener> void removeAction(
             T action) {
-        if (actionManager == null) {
+        if (actionManager != null) {
             actionManager.removeAction(action);
         }
     }
diff --git a/src/com/vaadin/ui/Table.java b/src/com/vaadin/ui/Table.java
index 03f2bd27e2..e7323af06b 100644
--- a/src/com/vaadin/ui/Table.java
+++ b/src/com/vaadin/ui/Table.java
@@ -729,7 +729,7 @@ public class Table extends AbstractSelect implements Action.Container,
         if (width < 0) {
             columnWidths.remove(columnId);
         } else {
-            columnWidths.put(columnId, new Integer(width));
+            columnWidths.put(columnId, Integer.valueOf(width));
         }
     }
 
diff --git a/tests/src/com/vaadin/tests/StressComponentsInTable.java b/tests/src/com/vaadin/tests/StressComponentsInTable.java
index 6f04f5b731..7e072eabd7 100644
--- a/tests/src/com/vaadin/tests/StressComponentsInTable.java
+++ b/tests/src/com/vaadin/tests/StressComponentsInTable.java
@@ -39,9 +39,9 @@ public class StressComponentsInTable extends CustomComponent {
 

                 public void buttonClick(ClickEvent event) {

                     Button b = event.getButton();

-                    System.out.println(event.getButton().getCaption()

-                            + " click: " + (new Date()).toGMTString());

-                    System.out.println(event.getButton().getApplication());

+                    System.out.println(b.getCaption() + " click: "

+                            + (new Date()).toGMTString());

+                    System.out.println(b.getApplication());

 

                 }

             }));

diff --git a/tests/src/com/vaadin/tests/book/TableEditable.java b/tests/src/com/vaadin/tests/book/TableEditable.java
index 0beefba320..3e5dc0e613 100644
--- a/tests/src/com/vaadin/tests/book/TableEditable.java
+++ b/tests/src/com/vaadin/tests/book/TableEditable.java
@@ -36,9 +36,9 @@ public class TableEditable extends CustomComponent {
             calendar.add(Calendar.DAY_OF_YEAR, i);
 
             // Create the table row.
-            table.addItem(new Object[] { calendar.getTime(),
-                    new Boolean(false), "" }, new Integer(i)); // Item
-            // identifier
+            table.addItem(
+                    new Object[] { calendar.getTime(), Boolean.FALSE, "" },
+                    new Integer(i)); // Item identifier
         }
 
         table.setPageLength(8);
diff --git a/tests/src/com/vaadin/tests/components/button/Buttons.java b/tests/src/com/vaadin/tests/components/button/Buttons.java
index 0540a0dcde..1c5c35e237 100644
--- a/tests/src/com/vaadin/tests/components/button/Buttons.java
+++ b/tests/src/com/vaadin/tests/components/button/Buttons.java
@@ -100,9 +100,9 @@ public class Buttons extends ComponentTestCase<Button> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         readonly.setImmediate(true);
diff --git a/tests/src/com/vaadin/tests/components/combobox/Comboboxes.java b/tests/src/com/vaadin/tests/components/combobox/Comboboxes.java
index 39008f3db5..40a70fa92a 100644
--- a/tests/src/com/vaadin/tests/components/combobox/Comboboxes.java
+++ b/tests/src/com/vaadin/tests/components/combobox/Comboboxes.java
@@ -150,9 +150,9 @@ public class Comboboxes extends ComponentTestCase<ComboBox> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         readonly.setImmediate(true);
diff --git a/tests/src/com/vaadin/tests/components/label/LabelModes.java b/tests/src/com/vaadin/tests/components/label/LabelModes.java
index d7d426ec88..88ff296739 100644
--- a/tests/src/com/vaadin/tests/components/label/LabelModes.java
+++ b/tests/src/com/vaadin/tests/components/label/LabelModes.java
@@ -91,9 +91,9 @@ public class LabelModes extends ComponentTestCase<Label> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         readonly.setImmediate(true);
diff --git a/tests/src/com/vaadin/tests/components/label/Labels.java b/tests/src/com/vaadin/tests/components/label/Labels.java
index 64c61ba13c..7bc7722b35 100644
--- a/tests/src/com/vaadin/tests/components/label/Labels.java
+++ b/tests/src/com/vaadin/tests/components/label/Labels.java
@@ -102,9 +102,9 @@ public class Labels extends ComponentTestCase<Label> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         readonly.setImmediate(true);
diff --git a/tests/src/com/vaadin/tests/components/menubar/Menubars.java b/tests/src/com/vaadin/tests/components/menubar/Menubars.java
index 0442225134..0c059b82db 100644
--- a/tests/src/com/vaadin/tests/components/menubar/Menubars.java
+++ b/tests/src/com/vaadin/tests/components/menubar/Menubars.java
@@ -108,9 +108,9 @@ public class Menubars extends ComponentTestCase<MenuBar> {
                     }

                 });

 

-        errorIndicators.setValue(new Boolean(false));

-        readonly.setValue(new Boolean(false));

-        enabled.setValue(new Boolean(true));

+        errorIndicators.setValue(Boolean.FALSE);

+        readonly.setValue(Boolean.FALSE);

+        enabled.setValue(Boolean.TRUE);

 

         errorIndicators.setImmediate(true);

         readonly.setImmediate(true);

diff --git a/tests/src/com/vaadin/tests/components/richtextarea/RichTextAreas.java b/tests/src/com/vaadin/tests/components/richtextarea/RichTextAreas.java
index e3e12a1c8d..71030d6b15 100644
--- a/tests/src/com/vaadin/tests/components/richtextarea/RichTextAreas.java
+++ b/tests/src/com/vaadin/tests/components/richtextarea/RichTextAreas.java
@@ -96,10 +96,10 @@ public class RichTextAreas extends ComponentTestCase<RichTextArea> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        required.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        required.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         required.setImmediate(true);
diff --git a/tests/src/com/vaadin/tests/components/select/NativeSelects.java b/tests/src/com/vaadin/tests/components/select/NativeSelects.java
index cd2c95d127..8f3b79af21 100644
--- a/tests/src/com/vaadin/tests/components/select/NativeSelects.java
+++ b/tests/src/com/vaadin/tests/components/select/NativeSelects.java
@@ -143,10 +143,10 @@ public class NativeSelects extends ComponentTestCase<NativeSelect> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
-        nullSelect.setValue(new Boolean(false));
+        errorIndicators.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
+        nullSelect.setValue(Boolean.FALSE);
 
         errorIndicators.setImmediate(true);
         readonly.setImmediate(true);
diff --git a/tests/src/com/vaadin/tests/components/table/ColumnExpandWithFixedColumns.java b/tests/src/com/vaadin/tests/components/table/ColumnExpandWithFixedColumns.java
index f0c3779a4e..198e29be61 100644
--- a/tests/src/com/vaadin/tests/components/table/ColumnExpandWithFixedColumns.java
+++ b/tests/src/com/vaadin/tests/components/table/ColumnExpandWithFixedColumns.java
@@ -30,7 +30,7 @@ public class ColumnExpandWithFixedColumns extends TestBase {
 

     @Override

     protected String getDescription() {

-        return "The second coulmn has expand ratio and should use the maximum available space";

+        return "The second column has expand ratio and should use the maximum available space";

     }

 

     @Override

diff --git a/tests/src/com/vaadin/tests/components/textfield/TextFields.java b/tests/src/com/vaadin/tests/components/textfield/TextFields.java
index a908dccc1d..16ac819718 100644
--- a/tests/src/com/vaadin/tests/components/textfield/TextFields.java
+++ b/tests/src/com/vaadin/tests/components/textfield/TextFields.java
@@ -117,10 +117,10 @@ public class TextFields extends ComponentTestCase<TextField> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        required.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        required.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         required.setImmediate(true);
diff --git a/tests/src/com/vaadin/tests/featurebrowser/PropertyPanel.java b/tests/src/com/vaadin/tests/featurebrowser/PropertyPanel.java
index 5e105dbf1e..6a87dec748 100644
--- a/tests/src/com/vaadin/tests/featurebrowser/PropertyPanel.java
+++ b/tests/src/com/vaadin/tests/featurebrowser/PropertyPanel.java
@@ -272,8 +272,8 @@ public class PropertyPanel extends Panel implements Button.ClickListener,
 
         // Customization for Window component
         if (objectToConfigure instanceof Window) {
-            disableField(set.getField("enabled"), new Boolean(true));
-            disableField(set.getField("visible"), new Boolean(true));
+            disableField(set.getField("enabled"), Boolean.TRUE);
+            disableField(set.getField("visible"), Boolean.TRUE);
             disableField(set.getField("componentError"));
             disableField(set.getField("icon"));
         }