aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohannes Dahlström <johannesd@vaadin.com>2013-04-17 17:35:38 +0300
committerVaadin Code Review <review@vaadin.com>2013-04-18 17:51:53 +0000
commit4f9df1f6f0926cfce846a43c557e9b69302a4ca3 (patch)
tree16c0d9e35091e63dd5dbb130be31c44ec1d1800d
parentfc4aeac8b43bb3f200b25a997ade05075592ee90 (diff)
downloadvaadin-framework-4f9df1f6f0926cfce846a43c557e9b69302a4ca3.tar.gz
vaadin-framework-4f9df1f6f0926cfce846a43c557e9b69302a4ca3.zip
Don't detach and reattach VAbstractSplitPanel child widgets unnecessarily (#11628)
Change-Id: I84da9b786706410b42ae4116be0b0a3da896538b
-rw-r--r--client/src/com/vaadin/client/ui/VAbstractSplitPanel.java6
1 files changed, 6 insertions, 0 deletions
diff --git a/client/src/com/vaadin/client/ui/VAbstractSplitPanel.java b/client/src/com/vaadin/client/ui/VAbstractSplitPanel.java
index 45c5cb6453..1cc25c741e 100644
--- a/client/src/com/vaadin/client/ui/VAbstractSplitPanel.java
+++ b/client/src/com/vaadin/client/ui/VAbstractSplitPanel.java
@@ -499,6 +499,9 @@ public class VAbstractSplitPanel extends ComplexPanel {
/** For internal use only. May be removed or replaced in the future. */
public void setFirstWidget(Widget w) {
+ if (firstChild == w) {
+ return;
+ }
if (firstChild != null) {
firstChild.removeFromParent();
}
@@ -510,6 +513,9 @@ public class VAbstractSplitPanel extends ComplexPanel {
/** For internal use only. May be removed or replaced in the future. */
public void setSecondWidget(Widget w) {
+ if (secondChild == w) {
+ return;
+ }
if (secondChild != null) {
secondChild.removeFromParent();
}