aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArtur Signell <artur@vaadin.com>2013-01-04 13:32:16 +0200
committerVaadin Code Review <review@vaadin.com>2013-01-07 18:03:40 +0000
commit68406d87bb4dfb90d460ac02ef6412493f76eba7 (patch)
tree836ee244fb61515da8fddbe0647fee6b899a0e99
parent3c916b8d259e331459fb2b35f5296033ef265f0d (diff)
downloadvaadin-framework-68406d87bb4dfb90d460ac02ef6412493f76eba7.tar.gz
vaadin-framework-68406d87bb4dfb90d460ac02ef6412493f76eba7.zip
Removed old source file checkers (#9399)
Checks are now done by checkstyles (#9065) Change-Id: I816109d0f13d28ba6ce58da9427578486ef3ce33
-rw-r--r--server/tests/src/com/vaadin/tests/server/SourceFileChecker.java217
-rw-r--r--server/tests/src/com/vaadin/tests/server/TestThemeNames.java38
2 files changed, 0 insertions, 255 deletions
diff --git a/server/tests/src/com/vaadin/tests/server/SourceFileChecker.java b/server/tests/src/com/vaadin/tests/server/SourceFileChecker.java
deleted file mode 100644
index 1ab742427d..0000000000
--- a/server/tests/src/com/vaadin/tests/server/SourceFileChecker.java
+++ /dev/null
@@ -1,217 +0,0 @@
-package com.vaadin.tests.server;
-
-import java.io.File;
-import java.io.FileInputStream;
-import java.io.IOException;
-import java.util.HashSet;
-import java.util.Set;
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
-
-import junit.framework.Assert;
-import junit.framework.TestCase;
-
-import org.apache.commons.io.IOUtils;
-
-public class SourceFileChecker extends TestCase {
-
- /**
- * The tests are run in the build directory.
- */
- public static String baseDirectory = null;
- public static final String SRC_DIR = getBaseDir() + "src";
- public static final String TESTBENCH_SRC_DIR = getBaseDir()
- + "tests/testbench";
- public static final String SERVERSIDE_SRC_DIR = getBaseDir()
- + "tests/server-side";
- public static final String CLIENTSIDE_SRC_DIR = getBaseDir()
- + "tests/client-side";
- private String externalJavaFiles = "com/vaadin/external";
- private String buildFiles = "build";
- private Set<String> alwaysIgnore = new HashSet<String>();
- {
- alwaysIgnore.add(".settings");
- alwaysIgnore.add("eclipse");
- }
-
- public static String getBaseDir() {
- if (baseDirectory != null) {
- return baseDirectory;
- }
- // Run in the "build" directory by build, in the project root by Eclipse
- for (File f : new File(".").listFiles()) {
- if (f.getName().equals("buildhelpers")) {
- // We are in "build"
- baseDirectory = "../";
- return baseDirectory;
- }
- }
-
- baseDirectory = "./";
- return baseDirectory;
- }
-
- private static final String[] ALL_SRC_DIRS = new String[] { SRC_DIR,
- TESTBENCH_SRC_DIR, SERVERSIDE_SRC_DIR, CLIENTSIDE_SRC_DIR };
-
- public void testJavaFilesContainsLicense() throws IOException {
- Set<String> ignore = new HashSet<String>(alwaysIgnore);
- ignore.add(externalJavaFiles);
- validateFiles(SRC_DIR, new LicenseChecker(), ignore,
- "The following files are missing license information:\n{0}",
- ".java");
- }
-
- public void testNonJavaFilesUseUnixNewline() throws IOException {
- Set<String> ignore = new HashSet<String>(alwaysIgnore);
- ignore.add(buildFiles);
-
- for (String suffix : new String[] { ".html", ".css", ".xml" }) {
- validateFiles(getBaseDir(), new DosNewlineDetector(), ignore,
- "The following files contain CRLF instead of LF:\n{0}",
- suffix);
- }
- }
-
- public void testJavaFilesUseUnixNewline() throws IOException {
- Set<String> ignore = new HashSet<String>(alwaysIgnore);
- ignore.add(externalJavaFiles);
- for (String dir : ALL_SRC_DIRS) {
- validateFiles(dir, new DosNewlineDetector(), ignore,
- "The following files contain CRLF instead of LF:\n{0}",
- ".java");
- }
- }
-
- public void testGwtFilesUsingEntry() {
- Set<String> ignore = new HashSet<String>(alwaysIgnore);
- ignore.add(externalJavaFiles);
- validateFiles(
- SRC_DIR,
- new GwtEntryChecker(),
- ignore,
- "The following files might export javscript callbacks without $entry:\n{0}",
- ".java");
- }
-
- public interface FileValidator {
- void validateFile(File f) throws Exception;
- }
-
- private void validateFiles(String directory, FileValidator validator,
- Set<String> ignore, String errorMessage, String ending) {
- File srcDir = new File(directory);
- HashSet<String> missing = new HashSet<String>();
- validateFiles(directory, srcDir, missing, validator, ending, ignore);
- if (!missing.isEmpty()) {
- throw new RuntimeException(errorMessage.replace("{0}", missing
- .toString().replace(',', '\n')));
- }
-
- }
-
- private void validateFiles(String baseDirectory, File directory,
- HashSet<String> missing, FileValidator validator, String suffix,
- Set<String> ignores) {
- Assert.assertTrue("Directory " + directory + " does not exist",
- directory.exists());
-
- File[] files = directory.listFiles();
- if (files == null) {
- throw new RuntimeException("Listing of directory "
- + directory.getPath() + " failed");
- }
- for (File f : files) {
- boolean ignoreThis = false;
- for (String ignore : ignores) {
- if (new File(baseDirectory, ignore).equals(f)) {
- ignoreThis = true;
- continue;
- }
- }
-
- if (ignoreThis) {
- continue;
- }
-
- if (f.isDirectory()) {
- validateFiles(baseDirectory, f, missing, validator, suffix,
- ignores);
- } else if (f.getName().endsWith(suffix)) {
- try {
- validator.validateFile(f);
- } catch (Throwable t) {
- missing.add(f.getPath());
- }
- }
- }
- }
-
- abstract class FileContentsValidator implements FileValidator {
- @Override
- public void validateFile(File f) throws Exception {
- FileInputStream fis = new FileInputStream(f);
- String contents = IOUtils.toString(fis);
- fis.close();
- validateContents(f, contents);
- }
-
- protected abstract void validateContents(File f, String contents)
- throws Exception;
-
- }
-
- class DosNewlineDetector extends FileContentsValidator {
-
- @Override
- protected void validateContents(File f, String contents)
- throws Exception {
- if (contents.contains("\r\n")) {
- throw new IllegalArgumentException();
- }
-
- }
-
- }
-
- class LicenseChecker extends FileContentsValidator {
-
- @Override
- protected void validateContents(File f, String contents)
- throws Exception {
- if (!contents.contains("@" + "VaadinApache2LicenseForJavaFiles"
- + "@")) {
- throw new IllegalArgumentException();
- }
- }
- }
-
- class GwtEntryChecker extends FileContentsValidator {
- // Matches e.g.
- // @com.vaadin.client.HistoryImplIEVaadin::escapeHtml(
- private final Matcher matcher = Pattern.compile("@[\\w.]+::\\w+\\(")
- .matcher("");
-
- @Override
- protected void validateContents(File f, String contents)
- throws Exception {
- matcher.reset(contents);
- while (matcher.find()) {
- int start = matcher.start();
-
- // Search backwards to find index of native block start
- int nativeBlockStart = contents.lastIndexOf("/*-{", start);
-
- // Get contents between block start and our match
- String beforeMatchInBlock = contents.substring(
- nativeBlockStart, start);
-
- // Fail if there's no $entry
- if (!beforeMatchInBlock.contains("$entry")) {
- throw new IllegalArgumentException();
- }
- }
- }
-
- }
-}
diff --git a/server/tests/src/com/vaadin/tests/server/TestThemeNames.java b/server/tests/src/com/vaadin/tests/server/TestThemeNames.java
deleted file mode 100644
index 22fe315730..0000000000
--- a/server/tests/src/com/vaadin/tests/server/TestThemeNames.java
+++ /dev/null
@@ -1,38 +0,0 @@
-package com.vaadin.tests.server;
-
-import java.io.File;
-import java.lang.reflect.Field;
-import java.util.List;
-
-import junit.framework.TestCase;
-
-import com.vaadin.tests.VaadinClasses;
-import com.vaadin.ui.themes.BaseTheme;
-
-public class TestThemeNames extends TestCase {
- public void testThemeNames() {
- File baseDir = new File(SourceFileChecker.getBaseDir()
- + "WebContent/VAADIN/themes/");
-
- List<Class<? extends BaseTheme>> themeClasses = VaadinClasses
- .getThemeClasses();
- for (Class<? extends BaseTheme> themeClass : themeClasses) {
- try {
- Field field = themeClass.getField("THEME_NAME");
- String themeName = (String) field.get(null);
-
- File themeDir = new File(baseDir, themeName);
- File styleFile = new File(themeDir, "styles.css");
-
- assertTrue("Can't find " + styleFile + " for theme "
- + themeClass.getName(), styleFile.exists());
-
- // Test that casing matches
- assertEquals(themeDir.getCanonicalFile().getName(), themeName);
- } catch (Exception e) {
- throw new RuntimeException(e);
- }
- }
- }
-
-}