aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArtur Signell <artur@vaadin.com>2015-12-17 08:25:10 +0200
committerArtur Signell <artur@vaadin.com>2015-12-17 13:02:56 +0000
commit7146d04d0727b90ad49e83d075fd277d46317e69 (patch)
tree5641da6cf3d754092403b8f685519e339a90894e
parent10f332a9cc0f27f2f97fbe47c8e4046be0ef6a89 (diff)
downloadvaadin-framework-7146d04d0727b90ad49e83d075fd277d46317e69.tar.gz
vaadin-framework-7146d04d0727b90ad49e83d075fd277d46317e69.zip
Disable Atmosphere online/offline handling (#19391)
Atmosphere will disconnect the push connection when going offline and reconnect it when going online again. There are no events sent when this happens, which means the reconnect logic cannot take this into account. Having it enabled leads to something like: 1. Browser goes offline, push is disconnected 2. Framework sees it as a normal close and does not show the reconnect dialog 3. The user does something, the framework tries to send a websocket request 4. A new Atmosphere request is created and enters a try-to-reconnect loop as expected 5. The browser goes online, and the online event re-initializes the old connection although a try-to-reconnect loop is already running Change-Id: I5dcef768783142e2c7b4e7c821353addb0ec3d28
-rw-r--r--client/src/com/vaadin/client/communication/AtmospherePushConnection.java1
1 files changed, 1 insertions, 0 deletions
diff --git a/client/src/com/vaadin/client/communication/AtmospherePushConnection.java b/client/src/com/vaadin/client/communication/AtmospherePushConnection.java
index 698ce3be45..dd44d1cb6b 100644
--- a/client/src/com/vaadin/client/communication/AtmospherePushConnection.java
+++ b/client/src/com/vaadin/client/communication/AtmospherePushConnection.java
@@ -520,6 +520,7 @@ public class AtmospherePushConnection implements PushConnection {
maxReconnectOnClose: 10000000,
trackMessageLength: true,
enableProtocol: true,
+ handleOnlineOffline: false,
messageDelimiter: String.fromCharCode(@com.vaadin.shared.communication.PushConstants::MESSAGE_DELIMITER)
};
}-*/;