aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohannes Dahlström <johannes.dahlstrom@vaadin.com>2011-12-16 11:58:58 +0000
committerJohannes Dahlström <johannes.dahlstrom@vaadin.com>2011-12-16 11:58:58 +0000
commit780a2098cbd96a8befe35a4676bfe49a01a704f4 (patch)
tree2848fb87dcb6e1fcc812755045f93e4fa307100e
parent848c00331dd0c726b165af44cc3b0de6e327de29 (diff)
downloadvaadin-framework-780a2098cbd96a8befe35a4676bfe49a01a704f4.tar.gz
vaadin-framework-780a2098cbd96a8befe35a4676bfe49a01a704f4.zip
#8040 test case and fix
svn changeset:22422/svn branch:6.7
-rw-r--r--src/com/vaadin/terminal/gwt/client/ui/VScrollTable.java11
1 files changed, 2 insertions, 9 deletions
diff --git a/src/com/vaadin/terminal/gwt/client/ui/VScrollTable.java b/src/com/vaadin/terminal/gwt/client/ui/VScrollTable.java
index 553934bf98..d77507084d 100644
--- a/src/com/vaadin/terminal/gwt/client/ui/VScrollTable.java
+++ b/src/com/vaadin/terminal/gwt/client/ui/VScrollTable.java
@@ -4052,15 +4052,8 @@ public class VScrollTable extends FlowPanel implements Table, ScrollHandler,
reactLastRow = totalRows - 1;
}
if (lastRendered < reactFirstRow || firstRendered > reactLastRow) {
- /*
- * #8040 - scroll position is completely changed since the
- * latest request, so request a new set of rows.
- *
- * TODO: We should probably check whether the fetched rows match
- * the current scroll position right when they arrive, so as to
- * not waste time rendering a set of rows that will never be
- * visible...
- */
+ // #8040 - scroll position is completely changed
+ // TODO: should probably be done earlier
rowRequestHandler.setReqFirstRow(reactFirstRow);
rowRequestHandler.setReqRows(reactLastRow - reactFirstRow + 1);
rowRequestHandler.deferRowFetch(1);