diff options
author | Anna Koskinen <Ansku@users.noreply.github.com> | 2020-06-26 15:50:51 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-06-26 15:50:51 +0300 |
commit | 797b49372f3198495cb4e331cab85e040afd352e (patch) | |
tree | 148b5f4dddaec16d8c5ca77e6370b6711dc25bc6 /client | |
parent | d824efe59a71e2eb3e554873a32d92ca5d34cc5e (diff) | |
download | vaadin-framework-797b49372f3198495cb4e331cab85e040afd352e.tar.gz vaadin-framework-797b49372f3198495cb4e331cab85e040afd352e.zip |
Update ComboBox popup position comparison to use correct top value. (#12041)
Fixes #12029
Diffstat (limited to 'client')
-rw-r--r-- | client/src/main/java/com/vaadin/client/ui/VComboBox.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/client/src/main/java/com/vaadin/client/ui/VComboBox.java b/client/src/main/java/com/vaadin/client/ui/VComboBox.java index 6ff2f31a9a..b079930364 100644 --- a/client/src/main/java/com/vaadin/client/ui/VComboBox.java +++ b/client/src/main/java/com/vaadin/client/ui/VComboBox.java @@ -906,7 +906,7 @@ public class VComboBox extends Composite implements Field, KeyDownHandler, // ComboBox itself may be incorrectly positioned, don't try to // adjust horizontal popup position yet. Earlier width // calculations must be performed anyway to avoid flickering. - if (top != topPosition) { + if (top != getAbsoluteTop()) { // Variable 'left' still contains the original popupLeft, // 'top' has been updated, thus vertical position needs // adjusting. @@ -935,7 +935,7 @@ public class VComboBox extends Composite implements Field, KeyDownHandler, } // Only update the position if it has changed. - if (top != topPosition || left != getPopupLeft()) { + if (top != getAbsoluteTop() || left != getPopupLeft()) { setPopupPosition(left, top); } menu.scrollSelectionIntoView(); |