diff options
| author | Tarek Oraby <42799254+tarekoraby@users.noreply.github.com> | 2020-05-25 12:21:11 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-05-25 12:21:11 +0300 |
| commit | 9c9991d8877652d2f122ee78ce4173972e1bc11d (patch) | |
| tree | 362fbb4273fa802a1652464d4f4605e744bf98a3 /client | |
| parent | 06947c6f90e3a4d9f85f399f383e21da4f6e12d4 (diff) | |
| download | vaadin-framework-9c9991d8877652d2f122ee78ce4173972e1bc11d.tar.gz vaadin-framework-9c9991d8877652d2f122ee78ce4173972e1bc11d.zip | |
Fix ComboBox in read-only mode allowing value change by user (#12022)
* Fix ComboBox in read-only mode allowing value change by user
Fixes #12021
* Fix popup hiding condition
Co-authored-by: Tatu Lund <tatu@vaadin.com>
Diffstat (limited to 'client')
| -rw-r--r-- | client/src/main/java/com/vaadin/client/ui/VComboBox.java | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/client/src/main/java/com/vaadin/client/ui/VComboBox.java b/client/src/main/java/com/vaadin/client/ui/VComboBox.java index 08c57f888a..6ff2f31a9a 100644 --- a/client/src/main/java/com/vaadin/client/ui/VComboBox.java +++ b/client/src/main/java/com/vaadin/client/ui/VComboBox.java @@ -2028,6 +2028,9 @@ public class VComboBox extends Composite implements Field, KeyDownHandler, /** For internal use only. May be removed or replaced in the future. */ public void updateReadOnly() { + if (readonly) { + suggestionPopup.hide(); + } debug("VComboBox: updateReadOnly()"); tb.setReadOnly(readonly || !textInputEnabled); } |