diff options
author | Markus Koivisto <markus@vaadin.com> | 2015-09-30 16:22:11 +0300 |
---|---|---|
committer | Markus Koivisto <markus@vaadin.com> | 2015-09-30 16:22:11 +0300 |
commit | 2fa06db5f70236fdbd93b2c66efd07aa0e880c03 (patch) | |
tree | 4821e06011cea1f14fd122d56d970bd18158ab7c /server/src/com/vaadin/ui/AbstractField.java | |
parent | b0b8f1a21b01089d0ddef954518dfc7ec02bddc1 (diff) | |
download | vaadin-framework-2fa06db5f70236fdbd93b2c66efd07aa0e880c03.tar.gz vaadin-framework-2fa06db5f70236fdbd93b2c66efd07aa0e880c03.zip |
Revert "Parse readonly values for AbstractFields correctly #18850"
This reverts commit 5e9209421ce92e16531299c8c4be5fdd412bb513.
Diffstat (limited to 'server/src/com/vaadin/ui/AbstractField.java')
-rw-r--r-- | server/src/com/vaadin/ui/AbstractField.java | 32 |
1 files changed, 5 insertions, 27 deletions
diff --git a/server/src/com/vaadin/ui/AbstractField.java b/server/src/com/vaadin/ui/AbstractField.java index 61f58157ea..cf14d1cb96 100644 --- a/server/src/com/vaadin/ui/AbstractField.java +++ b/server/src/com/vaadin/ui/AbstractField.java @@ -264,9 +264,7 @@ public abstract class AbstractField<T> extends AbstractComponent implements committingValueToDataSource = false; } } else { - /* - * An invalid value and we don't allow them, throw the exception - */ + /* An invalid value and we don't allow them, throw the exception */ validate(); } } @@ -461,35 +459,15 @@ public abstract class AbstractField<T> extends AbstractComponent implements * @param repaintIsNotNeeded * True iff caller is sure that repaint is not needed. * @throws Property.ReadOnlyException - * @throws Converter.ConversionException - * @throws InvalidValueException - */ - protected void setValue(T newFieldValue, boolean repaintIsNotNeeded) { - setValue(newFieldValue, repaintIsNotNeeded, false); - } - - /** - * Sets the value of the field. - * - * @since - * @param newFieldValue - * the New value of the field. - * @param repaintIsNotNeeded - * True iff caller is sure that repaint is not needed. - * @param ignoreReadOnly - * True iff if the read-only check should be ignored - * @throws Property.ReadOnlyException - * @throws Converter.ConversionException - * @throws InvalidValueException */ - protected void setValue(T newFieldValue, boolean repaintIsNotNeeded, - boolean ignoreReadOnly) throws Property.ReadOnlyException, - Converter.ConversionException, InvalidValueException { + protected void setValue(T newFieldValue, boolean repaintIsNotNeeded) + throws Property.ReadOnlyException, Converter.ConversionException, + InvalidValueException { if (!SharedUtil.equals(newFieldValue, getInternalValue())) { // Read only fields can not be changed - if (!ignoreReadOnly && isReadOnly()) { + if (isReadOnly()) { throw new Property.ReadOnlyException(); } try { |