Reading properties of components should not set state to dirty (#14060).

Many core vaadin components did incorrectly mark the state as dirty when
reading from them. This patch fixes the problem, which should reduce the
amount of server->client state updates significantly.

Change-Id: I342d74129e2985a7f407e9b53a802dc0146d9992

1 files changed, 6 insertions, 1 deletions

diff --git a/server/src/com/vaadin/ui/Flash.java b/server/src/com/vaadin/ui/Flash.java
index 791202f4a9..bbbd4e3285 100644
--- a/server/src/com/vaadin/ui/Flash.java
+++ b/server/src/com/vaadin/ui/Flash.java
@@ -67,6 +67,11 @@ public class Flash extends AbstractEmbedded {
         return (FlashState) super.getState();
     }
 
+    @Override
+    protected FlashState getState(boolean markAsDirty) {
+        return (FlashState) super.getState(markAsDirty);
+    }
+
     /**
      * This attribute specifies the base path used to resolve relative URIs
      * specified by the classid, data, and archive attributes. When absent, its
@@ -156,7 +161,7 @@ public class Flash extends AbstractEmbedded {
      * @return the Value of parameter or null if not found.
      */
     public String getParameter(String name) {
-        return getState().embedParams != null ? getState().embedParams
+        return getState(false).embedParams != null ? getState(false).embedParams
                 .get(name) : null;
     }