aboutsummaryrefslogtreecommitdiffstats
path: root/server/src
diff options
context:
space:
mode:
authorAnna Koskinen <Ansku@users.noreply.github.com>2018-02-27 17:05:22 +0200
committerTeemu Suo-Anttila <tsuoanttila@users.noreply.github.com>2018-02-27 17:05:22 +0200
commita0a9eee14fed0d5c6b7a8ae5b5f9185d7cef1279 (patch)
treeb33c2e9a0847c32d54db5a30b02f1186a8eb154c /server/src
parent6d84351fee4bdb6e877d9100c8645e6c6044864e (diff)
downloadvaadin-framework-a0a9eee14fed0d5c6b7a8ae5b5f9185d7cef1279.tar.gz
vaadin-framework-a0a9eee14fed0d5c6b7a8ae5b5f9185d7cef1279.zip
Fix client and server filter state mismatch in Combobox (#10630)
Fixes #10624
Diffstat (limited to 'server/src')
-rw-r--r--server/src/main/java/com/vaadin/ui/ComboBox.java7
1 files changed, 3 insertions, 4 deletions
diff --git a/server/src/main/java/com/vaadin/ui/ComboBox.java b/server/src/main/java/com/vaadin/ui/ComboBox.java
index 9500d08c96..50665fd877 100644
--- a/server/src/main/java/com/vaadin/ui/ComboBox.java
+++ b/server/src/main/java/com/vaadin/ui/ComboBox.java
@@ -206,7 +206,7 @@ public class ComboBox<T> extends AbstractSingleSelect<T>
@Override
public void setFilter(String filterText) {
- currentFilterText = filterText;
+ getState().currentFilterText = filterText;
filterSlot.accept(filterText);
}
};
@@ -224,8 +224,6 @@ public class ComboBox<T> extends AbstractSingleSelect<T>
private StyleGenerator<T> itemStyleGenerator = item -> null;
- private String currentFilterText;
-
private SerializableConsumer<String> filterSlot = filter -> {
// Just ignore when neither setDataProvider nor setItems has been called
};
@@ -890,7 +888,8 @@ public class ComboBox<T> extends AbstractSingleSelect<T>
};
SerializableConsumer<C> providerFilterSlot = internalSetDataProvider(
- dataProvider, convertOrNull.apply(currentFilterText));
+ dataProvider,
+ convertOrNull.apply(getState(false).currentFilterText));
filterSlot = filter -> providerFilterSlot
.accept(convertOrNull.apply(filter));