diff options
| author | Aleksi Hietanen <aleksi@vaadin.com> | 2017-11-21 14:25:42 +0200 |
|---|---|---|
| committer | Teemu Suo-Anttila <tsuoanttila@users.noreply.github.com> | 2017-11-21 20:25:39 +0200 |
| commit | f299c7a31b00d614c1f248d97a54796ce385fcf2 (patch) | |
| tree | d5f04537f28513a4fbab86e2655eaa4e7a05b444 /uitest/src | |
| parent | 7878bd69a55e80d3f8191b756700eaa2e79c745f (diff) | |
| download | vaadin-framework-f299c7a31b00d614c1f248d97a54796ce385fcf2.tar.gz vaadin-framework-f299c7a31b00d614c1f248d97a54796ce385fcf2.zip | |
Fix issues from API review for 8.2 (#10342)
* Rename HierarchicalDataCommunicator#getMapper to getHierarchyMapper
* Make rpc field in Notification private
* Change DropIndexCalculator.ALWAYS_DROP_TO_END to a generic static method
* Move EditorImpl#editRow documentation to the interface level
* Correct GridDragEndEvent, GridDragStartEvent constructor javadocs
* Revert SharedState.registeredEventListeners to a Set
* Rename GridDropTarget dropAllowedOnSortedGridRows
* Rename ColumnState.contentMode to tooltipContentMode
Diffstat (limited to 'uitest/src')
| -rw-r--r-- | uitest/src/main/java/com/vaadin/tests/components/grid/AbstractGridDnD.java | 4 | ||||
| -rw-r--r-- | uitest/src/main/java/com/vaadin/tests/components/grid/GridRowDraggerTwoGrids.java | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/uitest/src/main/java/com/vaadin/tests/components/grid/AbstractGridDnD.java b/uitest/src/main/java/com/vaadin/tests/components/grid/AbstractGridDnD.java index b68866c727..9130914baa 100644 --- a/uitest/src/main/java/com/vaadin/tests/components/grid/AbstractGridDnD.java +++ b/uitest/src/main/java/com/vaadin/tests/components/grid/AbstractGridDnD.java @@ -66,9 +66,9 @@ public abstract class AbstractGridDnD extends AbstractTestUIWithLog { } }); CheckBox dropOnSortedGridRows = new CheckBox("Drop on Sorted Grid Rows", - dropTarget.isDropAllowedOnSortedGridRows()); + dropTarget.isDropAllowedOnRowsWhenSorted()); dropOnSortedGridRows.addValueChangeListener(event -> { - dropTarget.setDropAllowedOnSortedGridRows(event.getValue()); + dropTarget.setDropAllowedOnRowsWhenSorted(event.getValue()); }); RadioButtonGroup<Integer> frozenColumnSelect = new RadioButtonGroup<>( diff --git a/uitest/src/main/java/com/vaadin/tests/components/grid/GridRowDraggerTwoGrids.java b/uitest/src/main/java/com/vaadin/tests/components/grid/GridRowDraggerTwoGrids.java index b0c630a3a8..70d3d12277 100644 --- a/uitest/src/main/java/com/vaadin/tests/components/grid/GridRowDraggerTwoGrids.java +++ b/uitest/src/main/java/com/vaadin/tests/components/grid/GridRowDraggerTwoGrids.java @@ -44,7 +44,7 @@ public class GridRowDraggerTwoGrids extends AbstractGridDnD { CheckBox addItemsToEnd = new CheckBox("Add Items To End", false); addItemsToEnd.addValueChangeListener( event -> gridDragger.setDropIndexCalculator(event.getValue() - ? DropIndexCalculator.ALWAYS_DROP_TO_END : null)); + ? DropIndexCalculator.alwaysDropToEnd() : null)); CheckBox removeItemsFromSource = new CheckBox( "Remove items from source grid", true); removeItemsFromSource.addValueChangeListener(event -> gridDragger |