| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
| |
Also added missing JavaDocs.
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added, completed, and corrected JavaDocs.
- Added an assert to enforce a condition that has always been required.
- Added default sections to switch blocks.
- Added wildcards.
- Deprecated unused methods and variables.
- Removed inner assignments.
- Removed unused private variables and calls that do nothing.
- Updated deprecated calls to use currently recommended versions.
- Updated warning suppressions.
- ...and some auto-formatting.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added missing default sections to switch blocks.
- Added missing JavaDocs and JavaDoc parameters.
- Added wildcards where possible.
- Deprecated unused method.
- Fixed JavaDoc formatting.
- Removed inner assignments.
- Removed unused imports.
- Removed unused variables.
- Removed warning suppressions that were unnecessary or about boxing
(not tracked by coding conventions).
- Suppressed warnings about rawtypes, deprecation, and unchecked where
couldn't be avoided.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- removed unused private methods
- removed unused private variables
- removed unnecessary initializations
- removed unnecessary substring(0)
- removed inner assignments
- renamed private methods that started with upper case
- renamed static final variables to use upper case
- converted to use non-deprecated options
- suppressed unavoidable warnings
- divided long Strings to multiple lines
- added missing types
- added missing JavaDoc parameters
- formatting
- updated comments & JavaDocs
|
|
|
|
|
| |
Handle possible race condition by disabling the editor's widget while awaiting validation from the server.
Fixes #12270
|
|
|
|
|
|
|
|
|
|
|
| |
* Add browser specific handling in setRows
Fixes: https://github.com/vaadin/framework/issues/10138
Fixes: https://github.com/vaadin/framework/issues/7878
* Enforced minimum height to 1 rows and added a test.
Co-authored-by: Anna Koskinen <anna@vaadin.com>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
- Old details should close.
- New details should open.
- If some row has details in both old and new item set, the details row
contents should get updated.
- Updating details row contents should not break the positioning of the
rows and details below.
Fixes #12211
|
|
|
|
| |
* Update copyright year range.
|
|
|
|
|
|
|
|
|
| |
- null check to prevent NPE from the merged column headers
- convert to internal columnIds for merge handling
- use correct cell in merge handling
- switch away from streams in merge handling for easier readability
- regression test
Fixes: #10464
|
|
|
|
|
|
|
| |
(#12168)
Do not fire DateField's value change event if the new date is not within the range.
Fixes: #12163
|
| |
|
|
|
|
|
| |
Without access to the presentation provider used for a column, it is often not possible to reconstruct the data as shown on the end-user's screen
This commit adds a getter method to Grid.Column to allow access to this provider
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix to LayoutManager size calculations during transform.
- ComputedStyle is slower but more reliable than using
getBoundingClientRect, which does not work as expected if a transform
has been applied to the element or one of its parents. This is a problem
e.g. with PopupView, where getBoundingClientRect will return too small
size (or even zero size) for all the popup contents while the opening
animation is active. ComputedStyle ignores the transform and returns the
expected value.
- The presence of the element in DOM must be checked before the size is
requested from ComputedStyle, if the element has disappeared from DOM
without a warning and calculation is attempted anyway, the browser gets
stuck.
- Possibility to configure LayoutManager to use the less reliable
calculations for applications where the slight performance difference is
more important than layout issues within elements that have transform
animations.
- Manual test, problem isn't reproducible by TestBench.
Fixes: #11187
|
|
|
|
|
|
|
| |
- Informative error message
- Reset back to disabled state when enabling fails
- Incorrect usage also detectable using non-mobile devices
Fixes #12152
|
|
|
|
|
| |
Lambdas and function references do not serialize
See: https://vaadin.com/forum/thread/18462951/vaadin-8-stateful-session
|
| |
|
|
|
| |
Fixes: https://github.com/vaadin/framework/issues/7773
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Explicitly remove old dataprovider listener when new one is set
If not done, this can cause memory leakage
* Formatting
* Fixed coding style
* Take into account further scenarios
Component maybe detached permanently and thus data provider listener needs to be remove in detach. Also if this is only momentary remove from layout add back cycle, re-setup is needed in attach, in case it was not already setup before attaching by setDataProvider.
* Change super.detach() call order
* Added null check to getDataProvider
* Setting dataProviderListener to null on detach
* Removing listener only if it exists
* Fix
|
|
|
|
|
| |
Calculate number of the week in the year based on Date. Note, support for "ww" is missing from GWT DateTimeFormat and java.util.Calendar is not supported in GWT, hence DIY method is needed.
Fixes: #10603
|
| |
|
|
|
| |
Fixes #11993
|
|
|
|
|
| |
(#11981)
Fixes #10844
|
| |
|
|
|
|
|
| |
Tree class doesn't currently provide an obvious way that would enable a Tree object to be treated as a multi select. This commit extends the Tree API, enabling it to be used as a multi select, which would importantly facilitate the selection/deselection of multiple items in trees whose SelectionMode is MULTI.
closes #11948
|
|
|
|
|
|
|
|
|
| |
DateTimeField and DateField currently implement a hardcoded logic by which they adjust their time zone names to display daylight-saving time (DST) zone names. Specifically, this hardcoded logic only adjusts the displayed date to DST format if that date falls in one of the years between 1980 and the following 20 years in the future from the current date (that is, until 2040 at the time of this commit).
For some use cases, this is problematic because it is desirable to display proper DST-adjusted time zones beyond the 20 years limit (and possibly also before 1980).
Rather than choosing another arbitrary, hardcoded threshold, this commit extends the AbstractDateField API to allow the user to choose the range (start and end years) between which the DST transition dates are calculated (and hence displayed properly). If the user doesn't invoke this new API, DateTimeField and DateField will default to behave according the existing logic (i.e. display DST zone names between 1980 and 20 years into the future).
Closes #11919
|
|
|
| |
Fixes #11108
|
|
|
| |
Should use a StringBuilder to accumulate strings in a loop, to avoid the performance cost of repeatedly constructing strings.
|
|
|
| |
Fixes #11810
|
|
|
| |
Fixes #10419
|
|
|
| |
Fixes #11806
|
|
|
|
|
|
|
|
| |
* Added note to DateField#setRangeStart JavaDoc
* Added additional checking of valid startDate
* Reverted previous commit
|
|
|
|
|
|
|
|
|
|
| |
* Making setEditable friendlier
The current behavior is not buggy, so this PR is an enhancement
Fixes https://github.com/vaadin/framework/issues/8718
* Improved JavaDoc
|
|
|
|
|
|
| |
* Added notes in JavaDoc of TEXTFIELD_INLINE_ICON
Fixes https://github.com/vaadin/framework/issues/10752 and https://github.com/vaadin/framework/issues/9089
|
| |
|
|
|
|
|
|
|
| |
Otherwise the changed state isn't communicated properly to the
client-side in the initial round trip, as the client-side uses the child
connector's state directly.
Fixes #11831
|
|
|
|
|
|
| |
* Eliminate un-intuitive NPE
Fixes https://github.com/vaadin/framework/issues/10947
|
|
|
|
|
|
|
|
| |
The checkbox for selecting all rows only selects all the rows that have
not been filtered out. Changing the filtering does not change the
selection or the checkbox state so assuming that all rows are selected
simply because the checkbox has been checked cannot work.
Fixes #11479
|
|
|
| |
Addresses https://github.com/vaadin/framework/issues/1262
|
|
|
|
|
| |
And corrected couple of typos
Addresses https://github.com/vaadin/framework/issues/11492
|
|
|
|
|
| |
- Row index counts up from zero, data provider size counts up from one,
as one would expect. If the two match we are already past the available
range.
|
|
|
| |
Addresses https://github.com/vaadin/framework/issues/11520
|
|
|
| |
Addresses https://github.com/vaadin/framework/issues/10277
|
|
|
|
|
|
|
|
|
|
| |
* Added note in JavaDoc of removeColumn
https://github.com/vaadin/framework/issues/11722
* Merge branch 'master' into fix11722
* Merge branch 'master' into fix11722
|
|
|
|
|
|
|
| |
(#11710)
Removal of data communicator needs to happen before call to super.remove() since super.remove() sets parent to null causing the NPE.
Fixes https://github.com/vaadin/framework/issues/11617
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updated row and spacer handling for Escalator.
Main changes:
- Spacers are only maintained and checked for rows that have DOM
representation, and not at all if there is no details generator. This
gives notable performance improvements to some particularly large Grids
- Escalator no longer tries to trim away any rows that don't fit within
the viewport just because a details row gets opened in Grid. This leads
to some increase in simultaneous DOM elements, but simplifies the logic
considerably. For example opening or closing details rows doesn't
require checking the overall content validity beyond the details row
itself anymore, but some repositioning at most. There are also no longer
any orphaned spacers without corresponding DOM rows.
- Spacers are better integrated into the overall position calculations.
- Some public methods that are no longer used by Escalator or have
changed functionality or order of operations. Any extending classes that
tap into row, spacer, or scroll position handling are likely to need
reworking after this update.
- Auto-detecting row height is delayed until Escalator is both attached
and displayed.
|
| |
|