| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
* feat: Add better API to configure maximum allowed rows
* Add unit test
Co-authored-by: Olli Tietäväinen <ollit@vaadin.com>
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
* Add row limit to DataCommunicator row data requests
* Add missing constant
* Add unit test
* Add test for extending Grid
* Fixed test
|
|
|
|
|
| |
(#12360)
This is both a optimization by skipping duplicate validation round and avoids ConcurrentModificationExpectation being thrown certain corner cases.
|
|
|
| |
#12132 fixed an old bug, conversion was not done back, which was a regression from Vaadin 7. However since the bug has been present long time, it has become established behavior, thus there may be need to disable conversion back to presentation sometimes, thus this API as added.
|
|
|
| |
See: https://vaadin.com/forum/thread/15931682
|
| |
|
|
|
|
| |
(#12091)
|
|
|
|
|
| |
Hibernate Validator 5+ requires
- Validation API 2+
- explicit Expression Language dependency
|
|
|
|
|
|
|
|
|
| |
- Enable / disable all validators on Binder level
- Enable / disable validators on Binding level
- add writeBeanAsDraft(bean,boolean) for writing draft bean with validators disabled
Fixes https://github.com/vaadin/framework/issues/10709
Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com>
|
|
|
|
|
| |
Fixes: https://github.com/vaadin/framework/issues/9933
Cherry pick from: https://github.com/vaadin/flow/pull/7317
|
|
|
|
|
| |
It is a very common use case in complex form that whether a field is required or not, it depends on input on other fields. Hypothetical use case sample could be that we have form for a Product and price of the product is needed except in case the Product's type is Sample. So in that kind of scenarios it would be needed to turn off asRequired() validation easily. The purpose of this enhancement and new binding.setAsRequiredEnabled(..) API is to help implementation of this kind of use cases more easily.
https://github.com/vaadin/framework/issues/10709
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add method writeBeanAsDraft(bean) in Binder
With current Binder implementation it is not easy to support Forms, which you want to save as draft, i.e. incomplete. For example there can be big text areas, that require time to fill, or lot of fields. Therefore it is needed to that form can be saved, e.g. to other bean in incomplete state when it is not yet passing validation and this other bean can be persisted to draft storage for further editing in the future. This method helps to achieve that easily.
* Add test case for Binder.writeBeanAsDraft(bean)
Bind a field with validator, set value that does not pass validator and save, assert that value was saved.
* Updating test
* Fixing logic flaw in test
* Further improvement of the test case
* Clarification of the JavaDoc
* Fixing typo
* JavaDoc language check
* Fixing whitespace issue
* Fixing whitespaces
* Fixing whitespaces
* Updating JavaDoc
|
|
|
|
|
|
|
|
|
|
| |
* Cherry picks of Binder fixes in Flow
Addresses: https://github.com/vaadin/framework/issues/9000
Addresses: https://github.com/vaadin/framework/issues/11109
These changes are adopted from https://github.com/vaadin/flow/pull/4138 and https://github.com/vaadin/flow/pull/6757
|
|
|
|
|
|
| |
- limit DataCommunicator workaround from #11320 to ComboBox only
- don't reset DataCommunicator before modifying all sorting data
Fixes #11532
|
|
|
|
|
|
|
|
|
| |
* Request data update before client response
* fix the accidental commit
* add tests
fixes #11320
|
| |
|
|
|
|
|
|
| |
DataProvider (#11167)
Remove objects from DataCommunicator.ActiveDataHandler that are no longer available in used DataProvider.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
(#10724)
|
|
|
| |
Fixes #9917
|
| |
|
| |
|
| |
|
|
|
|
| |
* Add missing null check to Binding
|
| |
|
| |
|
|
|
| |
Fixes #10476
|
|
|
|
|
|
|
| |
Binder.setReadonly will ignore bindings with null setter
or property without an accessible setter when changing
field read only flag.
Fixes #10252
|
|
|
|
|
|
|
|
|
| |
* Changed retrieval of names of nested properties (#10159)
The getName() function in NestedBeanPropertyDefinition will return only the top level name, which causes problems when adding a nested property that has the same name as a non-nested (e.g "value" & "sub.value")
This change should fix this behaviour by changing the return value of "getName()" of NestedBeanPropertyDefinition and introducing a function "getTopLevelName()" that only returns the last part of the full name for where it's needed
|
|
|
| |
This patch also adds ValueChangeEvent as a parameter to field value change method in Binder.
|
|
|
|
|
| |
This commit extracts the private nested class AbstractBeanPropertyDefinition from BeanPropertySet to a public class of package com.vaadin.data.
Additionally, the nested protected class PropertyFilterDefinition is extracted from NestedBeanPropertyDefinition to a public class in package com.vaadin.data.
|
|
|
| |
Fixes #9210
|
| |
|
|
|
|
|
|
|
|
|
| |
* HasItems.setItems(T... items) should allow edits
Arrays.asList() creates a immutable Arrays.ArrayList, preventing users from doing dataProvider.getItems() and updating the returned collection. This makes it impossible to keep the same data provider, update it and keep the filters & sorting, and then just call dataProvider.refreshAll() to get changes visible. We should not require users to create a new data provider in this case.
This is the same for DataProvider.ofItems(T... items)
* fix missing whitespace from test error message
|
| |
|
|
|
| |
Also use "event" as the name for events
|
|
|
|
|
| |
* Variable names to conform to naming convention.
* Use static constants where it makes sense
|
|
|
|
|
|
|
|
| |
* Use .toLowerCase and .toUpperCase(Locale.ROOT)
* Spaces
* add spaces after if(
|
|
|
|
|
|
|
|
| |
* Simplify lambda expressions
And remove unneeded 'return' keyword.
* Format
|
|
|
| |
Fixes #9792
|
| |
|
| |
|