1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
|
package com.vaadin.data;
import static org.junit.Assert.assertArrayEquals;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
import java.util.Locale;
import java.util.Objects;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.stream.Stream;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
import com.vaadin.data.Binder.Binding;
import com.vaadin.data.Binder.BindingBuilder;
import com.vaadin.data.converter.StringToIntegerConverter;
import com.vaadin.data.validator.IntegerRangeValidator;
import com.vaadin.data.validator.NotEmptyValidator;
import com.vaadin.data.validator.StringLengthValidator;
import com.vaadin.server.ErrorMessage;
import com.vaadin.shared.ui.ErrorLevel;
import com.vaadin.tests.data.bean.Person;
import com.vaadin.tests.data.bean.Sex;
import com.vaadin.ui.TextField;
public class BinderTest extends BinderTestBase<Binder<Person>, Person> {
@Before
public void setUp() {
binder = new Binder<>();
item = new Person();
item.setFirstName("Johannes");
item.setAge(32);
}
@Test
public void bindNullBean_noBeanPresent() {
binder.setBean(item);
assertNotNull(binder.getBean());
binder.setBean(null);
assertNull(binder.getBean());
}
@Test
public void bindNullBean_FieldsAreCleared() {
binder.forField(nameField).bind(Person::getFirstName,
Person::setFirstName);
binder.forField(ageField)
.withConverter(new StringToIntegerConverter(""))
.bind(Person::getAge, Person::setAge);
binder.setBean(item);
assertEquals("No name field value", "Johannes", nameField.getValue());
assertEquals("No age field value", "32", ageField.getValue());
binder.setBean(null);
assertEquals("Name field not empty", "", nameField.getValue());
assertEquals("Age field not empty", "", ageField.getValue());
}
@Test
public void clearForReadBean_boundFieldsAreCleared() {
binder.forField(nameField).bind(Person::getFirstName,
Person::setFirstName);
binder.forField(ageField)
.withConverter(new StringToIntegerConverter(""))
.bind(Person::getAge, Person::setAge);
binder.readBean(item);
assertEquals("No name field value", "Johannes", nameField.getValue());
assertEquals("No age field value", "32", ageField.getValue());
binder.readBean(null);
assertEquals("Name field not empty", "", nameField.getValue());
assertEquals("Age field not empty", "", ageField.getValue());
}
@Test
public void clearReadOnlyField_shouldClearField() {
binder.forField(nameField).bind(Person::getFirstName,
Person::setFirstName);
// Make name field read only
nameField.setReadOnly(true);
binder.setBean(item);
assertEquals("No name field value", "Johannes", nameField.getValue());
binder.setBean(null);
assertEquals("ReadOnly field not empty", "", nameField.getValue());
}
@Test
public void clearBean_setsHasChangesToFalse() {
binder.forField(nameField).bind(Person::getFirstName,
Person::setFirstName);
// Make name field read only
nameField.setReadOnly(true);
binder.readBean(item);
assertEquals("No name field value", "Johannes", nameField.getValue());
nameField.setValue("James");
assertTrue("Binder did not have value changes", binder.hasChanges());
binder.readBean(null);
assertFalse("Binder has changes after clearing all fields",
binder.hasChanges());
}
@Test
public void clearReadOnlyBinder_shouldClearFields() {
binder.forField(nameField).bind(Person::getFirstName,
Person::setFirstName);
binder.forField(ageField)
.withConverter(new StringToIntegerConverter(""))
.bind(Person::getAge, Person::setAge);
binder.setReadOnly(true);
binder.setBean(item);
binder.setBean(null);
assertEquals("ReadOnly name field not empty", "", nameField.getValue());
assertEquals("ReadOnly age field not empty", "", ageField.getValue());
}
@Test(expected = NullPointerException.class)
public void bindNullField_throws() {
binder.forField(null);
}
@Test(expected = NullPointerException.class)
public void bindNullGetter_throws() {
binder.bind(nameField, null, Person::setFirstName);
}
@Test
public void fieldBound_bindItem_fieldValueUpdated() {
binder.forField(nameField).bind(Person::getFirstName,
Person::setFirstName);
binder.setBean(item);
assertEquals("Johannes", nameField.getValue());
}
@Test
public void fieldBoundWithShortcut_bindBean_fieldValueUpdated() {
bindName();
assertEquals("Johannes", nameField.getValue());
}
@Test
public void beanBound_updateFieldValue_beanValueUpdated() {
binder.setBean(item);
binder.bind(nameField, Person::getFirstName, Person::setFirstName);
assertEquals("Johannes", nameField.getValue());
nameField.setValue("Artur");
assertEquals("Artur", item.getFirstName());
}
@Test
public void bound_getBean_returnsBoundBean() {
assertNull(binder.getBean());
binder.setBean(item);
assertSame(item, binder.getBean());
}
@Test
public void unbound_getBean_returnsNothing() {
binder.setBean(item);
binder.removeBean();
assertNull(binder.getBean());
}
@Test
public void bound_changeFieldValue_beanValueUpdated() {
bindName();
nameField.setValue("Henri");
assertEquals("Henri", item.getFirstName());
}
@Test
public void unbound_changeFieldValue_beanValueNotUpdated() {
bindName();
nameField.setValue("Henri");
binder.removeBean();
nameField.setValue("Aleksi");
assertEquals("Henri", item.getFirstName());
}
@Test
public void bindNullSetter_valueChangesIgnored() {
binder.bind(nameField, Person::getFirstName, null);
binder.setBean(item);
nameField.setValue("Artur");
assertEquals(item.getFirstName(), "Johannes");
}
@Test
public void bound_bindToAnotherBean_stopsUpdatingOriginal() {
bindName();
nameField.setValue("Leif");
Person p2 = new Person();
p2.setFirstName("Marlon");
binder.setBean(p2);
assertEquals("Marlon", nameField.getValue());
assertEquals("Leif", item.getFirstName());
assertSame(p2, binder.getBean());
nameField.setValue("Ilia");
assertEquals("Ilia", p2.getFirstName());
assertEquals("Leif", item.getFirstName());
}
@Test
public void save_unbound_noChanges() throws ValidationException {
Binder<Person> binder = new Binder<>();
Person person = new Person();
int age = 10;
person.setAge(age);
binder.writeBean(person);
assertEquals(age, person.getAge());
}
@Test
public void save_bound_beanIsUpdated() throws ValidationException {
Binder<Person> binder = new Binder<>();
binder.bind(nameField, Person::getFirstName, Person::setFirstName);
Person person = new Person();
String fieldValue = "bar";
nameField.setValue(fieldValue);
person.setFirstName("foo");
binder.writeBean(person);
assertEquals(fieldValue, person.getFirstName());
}
@Test
public void load_bound_fieldValueIsUpdated() {
binder.bind(nameField, Person::getFirstName, Person::setFirstName);
Person person = new Person();
String name = "bar";
person.setFirstName(name);
binder.readBean(person);
assertEquals(name, nameField.getValue());
}
@Test
public void load_unbound_noChanges() {
nameField.setValue("");
Person person = new Person();
String name = "bar";
person.setFirstName(name);
binder.readBean(person);
assertEquals("", nameField.getValue());
}
protected void bindName() {
binder.bind(nameField, Person::getFirstName, Person::setFirstName);
binder.setBean(item);
}
@Test
public void binding_with_null_representation() {
String nullRepresentation = "Some arbitrary text";
String realName = "John";
Person namelessPerson = new Person(null, "Doe", "", 25, Sex.UNKNOWN,
null);
binder.forField(nameField).withNullRepresentation(nullRepresentation)
.bind(Person::getFirstName, Person::setFirstName);
// Bind a person with null value and check that null representation is
// used
binder.setBean(namelessPerson);
assertEquals(
"Null value from bean was not converted to explicit null representation",
nullRepresentation, nameField.getValue());
// Verify that changes are applied to bean
nameField.setValue(realName);
assertEquals(
"Bean was not correctly updated from a change in the field",
realName, namelessPerson.getFirstName());
// Verify conversion back to null
nameField.setValue(nullRepresentation);
assertEquals(
"Two-way null representation did not change value back to null",
null, namelessPerson.getFirstName());
}
@Test
public void binding_with_default_null_representation() {
TextField nullTextField = new TextField() {
@Override
public String getEmptyValue() {
return "null";
}
};
Person namelessPerson = new Person(null, "Doe", "", 25, Sex.UNKNOWN,
null);
binder.bind(nullTextField, Person::getFirstName, Person::setFirstName);
binder.setBean(namelessPerson);
assertTrue(nullTextField.isEmpty());
assertEquals(null, namelessPerson.getFirstName());
// Change value, see that textfield is not empty and bean is updated.
nullTextField.setValue("");
assertFalse(nullTextField.isEmpty());
assertEquals("First name of person was not properly updated", "",
namelessPerson.getFirstName());
// Verify that default null representation does not map back to null
nullTextField.setValue("null");
assertTrue(nullTextField.isEmpty());
assertEquals("Default one-way null representation failed.", "null",
namelessPerson.getFirstName());
}
@Test
public void binding_with_null_representation_value_not_null() {
String nullRepresentation = "Some arbitrary text";
binder.forField(nameField).withNullRepresentation(nullRepresentation)
.bind(Person::getFirstName, Person::setFirstName);
assertFalse("First name in item should not be null",
Objects.isNull(item.getFirstName()));
binder.setBean(item);
assertEquals("Field value was not set correctly", item.getFirstName(),
nameField.getValue());
}
@Test
public void withConverter_disablesDefaulNullRepresentation() {
Integer customNullConverter = 0;
binder.forField(ageField).withNullRepresentation("foo")
.withConverter(new StringToIntegerConverter(""))
.withConverter(age -> age,
age -> age == null ? customNullConverter : age)
.bind(Person::getSalary, Person::setSalary);
binder.setBean(item);
assertEquals(customNullConverter.toString(), ageField.getValue());
Integer salary = 11;
ageField.setValue(salary.toString());
assertEquals(11, salary.intValue());
}
@Test
public void beanBinder_nullRepresentationIsNotDisabled() {
Binder<Person> binder = new Binder<>(Person.class);
binder.forField(nameField).bind("firstName");
Person person = new Person();
binder.setBean(person);
assertEquals("", nameField.getValue());
}
@Test
public void beanBinder_withConverter_nullRepresentationIsNotDisabled() {
String customNullPointerRepresentation = "foo";
Binder<Person> binder = new Binder<>(Person.class);
binder.forField(nameField)
.withConverter(value -> value,
value -> value == null ? customNullPointerRepresentation
: value)
.bind("firstName");
Person person = new Person();
binder.setBean(person);
assertEquals(customNullPointerRepresentation, nameField.getValue());
}
@Test
public void withValidator_doesNotDisablesDefaulNullRepresentation() {
String nullRepresentation = "foo";
binder.forField(nameField).withNullRepresentation(nullRepresentation)
.withValidator(new NotEmptyValidator<>(""))
.bind(Person::getFirstName, Person::setFirstName);
item.setFirstName(null);
binder.setBean(item);
assertEquals(nullRepresentation, nameField.getValue());
String newValue = "bar";
nameField.setValue(newValue);
assertEquals(newValue, item.getFirstName());
}
@Test
public void setRequired_withErrorMessage_fieldGetsRequiredIndicatorAndValidator() {
TextField textField = new TextField();
assertFalse(textField.isRequiredIndicatorVisible());
BindingBuilder<Person, String> binding = binder.forField(textField);
assertFalse(textField.isRequiredIndicatorVisible());
binding.asRequired("foobar");
assertTrue(textField.isRequiredIndicatorVisible());
binding.bind(Person::getFirstName, Person::setFirstName);
binder.setBean(item);
assertNull(textField.getErrorMessage());
textField.setValue(textField.getEmptyValue());
ErrorMessage errorMessage = textField.getErrorMessage();
assertNotNull(errorMessage);
assertEquals("foobar", errorMessage.getFormattedHtmlMessage());
textField.setValue("value");
assertNull(textField.getErrorMessage());
assertTrue(textField.isRequiredIndicatorVisible());
}
@Test
public void readNullBeanRemovesError() {
TextField textField = new TextField();
binder.forField(textField).asRequired("foobar")
.bind(Person::getFirstName, Person::setFirstName);
assertTrue(textField.isRequiredIndicatorVisible());
assertNull(textField.getErrorMessage());
binder.readBean(item);
assertNull(textField.getErrorMessage());
textField.setValue(textField.getEmptyValue());
assertTrue(textField.isRequiredIndicatorVisible());
assertNotNull(textField.getErrorMessage());
binder.readBean(null);
assertTrue(textField.isRequiredIndicatorVisible());
assertNull(textField.getErrorMessage());
}
@Test
public void setRequired_withErrorMessageProvider_fieldGetsRequiredIndicatorAndValidator() {
TextField textField = new TextField();
textField.setLocale(Locale.CANADA);
assertFalse(textField.isRequiredIndicatorVisible());
BindingBuilder<Person, String> binding = binder.forField(textField);
assertFalse(textField.isRequiredIndicatorVisible());
AtomicInteger invokes = new AtomicInteger();
binding.asRequired(context -> {
invokes.incrementAndGet();
assertSame(Locale.CANADA, context.getLocale().get());
return "foobar";
});
assertTrue(textField.isRequiredIndicatorVisible());
binding.bind(Person::getFirstName, Person::setFirstName);
binder.setBean(item);
assertNull(textField.getErrorMessage());
assertEquals(0, invokes.get());
textField.setValue(textField.getEmptyValue());
ErrorMessage errorMessage = textField.getErrorMessage();
assertNotNull(errorMessage);
assertEquals("foobar", errorMessage.getFormattedHtmlMessage());
// validation is done for all changed bindings once.
assertEquals(1, invokes.get());
textField.setValue("value");
assertNull(textField.getErrorMessage());
assertTrue(textField.isRequiredIndicatorVisible());
}
@Test
public void validationStatusHandler_onlyRunForChangedField() {
TextField firstNameField = new TextField();
TextField lastNameField = new TextField();
AtomicInteger invokes = new AtomicInteger();
binder.forField(firstNameField)
.withValidator(new NotEmptyValidator<>(""))
.withValidationStatusHandler(
validationStatus -> invokes.addAndGet(1))
.bind(Person::getFirstName, Person::setFirstName);
binder.forField(lastNameField)
.withValidator(new NotEmptyValidator<>(""))
.bind(Person::getLastName, Person::setLastName);
binder.setBean(item);
// setting the bean causes 2:
assertEquals(2, invokes.get());
lastNameField.setValue("");
assertEquals(2, invokes.get());
firstNameField.setValue("");
assertEquals(3, invokes.get());
binder.removeBean();
Person person = new Person();
person.setFirstName("a");
person.setLastName("a");
binder.readBean(person);
// reading from a bean causes 2:
assertEquals(5, invokes.get());
lastNameField.setValue("");
assertEquals(5, invokes.get());
firstNameField.setValue("");
assertEquals(6, invokes.get());
}
@Test(expected = IllegalStateException.class)
public void noArgsConstructor_stringBind_throws() {
binder.bind(new TextField(), "firstName");
}
@Test
public void setReadOnly_unboundBinder() {
binder.forField(nameField).bind(Person::getFirstName,
Person::setFirstName);
binder.forField(ageField);
binder.setReadOnly(true);
assertTrue(nameField.isReadOnly());
assertFalse(ageField.isReadOnly());
binder.setReadOnly(false);
assertFalse(nameField.isReadOnly());
assertFalse(ageField.isReadOnly());
}
@Test
public void setReadOnly_boundBinder() {
binder.forField(nameField).bind(Person::getFirstName,
Person::setFirstName);
binder.forField(ageField)
.withConverter(new StringToIntegerConverter(""))
.bind(Person::getAge, Person::setAge);
binder.setBean(new Person());
binder.setReadOnly(true);
assertTrue(nameField.isReadOnly());
assertTrue(ageField.isReadOnly());
binder.setReadOnly(false);
assertFalse(nameField.isReadOnly());
assertFalse(ageField.isReadOnly());
}
@Test
public void setReadOnly_binderLoadedByReadBean() {
binder.forField(nameField).bind(Person::getFirstName,
Person::setFirstName);
binder.forField(ageField)
.withConverter(new StringToIntegerConverter(""))
.bind(Person::getAge, Person::setAge);
binder.readBean(new Person());
binder.setReadOnly(true);
assertTrue(nameField.isReadOnly());
assertTrue(ageField.isReadOnly());
binder.setReadOnly(false);
assertFalse(nameField.isReadOnly());
assertFalse(ageField.isReadOnly());
}
@Test
public void setReadonlyShouldIgnoreBindingsWithNullSetter() {
binder.bind(nameField, Person::getFirstName, null);
binder.forField(ageField)
.withConverter(new StringToIntegerConverter(""))
.bind(Person::getAge, Person::setAge);
binder.setReadOnly(true);
assertTrue("Name field should be ignored but should be readonly", nameField.isReadOnly());
assertTrue("Age field should be readonly", ageField.isReadOnly());
binder.setReadOnly(false);
assertTrue("Name field should be ignored and should remain readonly", nameField.isReadOnly());
assertFalse("Age field should not be readonly", ageField.isReadOnly());
nameField.setReadOnly(false);
binder.setReadOnly(false);
assertFalse("Name field should be ignored and remain not readonly", nameField.isReadOnly());
assertFalse("Age field should not be readonly", ageField.isReadOnly());
binder.setReadOnly(true);
assertFalse("Name field should be ignored and remain not readonly", nameField.isReadOnly());
assertTrue("Age field should be readonly", ageField.isReadOnly());
}
@Test
public void isValidTest_bound_binder() {
binder.forField(nameField)
.withValidator(Validator.from(
name -> !name.equals("fail field validation"), ""))
.bind(Person::getFirstName, Person::setFirstName);
binder.withValidator(Validator.from(
person -> !person.getFirstName().equals("fail bean validation"),
""));
binder.setBean(item);
assertTrue(binder.isValid());
nameField.setValue("fail field validation");
assertFalse(binder.isValid());
nameField.setValue("");
assertTrue(binder.isValid());
nameField.setValue("fail bean validation");
assertFalse(binder.isValid());
}
@Test
public void isValidTest_unbound_binder() {
binder.forField(nameField)
.withValidator(Validator.from(
name -> !name.equals("fail field validation"), ""))
.bind(Person::getFirstName, Person::setFirstName);
assertTrue(binder.isValid());
nameField.setValue("fail field validation");
assertFalse(binder.isValid());
nameField.setValue("");
assertTrue(binder.isValid());
}
@Test(expected = IllegalStateException.class)
public void isValidTest_unbound_binder_throws_with_bean_level_validation() {
binder.forField(nameField).bind(Person::getFirstName,
Person::setFirstName);
binder.withValidator(Validator.from(
person -> !person.getFirstName().equals("fail bean validation"),
""));
binder.isValid();
}
@Test
public void getFields_returnsFields() {
assertEquals(0, binder.getFields().count());
binder.forField(nameField).bind(Person::getFirstName,
Person::setFirstName);
assertStreamEquals(Stream.of(nameField), binder.getFields());
binder.forField(ageField)
.withConverter(new StringToIntegerConverter(""))
.bind(Person::getAge, Person::setAge);
assertStreamEquals(Stream.of(nameField, ageField), binder.getFields());
}
private void assertStreamEquals(Stream<?> s1, Stream<?> s2) {
assertArrayEquals(s1.toArray(), s2.toArray());
}
@Test
public void multiple_calls_to_same_binding_builder() {
String stringLength = "String length failure";
String conversion = "Conversion failed";
String ageLimit = "Age not in valid range";
BindingValidationStatus validation;
binder = new Binder<>(Person.class);
BindingBuilder builder = binder.forField(ageField);
builder.withValidator(new StringLengthValidator(stringLength, 0, 3));
builder.withConverter(new StringToIntegerConverter(conversion));
builder.withValidator(new IntegerRangeValidator(ageLimit, 3, 150));
Binding<Person, ?> bind = builder.bind("age");
binder.setBean(item);
ageField.setValue("123123");
validation = bind.validate();
assertTrue(validation.isError());
assertEquals(stringLength, validation.getMessage().get());
ageField.setValue("age");
validation = bind.validate();
assertTrue(validation.isError());
assertEquals(conversion, validation.getMessage().get());
ageField.setValue("256");
validation = bind.validate();
assertTrue(validation.isError());
assertEquals(ageLimit, validation.getMessage().get());
ageField.setValue("30");
validation = bind.validate();
assertFalse(validation.isError());
assertEquals(30, item.getAge());
}
@Test
public void remove_field_binding() {
binder.forField(ageField)
.withConverter(new StringToIntegerConverter("Can't convert"))
.bind(Person::getAge, Person::setAge);
// Test that the binding does work
assertTrue("Field not initially empty", ageField.isEmpty());
binder.setBean(item);
assertEquals("Binding did not work", String.valueOf(item.getAge()),
ageField.getValue());
binder.setBean(null);
assertTrue("Field not cleared", ageField.isEmpty());
// Remove the binding
binder.removeBinding(ageField);
// Test that it does not work anymore
binder.setBean(item);
assertNotEquals("Binding was not removed",
String.valueOf(item.getAge()), ageField.getValue());
}
@Test
public void remove_propertyname_binding() {
// Use a bean aware binder
Binder<Person> binder = new Binder<>(Person.class);
binder.bind(nameField, "firstName");
// Test that the binding does work
assertTrue("Field not initially empty", nameField.isEmpty());
binder.setBean(item);
assertEquals("Binding did not work", item.getFirstName(),
nameField.getValue());
binder.setBean(null);
assertTrue("Field not cleared", nameField.isEmpty());
// Remove the binding
binder.removeBinding("firstName");
// Test that it does not work anymore
binder.setBean(item);
assertNotEquals("Binding was not removed", item.getFirstName(),
nameField.getValue());
}
@Test
public void remove_binding() {
Binding<Person, Integer> binding = binder.forField(ageField)
.withConverter(new StringToIntegerConverter("Can't convert"))
.bind(Person::getAge, Person::setAge);
// Test that the binding does work
assertTrue("Field not initially empty", ageField.isEmpty());
binder.setBean(item);
assertEquals("Binding did not work", String.valueOf(item.getAge()),
ageField.getValue());
binder.setBean(null);
assertTrue("Field not cleared", ageField.isEmpty());
// Remove the binding
binder.removeBinding(binding);
// Test that it does not work anymore
binder.setBean(item);
assertNotEquals("Binding was not removed",
String.valueOf(item.getAge()), ageField.getValue());
}
@Test
public void beanvalidation_two_fields_not_equal() {
TextField lastNameField = new TextField();
setBeanValidationFirstNameNotEqualsLastName(nameField, lastNameField);
item.setLastName("Valid");
binder.setBean(item);
assertFalse("Should not have changes initially", binder.hasChanges());
assertTrue("Should be ok initially", binder.validate().isOk());
assertNotEquals("First name and last name are not same initially",
item.getFirstName(), item.getLastName());
nameField.setValue("Invalid");
assertFalse("First name change not handled", binder.hasChanges());
assertTrue(
"Changing first name to something else than last name should be ok",
binder.validate().isOk());
lastNameField.setValue("Invalid");
assertTrue("Last name should not be saved yet", binder.hasChanges());
assertFalse("Binder validation should fail with pending illegal value",
binder.validate().isOk());
assertNotEquals("Illegal last name should not be stored to bean",
item.getFirstName(), item.getLastName());
nameField.setValue("Valid");
assertFalse("With new first name both changes should be saved",
binder.hasChanges());
assertTrue("Everything should be ok for 'Valid Invalid'",
binder.validate().isOk());
assertNotEquals("First name and last name should never match.",
item.getFirstName(), item.getLastName());
}
@Test
public void beanvalidation_initially_broken_bean() {
TextField lastNameField = new TextField();
setBeanValidationFirstNameNotEqualsLastName(nameField, lastNameField);
item.setLastName(item.getFirstName());
binder.setBean(item);
assertFalse(binder.isValid());
assertFalse(binder.validate().isOk());
}
@Test(expected = IllegalStateException.class)
public void beanvalidation_isValid_throws_with_readBean() {
TextField lastNameField = new TextField();
setBeanValidationFirstNameNotEqualsLastName(nameField, lastNameField);
binder.readBean(item);
assertTrue(binder.isValid());
}
@Test(expected = IllegalStateException.class)
public void beanvalidation_validate_throws_with_readBean() {
TextField lastNameField = new TextField();
setBeanValidationFirstNameNotEqualsLastName(nameField, lastNameField);
binder.readBean(item);
assertTrue(binder.validate().isOk());
}
protected void setBeanValidationFirstNameNotEqualsLastName(
TextField firstNameField, TextField lastNameField) {
binder.bind(firstNameField, Person::getFirstName, Person::setFirstName);
binder.forField(lastNameField)
.withValidator(t -> !"foo".equals(t),
"Last name cannot be 'foo'")
.bind(Person::getLastName, Person::setLastName);
binder.withValidator(p -> !p.getFirstName().equals(p.getLastName()),
"First name and last name can't be the same");
}
static class MyBindingHandler implements BindingValidationStatusHandler {
boolean expectingError = false;
int callCount = 0;
@Override
public void statusChange(BindingValidationStatus<?> statusChange) {
++callCount;
if (expectingError) {
assertTrue("Expecting error", statusChange.isError());
} else {
assertFalse("Unexpected error", statusChange.isError());
}
}
}
@Test
public void execute_binding_status_handler_from_binder_status_handler() {
MyBindingHandler bindingHandler = new MyBindingHandler();
binder.forField(nameField)
.withValidator(t -> !t.isEmpty(), "No empty values.")
.withValidationStatusHandler(bindingHandler)
.bind(Person::getFirstName, Person::setFirstName);
String ageError = "CONVERSIONERROR";
binder.forField(ageField)
.withConverter(new StringToIntegerConverter(ageError))
.bind(Person::getAge, Person::setAge);
binder.setValidationStatusHandler(
status -> status.notifyBindingValidationStatusHandlers());
String initialName = item.getFirstName();
int initialAge = item.getAge();
binder.setBean(item);
// Test specific error handling.
bindingHandler.expectingError = true;
nameField.setValue("");
// Test default error handling.
ageField.setValue("foo");
assertTrue("Component error does not contain error message",
ageField.getComponentError().getFormattedHtmlMessage()
.contains(ageError));
// Restore values and test no errors.
ageField.setValue(String.valueOf(initialAge));
assertNull("There should be no component error",
ageField.getComponentError());
bindingHandler.expectingError = false;
nameField.setValue(initialName);
// Assert that the handler was called.
assertEquals(
"Unexpected callCount to binding validation status handler", 6,
bindingHandler.callCount);
}
@Test
public void removed_binding_not_updates_value() {
Binding<Person, Integer> binding = binder.forField(ageField)
.withConverter(new StringToIntegerConverter("Can't convert"))
.bind(Person::getAge, Person::setAge);
binder.setBean(item);
String modifiedAge = String.valueOf(item.getAge() + 10);
String ageBeforeUnbind = String.valueOf(item.getAge());
binder.removeBinding(binding);
ageField.setValue(modifiedAge);
assertEquals("Binding still affects bean even after unbind",
ageBeforeUnbind, String.valueOf(item.getAge()));
}
@Test
public void info_validator_not_considered_error() {
String infoMessage = "Young";
binder.forField(ageField)
.withConverter(new StringToIntegerConverter("Can't convert"))
.withValidator(i -> i > 5, infoMessage, ErrorLevel.INFO)
.bind(Person::getAge, Person::setAge);
binder.setBean(item);
ageField.setValue("3");
Assert.assertEquals(infoMessage,
ageField.getComponentError().getFormattedHtmlMessage());
Assert.assertEquals(ErrorLevel.INFO,
ageField.getComponentError().getErrorLevel());
Assert.assertEquals(3, item.getAge());
}
@Test
public void two_asRequired_fields_without_initial_values() {
binder.forField(nameField).asRequired("Empty name").bind(p -> "",
(p, s) -> {
});
binder.forField(ageField).asRequired("Empty age").bind(p -> "",
(p, s) -> {
});
binder.setBean(item);
assertNull("Initially there should be no errors",
nameField.getComponentError());
assertNull("Initially there should be no errors",
ageField.getComponentError());
nameField.setValue("Foo");
assertNull("Name with a value should not be an error",
nameField.getComponentError());
assertNull(
"Age field should not be in error, since it has not been modified.",
ageField.getComponentError());
nameField.setValue("");
assertNotNull("Empty name should now be in error.",
nameField.getComponentError());
assertNull("Age field should still be ok.",
ageField.getComponentError());
}
@Test
public void refreshValueFromBean() {
Binding<Person, String> binding = binder.bind(nameField,
Person::getFirstName, Person::setFirstName);
binder.readBean(item);
assertEquals("Name should be read from the item", item.getFirstName(),
nameField.getValue());
nameField.setValue("foo");
assertNotEquals("Name should be different from the item",
item.getFirstName(), nameField.getValue());
binding.read(item);
assertEquals("Name should be read again from the item",
item.getFirstName(), nameField.getValue());
}
@Test(expected = IllegalArgumentException.class)
public void remove_binding_from_different_binder() {
Binder<Person> anotherBinder = new Binder<>();
Binding<Person, String> binding = anotherBinder.bind(nameField,
Person::getFirstName, Person::setFirstName);
binder.removeBinding(binding);
}
@Test
public void bindWithNullSetterShouldMarkFieldAsReadonly() {
binder.bind(nameField, Person::getFirstName, null);
binder.forField(ageField)
.withConverter(new StringToIntegerConverter(""))
.bind(Person::getAge, Person::setAge);
assertTrue("Name field should be readonly", nameField.isReadOnly());
assertFalse("Name field should be readonly", ageField.isReadOnly());
}
}
|