diff options
Diffstat (limited to 'src/java/org/apache/fop')
-rw-r--r-- | src/java/org/apache/fop/apps/FopFactoryBuilder.java | 13 | ||||
-rw-r--r-- | src/java/org/apache/fop/apps/FopFactoryConfig.java | 3 |
2 files changed, 15 insertions, 1 deletions
diff --git a/src/java/org/apache/fop/apps/FopFactoryBuilder.java b/src/java/org/apache/fop/apps/FopFactoryBuilder.java index 6c3da57f3..d062b2f8a 100644 --- a/src/java/org/apache/fop/apps/FopFactoryBuilder.java +++ b/src/java/org/apache/fop/apps/FopFactoryBuilder.java @@ -97,6 +97,17 @@ public final class FopFactoryBuilder { * @deprecated Exposing the {@link FopFactoryConfig} is only to maintain backwards compatibility */ public FopFactoryConfig buildConfig() { + return buildConfiguration(); + } + + /** + * Builds the configuration object used by the FopFactory. + * + * @return the config for the {@link FopFactory} + */ + // The {@link FopFactoryConfig} doesn't need to be exposed in the "public" API, this method + // should remain package private. + FopFactoryConfig buildConfiguration() { fopFactoryConfigBuilder = CompletedFopFactoryConfigBuilder.INSTANCE; return config; } @@ -107,7 +118,7 @@ public final class FopFactoryBuilder { * @return the FopFactory instance */ public FopFactory build() { - return FopFactory.newInstance(buildConfig()); + return FopFactory.newInstance(buildConfiguration()); } /** diff --git a/src/java/org/apache/fop/apps/FopFactoryConfig.java b/src/java/org/apache/fop/apps/FopFactoryConfig.java index 2545eea5e..77da111cc 100644 --- a/src/java/org/apache/fop/apps/FopFactoryConfig.java +++ b/src/java/org/apache/fop/apps/FopFactoryConfig.java @@ -34,6 +34,9 @@ import org.apache.fop.layoutmgr.LayoutManagerMaker; /** * The configuration data for a {@link FopFactory} instance. */ +// TODO: Make this interface and any implementations of this interface package private. Though +// they are used by classes that are considered the public API, this object doesn't need to be a +// part of the API. Why would a user care how the internal objects are passed around? They shouldn't. public interface FopFactoryConfig { /** Defines if FOP should use an alternative rule to determine text indents */ |