summaryrefslogtreecommitdiffstats
path: root/src/main/java/com/gitblit/wicket/panels
Commit message (Collapse)AuthorAgeFilesLines
* fix: Correct misaligned images in primary repository URL displayFlorian Zschocke2022-12-051-2/+2
| | | | | | Adding style element `max-width:inherit` as suggested by @piradix, which makes the access restriction icon be part of the URL box again. This fixes #1437
* Add a "Copied" tooltip to the copy-to-clipboard buttonFlorian Zschocke2022-12-031-4/+6
| | | | | | | This is not the ideal version, since the height is too low for the tooltip used for the drop-down menus. Probably has something to do with the container or something. But at least something is there now, even if not the most beautiful.
* Replace SWF clippy with clipboardjs on repository pageFlorian Zschocke2022-11-202-23/+19
| | | | | | | | | | | | | | | Shockwave Flash is dead. But Gitblit still uses it to copy the repository URLs to the clip board. Which doesn't work anymore since no browser uses Flash anymore, so this has degraded disgracefully. Instead, we can use JavaScript to copy directly to the clipboard, now that there are APIs for it. So replace the use of clippy.swf on the repository page with clipboard.js[1]. This right now only has the functionality to copy to clipboard but now visual feedback, yet. This addresses GH issue #1241. [1] https://clipboardjs.com
* Fix issue with not serialisable ed25519 SSH keysFlorian Zschocke2022-11-161-1/+23
| | | | | | | | | Adding Ed25519 keys brings the problem that with the library currently used, the PublicKey instance of that key is not serialisable. This results in an exception when wicket tries to cache the UsersPage. So change the SshKeysPanel so that the PublicKey object is removed from the `SshKey` when the panel is detached. It can be regenerated from the raw key data.
* Replace key feedback with label instead of FeedbackMessageFlorian Zschocke2022-11-012-5/+17
| | | | | | Since it is a pest to get rid of a Wicket FeedbackMessage in an AJAX target, change the code to use an extra label that can provide feedback if the key could not be parsed or was empty.
* Add feedback to SSH Key Form. #1226Martin Spielmann2022-11-011-0/+4
| | | | | if key is empty of can not be parsed, form did provide any feedback to user before
* Issue #1011: do not serialize JGit commit objectsTom2021-11-033-36/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | JGit commit objects are a recursive data structure; they have links to their parent commits. Serializing a JGit commit will try to recursively serialize all reachable ancestors as faras they have been loaded. If that ancestor chain is too long, a StackOverflowError is thrown during Wicket's page serialization if a page has a reference to sucha JGit commit. Fixed by making sure that pages o not contain references to JGit commits. Use the (existing) wrapper object RepositoryCommit instead. * RepositoryCommit has a transient reference to the JGit commit and reads the commit from the repository upon de-serialization. * RefModel is a similar case (JGit tags/branches may also have links to the commits they point to). Solved a bit differently by making it a pure data object by transferring the interesting data from the JGit object in the constructor. * Change DataViews instantiated with RevCommit to use RepositoryCommit instead. * Change inner anonymous DataViews to ensure they do not have a synthesized field referencing the "allRefs" map. Such a synthesized field would also get serialized, and then serialize JGit commits again. Finally, remove non-transient logger instances in Wicket classes. Those might lead to NotSerializableException. These StackOverflowErrors have been reported in several places since 2014: * https://groups.google.com/forum/#!topic/gitblit/GH1d8WSlR6Q * https://bugs.chromium.org/p/gerrit/issues/detail?id=3316 * https://groups.google.com/d/msg/repo-discuss/Kcl0JIGNiGk/0DjH4mO8hA8J * https://groups.google.com/d/msg/repo-discuss/0_P6A3fjTec/2kcpVPIUAQAJ * https://github.com/gitblit/gitblit/issues/1011 * https://github.com/tomaswolf/gerrit-gitblit-plugin/issues/21
* fix: Remove duplicate property keys from properties filesFlorian Zschocke2021-10-211-1/+1
| | | | | | | | | | Some property keys were duplicated, mostly `status`, `permission` and `comment`. The problem with `gb.comment` is, that it is used in two different locations in two different meanings. One as a verb, the second as a noun. Which makes no difference in English, but other languages. The solution is that the second key is renamed to `gb.sshKeyComment`. The code is adjusted accordingly.
* Remove "folding outlines" and sort repositories before subfolders.Florian Zschocke2019-06-152-19/+21
| | | | | | | | Remove guard rails at the left to get a cleaner look. To make it easier to determine which repositories belong to which folder, display the repositories first, then the subfolder. Decreased indentation a little.
* Add support nested groups on the Repositories pageFlorian Zschocke2019-06-154-5/+368
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix for #725. Also covers #527. This is a squashed commit of the following commits, merging and closing pull request #1267: commit 55fee41769ffab1aff59344fe117d481687aa743 Author: Martin Spielmann <mail@martinspielmann.de> Date: Mon Nov 6 17:19:53 2017 +0100 declared local variable final to fix travis build commit 131e4d14a48c2a3fdce621fa54637de50684d040 Author: Martin Spielmann <mail@martinspielmann.de> Date: Mon Nov 6 14:11:55 2017 +0100 fix formatting (use tab for identation) commit 8da5f6d5967894f157251c320928acdab3a451e7 Author: Martin Spielmann <mail@martinspielmann.de> Date: Mon Nov 6 13:45:39 2017 +0100 Add repositoryListType tree. Addresses #725, 527 and includes #1224 commit 6c061651fb95212ae242dbca06c8d9ef80146201 Merge: f365daa3 40ee9653 Author: Martin Spielmann <mail@martinspielmann.de> Date: Sat Nov 4 13:19:08 2017 +0100 Merge remote-tracking branch 'collapsible/ticket/527' into 725_nested_repos commit f365daa3b1d6be135365f9b11bdece320beabf4e Author: Martin Spielmann <mail@martinspielmann.de> Date: Sat Nov 4 13:10:24 2017 +0100 first working version of tree model
* collapsible group repositoriesybosy2019-06-152-2/+58
|
* Merge pull request #1160 from fzs/sshLdapAuthenticatorFlorian Zschocke2016-12-181-0/+9
|\ | | | | LDAP SSH key manager
| * The public key manager can disable writing keys, which hides commandsFlorian Zschocke2016-12-061-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some public key mangers may be read-only, i.e. not allow to add or delete keys, or to change the key comment or assigned permissions. In such a case the respective commands should not be available on the SSH shell and the SSH Keys panel should also not offer the possibility. The `IPublicKeyManager` gets three new methods, modelled after the `AuthenticationManager`: `supportsWritingKeys`, `supportsCommentChanges` and `supportsPermissionChanges`. They return true if a key manager allows for keys to be written or updated. For example the existing `FileKeyManager` will return true for all three since it allows to store and update keys in a file. The new `LdapKeyManager` returns false since it only accesses LDAP and can not add or update any keys in the directory. A future key manager might get keys from an LDAP directory but still keep comments and permissions for it in a local copy. If writing of keys is not supported: * the welcome shell does not suggest adding a key, * the `SshKeysDispatcher` does not offer the "add", "remove", "comment" and "permission" commands, and * the SSH keys panel hides the "delete" button in the key list, and the "Add Key" form. The hiding of the "Add key" form is not perfect since the surrounding div is still shown, but I don't know how to hide it and it didn't look too bad, either.
* | Fix disabled links in PagerPanelTom2016-10-311-2/+3
|/ | | | | | | | | | | Disabled links in the PagerPanel (used on the LuceneSearchPage to page through search results) were only rendered as "disabled". The links themselves remained active, which gives strange effects when clicked. For instance it was possible to move to result pages -1, -2, and so on. Really disable the links. Add missing CSS rules to have correct styling as Wicket renders disabled links as spans, not anchors. Include the new CSS file in BasePage.html. And add the left/right arrows only if not on the first/last page.
* Fix for #1018 and #1025 browser LFS linksPaul Martin2016-03-211-0/+22
| | | | | + View and Raw both download the actual file + Blame will show the metafile
* Fix for #976 - Filestore links via browserPaul Martin2015-12-251-1/+1
| | | | | | | | | | | | | + GitLFS client support + FilestoreModel now parses meta file + Read meta heading from cache if available + Authentication based on accept headers for browser view filestore login + PathModel & PathChangeModel now understands filestore items + Zip & Rar downloads contain include filestore items + Filestore servlet returns LFS JSON error only if accepted by client + DiffStat now knows repository to allow identification of filestore items + Filestore items identified and returned via view, raw & blob links on blame, commitDiff, commit and Tree pages
* Use author date to be consistent with other tools (fixes #919)James Moger2015-09-183-3/+3
|
* fix feed link from user's repository pageJoel Johnson2015-07-141-1/+2
|
* Merge pull request #284 from mrjoel/mrjoel-useshortrefsJames Moger2015-07-042-18/+14
|\ | | | | prefer shortened refs for cleaner/shorter URLs
| * prefer shortened refs for cleaner/shorter URLsJoel Johnson2015-07-012-18/+14
| |
* | allow advertising gitblit privileges for external URLsJoel Johnson2015-07-011-18/+18
|/ | | | | | | | | | | | | | | | commit c20191fc0931a19bec0df1ab2b56f287e5d8b7c7 enabled support for hiding internal URLs, but didn't consider that it broke the evaluation of permissions (used for tickets, etc.), and caused a NPE on repoUrl.permission when trying to view the TicketPage. With all internal mechanisms disabled, it would result in the first URL being external with unknown permissions. This adds an option to use internal permissions even for external URLs. Note that this does not grant any additional permissions, but does offer the option to have gitblit advertise the full set of what is allowed, even if the external URL imposes additional restrictions.
* Merged #258 "Create an avatar provider that defaults to Gravatar"James Moger2015-06-159-21/+16
|\
| * Revised AvatarGenerator to be injectableJames Moger2015-06-151-1/+3
| |
| * First draft for a customized avatar imageFabrice Bacchella2015-06-159-21/+14
| |
* | Bump to JGit 4.0.0Luca Milanesio2015-06-121-1/+1
|/ | | | | JGit 4.0.0 fixes a memory leak but introduces a non-compatible change for closing the RevWalk: before it was release() but now is close()
* Fix failure to save Allow Forks repository settingJames Moger2015-03-051-7/+3
|
* Merge branch 'ticket/238' into developJames Moger2015-02-261-1/+22
|\
| * issue 564: enable ticket page update on tomcat with redirectskrulls2015-02-261-1/+22
| | | | | | | | | | | | issue 564: fix imports issue 564
* | Integrate GitHub OcticonsJames Moger2014-10-235-75/+110
| |
* | Remove S# text, set severity in tooltipJames Moger2014-10-211-4/+4
| |
* | Tickets - Priority, Severity optionsPaul Martin2014-10-202-2/+13
| | | | | | | | | | | | | | | | | | + Severity indicated via new character indicator and color of ticket icon on ticket list + Priority indicated via new priority icon and color on ticket list + Indexed as integers to provide sorting and maintain language neutral index + Colours and indicator text controlled through CSS classes priority-<x> & severity-<x> + UITicketTest created to generate tickets of all types to ease debugging
* | Merge branch 'ticket/192' into developJames Moger2014-09-291-3/+3
|\|
| * Tweak styling of clear cache & new repository links on repositories panelJames Moger2014-09-291-3/+3
| |
* | Merge branch 'ticket/181' into developJames Moger2014-09-173-8/+9
|\|
| * Sanitize ticket text at presentation time to avoid unintended html encodingJames Moger2014-09-173-8/+9
| |
* | Merge branch 'ticket/171' into developJames Moger2014-09-081-9/+19
|\|
| * Fix potential NPE in TicketListPanel due to missing repositoryJames Moger2014-09-081-9/+19
| |
* | Show account type column in teams panel.Florian Zschocke2014-09-072-2/+5
| | | | | | | | Add a new column to the team panel, showing the account type.
* | Merge branch 'ticket/164' into developJames Moger2014-09-072-5/+6
|\|
| * Implement a SafeTextModel and use that for fields vulnerable to XSSJames Moger2014-09-072-5/+6
| |
* | Merge branch 'ticket/165' into developJames Moger2014-09-051-1/+1
|\|
| * Change Clippy's script access attributeJames Moger2014-09-051-1/+1
| |
* | Merge branch 'ticket/147' into developJames Moger2014-09-041-0/+3
|\|
| * Fix NPE when anonymous admins are editing a repository (issue-490)James Moger2014-09-041-0/+3
| |
* | Extract services manager into a top-level injectable managerJames Moger2014-07-031-2/+2
|/
* Do not serialize Loggerticket/114James Moger2014-06-272-5/+12
|
* Fix substring regression in repository name panelJames Moger2014-06-091-1/+2
|
* Use separate project and name field models in the RepositoryNamePanelJames Moger2014-06-091-39/+34
|
* Use AJAX to manage the SSH keys panelJames Moger2014-06-051-19/+27
|
* Add a basic SSH public key management UIJames Moger2014-06-054-0/+281
|
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-20 17:29:39 +0000