Reduce the icon margins a bit to conform better with other icons. Also
dial back the rounding a bit, again to fit better with other programs.

Some desktop environment, like KDE, need more rastered sizes and cannot
make use of the SVG.

This is already done by vncviewer, so we don't need any rule here.

Have the padding included in the SVGs to make the rules less complex.

This code is never used on Windows, so remove it.

Avoid the risk of the list of sizes and the list of icons getting out of
sync and causing memory corruption.

Minor fixes/future-proofing for SConnection::accessCheck() and 'accessRights'

These checks depend on accessRights being set up, this has only happened
if we have done the QUERYING steps.

Properties should be initialized in order to avoid random values in
case they are used earlier than expected.

FLTK has a lot of synchronous stuff (like dialogs), which mean that the
main loop might be run recursively in some cases. If there is data
available on our socket then CConn::socketEvent() will be called
constantly in a busy loop.

Avoid this by removing socket notifications whilst we are processing
data.

Enable this automatically for developers so we increase the chance of
these problems getting caught. There is a risk of overhead though so
keep them disabled for release builds.

Unfortunately this error can be given by GnuTLS even though the
underlying stream still has data available. So stop trusting this value
and keep track of the underlying stream explicitly.

It's a bit field so it's easier to decode in hex.

The browsers allow users to make an exception for expired certificates,
so we should probably also.

Otherwise we can get crashes on NULL dereference. This should only
happen on reverse connections where we don't have a server address.

We need to get to the point of starting the session script before we
consider things a success. So this can fail in many different ways, not
just the daemonization. Adjust the error message to something more
generic to reflect this.

Ubuntu 20.04
gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0
libx264-dev:amd64 2:0.155.2917+git0a84d98-2

[ 11%] Building CXX object common/rfb/CMakeFiles/rfb.dir/H264LibavDecoderContext.cxx.o
tigervnc/common/rfb/H264LibavDecoderContext.cxx: In member function ‘virtual bool rfb::H264LibavDecoderContext::initCodec()’:
tigervnc/common/rfb/H264LibavDecoderContext.cxx:50:40: error: invalid conversion from ‘const AVCodec*’ to ‘AVCodec*’ [-fpermissive]
   50 |   AVCodec *codec = avcodec_find_decoder(AV_CODEC_ID_H264);
      |                    ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
      |                                        |
      |                                        const AVCodec*
make[2]: *** [common/rfb/CMakeFiles/rfb.dir/build.make:895: common/rfb/CMakeFiles/rfb.dir/H264LibavDecoderContext.cxx.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:597: common/rfb/CMakeFiles/rfb.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

CentOS 8 is EOL and is now replaced with CentOS Stream 8.

This images isn't available on Docker Hub unfortunately, so we grab it
from Quay.

Instead of HOME_ROOT/.vnc, /root/.vnc should be used
for user root's home to specify default file context
as HOME_ROOT actually means base for home dirs (usually /home).

Avoid duplication, and add logging for some more error conditions so
it's possible to see in the logs why a resize has failed or produced
unexpected results.

The migration from 32-bit to 64-bit has long passed. Let's get rid of
all distinctions as native applications it the norm now.

This is obviously not maintained, so let's be more generic in the
document.

Otherwise things might be logged under the wrong label.

Linux implementation using ffmpeg

Unconditionally log the erroneous screen layout if it fails to
validate to simplify debugging.

If monitor mirroring was enabled while in a session with vncviewer
running on Linux, the session would not be properly resized on the
server. This was a consequence of only looking at the size and
coordinates of each screen when matching against existing screens after
the screen layout was changed, when in fact we have two (or more)
monitors with the same coordinates and size (but differing ids). This
led to the same monitor being added twice to the layout which would
later fail layout validation, resulting in no resize request being sent
to the server.

When matching, we now also check if the existing screen is not already
present in the layout before considering it a match.

This is a regression from ad0f061. If a VMware cursor rect was split up
over multiple read()s then the stream would become corrupted as we set
the restore point at the wrong place.

If we've explicitly requested a position (using -geometry) then we were
still triggering legacy full-screen request logic. This is very counter
intuitive as having a position that doesn't align with a monitor should
disqualify us for that.

It turns out that at least marco (and probably everything
metacity-derived) ends up ignoring the requested position and we go back
to triggering the legacy logic again.

Work around this by assuming that the window manager will adjust our
initial position and don't consider that in the workaround logic.

Update MonitorArrangement widget to match parameter settings after screen configuration change

If the options dialog was open when a screen configuration happened the
widget could get out of sync from the settings. A scenario when this
happened was:

 1) 3 monitors, fullscreen selected on the two right-most screens
 2) disconnect the left-most screen (the one not selected)

In this case, using GNOME, vncviewer would appear in fullscreen on the
right of the two remaining monitors, but the widget would show both
monitors selected. The reason was that the MonitorArragement index
doesn't work the same way as FLTK's screen index.

It's debatable how vncviewer should behave here, but the GUI should at
least match the actual setting.

There is no such thing as XDG_DESKTOP_NAMES.

The norm is to have error strings without punctiation, so avoid adding
one as it just confuses the translators.

Many window managers don't have proper logic to restrict the window size
to something sane, so we have to take care of that ourselves.