aboutsummaryrefslogtreecommitdiffstats
path: root/server/sonar-db-dao
diff options
context:
space:
mode:
authorLéo Geoffroy <99647462+leo-geoffroy-sonarsource@users.noreply.github.com>2022-10-11 11:00:11 +0200
committersonartech <sonartech@sonarsource.com>2022-10-12 20:03:44 +0000
commitb6bffded1c8e125cb2621b47ddcb9ddb0799b98f (patch)
treeb4242b18429340ad702cfcf5e602d215f1edaea9 /server/sonar-db-dao
parent2843c9415ea0308b1a5aea003f04f27e78f01f8b (diff)
downloadsonarqube-b6bffded1c8e125cb2621b47ddcb9ddb0799b98f.tar.gz
sonarqube-b6bffded1c8e125cb2621b47ddcb9ddb0799b98f.zip
SONAR-17352 Fix quality issues
Co-authored-by: Duarte Meneses <duarte.meneses@sonarsource.com>
Diffstat (limited to 'server/sonar-db-dao')
-rw-r--r--server/sonar-db-dao/src/main/java/org/sonar/db/component/ComponentDao.java2
-rw-r--r--server/sonar-db-dao/src/test/java/org/sonar/db/component/ComponentDaoTest.java4
2 files changed, 4 insertions, 2 deletions
diff --git a/server/sonar-db-dao/src/main/java/org/sonar/db/component/ComponentDao.java b/server/sonar-db-dao/src/main/java/org/sonar/db/component/ComponentDao.java
index c561e71775e..4eb3b7e177d 100644
--- a/server/sonar-db-dao/src/main/java/org/sonar/db/component/ComponentDao.java
+++ b/server/sonar-db-dao/src/main/java/org/sonar/db/component/ComponentDao.java
@@ -392,7 +392,7 @@ public class ComponentDao implements Dao {
mapper(session).setPrivateForRootComponentUuid(branchUuid, isPrivate);
}
- public void setPrivateForRootComponentUuid(DbSession session, String branchUuid, boolean isPrivate, @Nullable String qualifier, String componentKey, String componentName) {
+ public void setPrivateForRootComponentUuid(DbSession session, String branchUuid, boolean isPrivate, String qualifier, String componentKey, String componentName) {
ComponentNewValue componentNewValue = new ComponentNewValue(branchUuid, componentName, componentKey, isPrivate, qualifier);
auditPersister.updateComponentVisibility(session, componentNewValue);
mapper(session).setPrivateForRootComponentUuid(branchUuid, isPrivate);
diff --git a/server/sonar-db-dao/src/test/java/org/sonar/db/component/ComponentDaoTest.java b/server/sonar-db-dao/src/test/java/org/sonar/db/component/ComponentDaoTest.java
index 3533a00faea..706b1012917 100644
--- a/server/sonar-db-dao/src/test/java/org/sonar/db/component/ComponentDaoTest.java
+++ b/server/sonar-db-dao/src/test/java/org/sonar/db/component/ComponentDaoTest.java
@@ -299,7 +299,9 @@ public class ComponentDaoTest {
@Test
public void select_by_keys_throws_ISE_if_both_branch_and_pr_are_passed() {
- assertThatThrownBy(() -> underTest.selectByKeys(db.getSession(), List.of("key"), "branch", "pr"))
+ DbSession session = db.getSession();
+ List<String> keys = List.of("key");
+ assertThatThrownBy(() -> underTest.selectByKeys(session, keys, "branch", "pr"))
.isInstanceOf(IllegalStateException.class);
}