diff options
| author | Wouter Admiraal <wouter.admiraal@sonarsource.com> | 2019-04-04 15:16:46 +0200 |
|---|---|---|
| committer | SonarTech <sonartech@sonarsource.com> | 2019-05-29 20:21:13 +0200 |
| commit | 46d075adfb3c4a666010a14d925203690bad0f10 (patch) | |
| tree | e8ea0e2c628e2ddab3b02dd703a0f6dd31aa8ade /server/sonar-web/src/main/js/helpers/qualityGates.ts | |
| parent | 7853e9f613ae662e17a568bd70b3d65e5898ba80 (diff) | |
| download | sonarqube-46d075adfb3c4a666010a14d925203690bad0f10.tar.gz sonarqube-46d075adfb3c4a666010a14d925203690bad0f10.zip | |
Improve test coverage
Diffstat (limited to 'server/sonar-web/src/main/js/helpers/qualityGates.ts')
| -rw-r--r-- | server/sonar-web/src/main/js/helpers/qualityGates.ts | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/server/sonar-web/src/main/js/helpers/qualityGates.ts b/server/sonar-web/src/main/js/helpers/qualityGates.ts index 5dbb8a257b1..090647a8781 100644 --- a/server/sonar-web/src/main/js/helpers/qualityGates.ts +++ b/server/sonar-web/src/main/js/helpers/qualityGates.ts @@ -34,12 +34,10 @@ export function extractStatusConditionsFromProjectStatus( } export function isSameStatusConditionList( - conditions?: T.QualityGateStatusCondition[], - prevConditions?: T.QualityGateStatusCondition[] + conditions: T.QualityGateStatusCondition[] = [], + prevConditions: T.QualityGateStatusCondition[] = [] ): boolean { - if (conditions === undefined || prevConditions === undefined) { - return !(prevConditions || conditions); - } else if (conditions.length !== prevConditions.length) { + if (conditions.length !== prevConditions.length) { return false; } else { const filtered = conditions.filter(c1 => { |