| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
Same as IntListParameter and StringListParamter, but for enumerations.
|
|
|
|
|
| |
Same as for IntListParameter, consolidate the list handling code to a
single place.
|
|
|
|
| |
Consolidate handling of a list of values in a single piece of code.
|
|
|
|
|
| |
Consolidate validation of enumeration in a central place since this is
now a popular type of paramater.
|
|
|
|
|
| |
Complain so that the user/developer sees the issue rather than just
silently ignoring the problem.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Let's try to use something more proper for our unit tests.
|
|
|
|
|
| |
It's just string helper functions here, so let's get rid of the
catch-all name for this module.
|
|
|
|
|
|
|
| |
Make it clearer what is protocol handling and what is just general
plumbing.
This is one step of several.
|
|
|
|
|
|
|
| |
Make it clearer what is protocol handling and what is just general
plumbing.
This is one step of several.
|
|
|
|
|
|
|
| |
Make it clearer what is protocol handling and what is just general
plumbing.
This is one step of several.
|
|
|
|
|
|
|
| |
Make it clearer what is protocol handling and what is just general
plumbing.
This is one step of several.
|
|
|
|
|
|
|
|
| |
Try to keep the code more compact for the simple things where the type
should be obvious from the context. Helps us avoid line wrapping.
Also remove explicit conversions to Region where the compiler is able to
figure it out by itself, again to reduce line length.
|
|
|
|
|
| |
This is a network function, so it makes more sense in the network
library.
|
|
|
|
| |
Broken in e97e225.
|
|
|
|
|
| |
These two values were overlooked in the look-ahead list and hence did
not work reliably.
|
|
|
|
|
| |
Avoid duplicating this complexity everywhere and make sure all commands
get the same handling and fixes.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
This commit implements the pseudo-encoding ExtendedMouseButtons which
makes it possible to use the back/forward mouse buttons.
This commit contains work originally done by
PixelSmith <manny33@frontbuffer.com>.
|
| |
| |
| |
| |
| | |
Use the more specific already included exception classes for common
errors to keep things more understandable.
|
|/
|
|
|
| |
Make sure our exceptions are part of the standard exception class
hierarchy.
|
|
|
|
|
| |
This is a very limited bit field, so use an 8 bit type to clearly show
how many bits are available.
|
|
|
|
|
| |
It's a source of confusion and possibly bugs to reuse the same variable
name for multiple things.
|
|
|
|
|
| |
Use the new "override" keyword to properly differentiate between new
virtual methods, and existing virtual methods being overridden.
|
|
|
|
|
| |
It's more readable than 0, and a bit safer than NULL, so let's try to
follow modern norms.
|
|\ |
|
| |
| |
| |
| |
| |
| | |
These are not valid outside of UTF-16 so seeing them in a UTF-8 sequence
means that something is wrong with that sequence. Best to filter them
out rather than letting them propagate and have unknown effects.
|
| |
| |
| |
| |
| |
| | |
We should handle this in the low-level protocol code as much as possible
to avoid mistakes. This way the rest of the code can assume that strings
are always UTF-8 with \n line endings.
|
|/
|
|
|
| |
It is more specific, and it properly sets up propagation when include
directories also need to be used further down a dependency chain.
|
|
|
|
|
| |
It has now been replaced, mostly by std::string, so remove the actual
type definition.
|
|
|
|
|
|
| |
We mostly use classical C strings, but the memory management around them
can get confusing and error prone. Let's use std::string for the cases
where we need to return a newly allocated string.
|
|
|
|
|
| |
Avoid having our own custom stuff and instead use the modern, standard
types, for familiarity.
|
|
|
|
|
| |
This allows us to separate accidentally unused, from explicitly unused
parameters, which allows us to turn on such checks in the compiler.
|
|
|
|
|
| |
This makes sure the compiler doesn't complain about problems in those
files.
|
|
|
|
| |
This is to make the code more tolerant of typos when entering a hostname
|
|
|
|
| |
We should scope these as narrowely as possible to avoid side effects.
|
|
|
|
|
|
| |
The generally recommended way is to include it from source files, not
headers. We had a mix of both. Let's try to be consistent and follow the
recommended way.
|
|
|
|
|
| |
Some code points are reserved for the UTF-16 coding itself and must not
appear as input data to the algorithm.
|
|
|
|
| |
Signed bug prevented anything not ASCII from being coded correctly.
|
|
|
|
|
| |
Everything outside of BMP was handled incorrectly and was coded as
completely different code points.
|
|
|
|
|
|
|
|
| |
This would mess up most conversions from UTF-8 as the caller wouldn't
know how far to step to get to the next valid character, resulting in
markers for invalid data to be injected here and there.
Also add some unit tests to avoid this reoccurring.
|