diff options
| author | Anna Koskinen <Ansku@users.noreply.github.com> | 2019-11-04 13:26:32 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-11-04 13:26:32 +0200 |
| commit | 0b627f975ddae79d4d9d1cf4b12e6c31eb31eb7a (patch) | |
| tree | 32abf08c369e475e50b6a19322036bce2a435835 /client | |
| parent | f5984b1cb69e32ea138c72dc2f2b47809cda74f8 (diff) | |
| download | vaadin-framework-0b627f975ddae79d4d9d1cf4b12e6c31eb31eb7a.tar.gz vaadin-framework-0b627f975ddae79d4d9d1cf4b12e6c31eb31eb7a.zip | |
Check actual Grid selection instead of relying on allSelected flag. (#11787)
The checkbox for selecting all rows only selects all the rows that have
not been filtered out. Changing the filtering does not change the
selection or the checkbox state so assuming that all rows are selected
simply because the checkbox has been checked cannot work.
Fixes #11479
Diffstat (limited to 'client')
| -rw-r--r-- | client/src/main/java/com/vaadin/client/connectors/grid/MultiSelectionModelConnector.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/client/src/main/java/com/vaadin/client/connectors/grid/MultiSelectionModelConnector.java b/client/src/main/java/com/vaadin/client/connectors/grid/MultiSelectionModelConnector.java index 7bbc66d271..de003e6daf 100644 --- a/client/src/main/java/com/vaadin/client/connectors/grid/MultiSelectionModelConnector.java +++ b/client/src/main/java/com/vaadin/client/connectors/grid/MultiSelectionModelConnector.java @@ -250,7 +250,7 @@ public class MultiSelectionModelConnector @Override protected boolean isSelected(JsonObject item) { - return getState().allSelected || super.isSelected(item); + return super.isSelected(item); } /** |