gitblit.git - Pure java git solution: https://github.com/gitblit-org/gitblit

	Commit message (Collapse)	Author	Age	Files	Lines
*	Issue #1011: do not serialize JGit commit objects	Tom	2021-11-03	1	-11/+22
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	JGit commit objects are a recursive data structure; they have links to their parent commits. Serializing a JGit commit will try to recursively serialize all reachable ancestors as faras they have been loaded. If that ancestor chain is too long, a StackOverflowError is thrown during Wicket's page serialization if a page has a reference to sucha JGit commit. Fixed by making sure that pages o not contain references to JGit commits. Use the (existing) wrapper object RepositoryCommit instead. * RepositoryCommit has a transient reference to the JGit commit and reads the commit from the repository upon de-serialization. * RefModel is a similar case (JGit tags/branches may also have links to the commits they point to). Solved a bit differently by making it a pure data object by transferring the interesting data from the JGit object in the constructor. * Change DataViews instantiated with RevCommit to use RepositoryCommit instead. * Change inner anonymous DataViews to ensure they do not have a synthesized field referencing the "allRefs" map. Such a synthesized field would also get serialized, and then serialize JGit commits again. Finally, remove non-transient logger instances in Wicket classes. Those might lead to NotSerializableException. These StackOverflowErrors have been reported in several places since 2014: * https://groups.google.com/forum/#!topic/gitblit/GH1d8WSlR6Q * https://bugs.chromium.org/p/gerrit/issues/detail?id=3316 * https://groups.google.com/d/msg/repo-discuss/Kcl0JIGNiGk/0DjH4mO8hA8J * https://groups.google.com/d/msg/repo-discuss/0_P6A3fjTec/2kcpVPIUAQAJ * https://github.com/gitblit/gitblit/issues/1011 * https://github.com/tomaswolf/gerrit-gitblit-plugin/issues/21
*	Use author date to be consistent with other tools (fixes #919)	James Moger	2015-09-18	1	-1/+1
\|
*	Lower opacity for merge commit short messages in the log panel	James Moger	2014-03-03	1	-2/+3
\|
*	Fix author search links from compare pages	James Moger	2014-02-28	1	-1/+1
\|
*	Moved servlets and services to separate packages	James Moger	2013-11-29	1	-1/+1
\| \| \| \|	Change-Id: I5f0f50f4ae7d332e9f724a2e6f074fa71f646035
*	Eliminate nearly all direct GitBlit singleton references in Wicket	James Moger	2013-11-26	1	-4/+3
\| \| \| \| \| \| \| \| \| \|	This is the first step towards modularization and injection. All direct references to the GitBlit singleton within the Wicket pages and panels have been replaced to proxy methods in the GitBlitWebApp singleton. There are still two Wicket classes which rely on the GitBlit singleton; those require manual instantiation (servlet 3). Change-Id: I0cdbbcf87959d590c446c99abb09c07c87c737bc
*	Trim trailing whitespace and organize imports	James Moger	2013-09-30	1	-5/+6
\| \| \| \|	Change-Id: I9f91138b20219be6e3c4b28251487df262bff6cc
*	Fix commit log css for branch graphs	James Moger	2013-09-23	1	-1/+3
\|
*	Implemented a graph servlet based on EGit/JGit's PlotWalk (issue-194)	James Moger	2013-09-17	1	-0/+19
\| \| \| \| \| \| \| \| \|	The graph is generated server-side and therefore requires that the commit table row height be fixed and match the row height of the servlet. There will be layout misalignment if remotes refs are displayed. Perhaps this can be improved in the future. Change-Id: I39d0ffc7b1c3679976ce8c198c772ff86238f1a5
*	Organize imports	James Moger	2013-05-02	1	-1/+1
\|
*	Reorganized to Apache Standard Directory Layout & integrated Moxie	James Moger	2013-03-27	1	-0/+176
	This is a massive commit which reorganizes the entire project structure (although it is still monolithic), removes the Build classes, and switches to Moxie, a smarter Ant build tookit based on the original Gitblit Build classes. The Ant build script will likely require additional fine-tuning, but this is big step forward.