| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add 1px buffer to Escalator column natural widths.
The purpose of the buffer is to avoid subpixel handling issues,
especially when zoomed in or out.
In case fractions need to be adjusted for browser compatibility, round
up to ensure the contents have the space they need.
Fixes #12048
|
| |
|
|
|
|
|
|
|
|
|
| |
There might be pending requests in the queue when a resync request is
made (e.g. through a theme change). This can cause conflicts if the
resync request is handled immediately. Therefore the resync request
should also be added to the queue and only get resolved when
doSendInvocationsToServer() gets triggered again.
Fixes #11954
|
|
|
|
|
| |
- If the Grid has any columns with non-fixed widths, the presence of a
vertical scrollbar affects the column width calculations. Horizontal
scrollbar should only be shown when actually needed.
|
|
|
| |
Fixes #12049
|
|
|
|
| |
Delayed size changes caused by added or removed scrollbars should be
taken into account.
|
|
|
|
|
| |
Calculate number of the week in the year based on Date. Note, support for "ww" is missing from GWT DateTimeFormat and java.util.Calendar is not supported in GWT, hence DIY method is needed.
Fixes: #10603
|
|
|
| |
Fixes #12029
|
|
|
|
|
| |
* Add tests
* Fix getVisibleFrozenColumnCount() if SelectionMode is multi
|
|
|
|
|
|
|
|
|
| |
* Fix ComboBox in read-only mode allowing value change by user
Fixes #12021
* Fix popup hiding condition
Co-authored-by: Tatu Lund <tatu@vaadin.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(#12020)
* Add autocomplete prevention to DateField
Autocomplete popup will interfere DateField's own popup
* Adding disableBrowserAutocomplete(..) in WidgetUtil
* Change VComboBox to use WidgetUtil.disableBrowserAutocomplete(..)
* Change to use WidgetUtil.disableBrowserAutocomplete(..)
* Change VFilterSelect to use WidgetUtil.disableBrowserAutocomplete(..)
* Adding WidgetUtil.disableBrowserAutocomplete to VTextualDate
* Adding missing import
* Adding missing import
|
| |
|
|
|
|
|
|
|
| |
In Firefox and IE11, the 'Create Link' button of the RichTextArea (RTA) only works by turning some highlighted text into a link (by adding the inserted URI as the href property of the text). In that, the RTA in these two browsers behave similarly to the way it does in Chrome and Edge. However, in Firefox and IE11, clicking the 'Create Link' button has no effect if no text is pre-selected by the user. This is different from the button's behavior in Chrome and Edge where the user's provided URI is inserted, both, as the displayed text and its href property if no text is highlighted.
This fix enables the RTA's 'Create Link' button to work consistently across the supported browsers. Specifically, (and in addition to enabling adding the href property of a highlighted text), this fix enables Firefox and IE11 to also insert a new Uri as a text and its href property if no text is already highlighted.
fixes #11888
|
|
|
|
|
|
| |
* Take overlays into account in getConnectorForElement.
Fixes #11212
|
|
|
| |
Fixes #11824
|
|
|
| |
Fixes #11973
|
|
|
|
|
|
|
| |
The previous patch https://github.com/vaadin/framework/pull/11951 did fix the problem (frozen column indicator wrongly positioned) it was meant to, but caused a regression in hiding / un-hiding.
This new fix addresses both problems, i.e. it applies multiselect column compensation in other way, without causing problem in hiding / un-hiding logic
Fixes https://github.com/vaadin/framework/issues/11970
|
|
|
|
|
|
| |
* Don't center a window that has already been removed.
Fixes #11942
|
|
|
|
| |
Cherry pick from
https://github.com/vaadin/framework/pull/11946
|
| |
|
|
|
| |
Use 403 Forbidden instead of 410 Gone when session expired. Also prevent caching in more cases.
|
|
|
|
|
|
|
| |
Browsers differ in what they return as the content of a visually empty rich text area (RTA). Accordingly, RTA sanitizes these different values ensuring an empty string is returned to the framework. However, existing sanitization criteria doesn't work for Firefox 74 and Internet Explorer 11.
This fix appends the sanitization criteria of Firefox 74 and IE 11, ensuring an empty string is returned to the framework for a a visually empty RTA.
Closes #10338
|
|
|
| |
Fixes #11810
|
|
|
| |
Fixes #10419
|
|
|
| |
Fixes #10420
|
|
|
|
|
|
|
|
| |
Column widths shouldn't be calculated between the clearing of cache and
re-populating it, but be delayed until the cache has some content again.
The calculations should only be triggered immediately if no rows are
expected.
Fixes #9996
|
|
|
|
|
|
|
| |
* Fix an issue with frozen column count and unhiding.
Unhiding logic should take into account that there can be hidden frozen
columns that are not the column currently getting shown.
|
|
|
|
|
|
|
|
|
|
| |
There is no need to reset the sidebar for every column that is set
hidable within the same roundtrip. Because no other layouting depends on
the sidebar contents, we can safely delay the reset until all columns
have got their hidabiity status updated. As a bonus point, when the
reset itself is delayed, the headers have time to get populated and the
sidebar button's height can be determined immediately at attach. The
reset ensures that attach is called every time a column's hidability is
changed.
|
|
|
| |
Fixes #11892
|
|
|
|
|
|
|
|
|
|
|
| |
Removing ElementResizeListeners from an element makes it unmeasurable
and clears any saved measured values. Adding the listeners back makes
the element measurable again but doesn't add it to measuring queue.
Measuring needs to happen or any updates to expanded components within a
layout (without changes that would trigger full re-measuring of the
layout itself) lead to broken expand size calculations with any fixed
size elements assumed to have no size.
Fixes #10734
|
|
|
|
|
|
|
|
| |
* Further tweaks to ComboBox popup positioning.
- Updated a comment and renamed a private method for better clarity.
- Blocked unnecessary position updates.
- Added a test for #11866 / #11894.
|
|
|
|
|
|
|
|
| |
* Adding missing setPopupPosition(left, top);
setPopupPosition(left, top); needs to be called in order to top position to be set
Fixes https://github.com/vaadin/framework/issues/11894
|
|
|
|
|
|
|
|
| |
* Rewrote debouncing of onResize
Fixes https://github.com/vaadin/framework/issues/11892
* Fixing typo in variable name
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Removing code causing the trouble
Removing code that was apparently not needed in previous fix and caused regression
Fixes: https://github.com/vaadin/framework/issues/11895
* Added feature to test UI
* Added test case
* Adding missing import
* Fixing test UI
* Enable DateField
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix logic of lexicographical comparison of DateField range end
Fix logic of lexicographical comparison of DateField range end with large year numbers ( > 9999)
Fixes #11881
* Added tests
Purpose of dateFieldRangeYearDigitsIncrease() is to test that rangeEnd works correctly on 4 to 5 digits change boundary
Purpose of dateFieldRangeYearBigNumbersPopupOpens() is to test that popup opens also when there is more than 4 digits in year
* Fixing typo
* Add error message
* Set the date of the field in test
* Fixing
|
|
|
|
|
|
|
|
|
| |
(#11879)
- DateFields with month or year resolution should not get their date
reset to current date if the field's state is updated (e.g. by changing
read-only status or adding a range).
Fixes: #11864, #11605
|
|
|
|
|
| |
* Update to 8.11-SNAPSHOT
|
|
|
|
|
| |
(#11871)
Fixes #10854
|
|
|
|
|
|
| |
* Removed outdated spacer height update from removal process.
Fixes #11856
|
|
|
|
|
|
|
|
|
| |
* Fix to RadioButtonGroup readOnly handling.
Updated the connector to use the widget's enabled and readOnly handling
as intended.
Fixes #11843
|
|
|
|
|
|
|
|
| |
Expand ratio and spacing can cause ComboBox to miscalculate its own
position while layouting is still ongoing. Popup should not be
repositioned in such circumstances in order to avoid incorrect
intermediate states.
Continues on #11718
|
|
|
|
|
|
|
|
|
| |
Fixes #11838
Changes:
1. Close a window when maximized button is focused and ESC is pressed
2. Add additional check for a close button to react to the ESC key press
3. Rename a private method `onCloseClick` to `closeWindow` to allow code re-use
|
|
|
|
|
|
|
|
|
|
|
|
| |
If first attempt at scrolling doesn't succeed it's unlikely that
continuing to wait is going to make any difference. Cache should be
populated before triggering any actions that depend on the row being
visible, otherwise it should be enough to trust that scrollToRow
actually scrolls to row and once scrolling is done the row is as much in
view as it's going to get. This way we don't get into a situation where
Editor never opens because it's still waiting for that one last pixel
that can't be achieved thanks to browser zoom causing rounding errors.
Continues on #11672
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The attempt gets blocked later down the line in any case and never
reaches the server, but sending it messes up TreeGrid's internal state.
It gets stuck waiting for the resolution of the blocked call that can
then only be resolved by server-side sending its own expand/collapse
request programmatically. Until that happens no further expand/collapse
attempts will get sent to server even after the TreeGrid has been
enabled again.
Tree is also affected as it is built upon TreeGrid.
Fixes #11822
|
|
|
|
|
|
|
| |
(#11799)
There is a bug in TwinColSelect loging, it retains selection by indexes not by values after being sorted when new item has been added. This is a fixed by changing updateListBox method to retain the selection as it is being called after selection is being done.
Fixes: #11287
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- If an open popup is reset to its default position on every update from
the server before getting adjusted again to the actual expected
position, on heavier applications some of those intermediate positions
might get rendered. If the ComboBox is positioned at the right edge and
the popup contents are longer than the input field (i.e. popup should
open to the left, not right) this might cause flickering.
- Setting the default position is only actually needed when the popup is
opened in order to give it a baseline, otherwise it's better to simply
adjust the position if needed.
Continues on #11718
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fixing issue with Push stopping working in some circumstances
If new request is attempted when resynchronization is ongoing, the Push will stop working. This patch fixes the issue by aborting handleJson if resynch is already ongoing.
This PR supercedes https://github.com/vaadin/framework/pull/11786
Fixes #11702, #7719
* Call onResynchronize() in MessageHandler
* Optimizing
|
|
|
|
|
|
|
|
| |
The checkbox for selecting all rows only selects all the rows that have
not been filtered out. Changing the filtering does not change the
selection or the checkbox state so assuming that all rows are selected
simply because the checkbox has been checked cannot work.
Fixes #11479
|
|
|
|
|
|
| |
The filtering needs to be delayed, otherwise it's performed before the
new filter text is available and the old filter text is used instead.
Fixes #11779
|